Return-Path: linux-nfs-owner@vger.kernel.org Received: from fieldses.org ([174.143.236.118]:45917 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757272Ab1LNOHp (ORCPT ); Wed, 14 Dec 2011 09:07:45 -0500 Date: Wed, 14 Dec 2011 09:07:44 -0500 From: "J. Bruce Fields" To: Bryan Schumaker Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH] NFSD: Only reinitilize the recall_lru list under the recall lock Message-ID: <20111214140744.GA4322@fieldses.org> References: <1323812158-5183-1-git-send-email-bjschuma@netapp.com> <20111213221209.GA30904@fieldses.org> <4EE8A7BA.6050406@netapp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4EE8A7BA.6050406@netapp.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, Dec 14, 2011 at 08:42:18AM -0500, Bryan Schumaker wrote: > On Tue Dec 13 17:12:09 2011, J. Bruce Fields wrote: > > On Tue, Dec 13, 2011 at 04:35:58PM -0500, bjschuma@netapp.com wrote: > >> From: Bryan Schumaker > >> > >> unhash_delegation() will grab the recall lock before calling > >> list_del_init() in each of these places. This patch removes the > >> redundant calls. > > > > Looks right, thanks. (How did you happen across this?) > > I was looking over the fault injection stuff to see if I can figure out > where an occasional oops was coming from. It seems to happen when I > forget delegations, so I was looking at how other functions release > delegations to see if there was something I missed. The oops doesn't > happen often enough for me to know if this patch fixes it yet, though. Hm, OK. Could you post the oops? --b.