Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx2.netapp.com ([216.240.18.37]:61231 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752967Ab2BPRmG (ORCPT ); Thu, 16 Feb 2012 12:42:06 -0500 From: "Adamson, Dros" To: "Adamson, Dros" CC: Jim Rees , "Myklebust, Trond" , "" Subject: Re: [PATCH 1/3] NFSv4: Send implementation id with exchange_id Date: Thu, 16 Feb 2012 17:41:59 +0000 Message-ID: <6174C8A1-D1C7-4D26-97A1-1D983FA1D5F4@netapp.com> References: <1329409026-20466-1-git-send-email-dros@netapp.com> <20120216173022.GA29158@umich.edu> In-Reply-To: Content-Type: multipart/signed; boundary="Apple-Mail=_3B5CF786-8FA5-4B54-9652-29E668B20E99"; protocol="application/pkcs7-signature"; micalg=sha1 MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: --Apple-Mail=_3B5CF786-8FA5-4B54-9652-29E668B20E99 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Feb 16, 2012, at 12:37 PM, Adamson, Dros wrote: >=20 > On Feb 16, 2012, at 12:30 PM, Jim Rees wrote: >=20 >> Weston Andros Adamson wrote: >>=20 >> Send the nfs implementation id in EXCHANGE_ID requests unless the = module >> parameter nfs.send_implementation_id is 0. >>=20 >> This adds a CONFIG variable for the nii_domain that defaults to = "kernel.org". >>=20 >> Signed-off-by: Weston Andros Adamson >>=20 >> @@ -271,7 +273,12 @@ static int nfs4_stat_to_errno(int); >> 1 /* flags */ + \ >> 1 /* spa_how */ + \ >> 0 /* SP4_NONE (for now) */ + \ >> - 1 /* zero implemetation id array */) >> + 1 /* implemetation id array of size 1 */ = + \ >>=20 >> implemetation -> implementation >> Might as well fix this typo while you're at it. >>=20 >> General comment... If this is going to be configurable, I'd rather = make it a >> sysctl, and be able to set the id to whatever I want at run time. = But >> that's because I like to be able to break things. I suspect Trond = will >> disagree. >=20 > Hrm my ispell pass missed this. =85 I'll wait for additional comments before reposting. -dros= --Apple-Mail=_3B5CF786-8FA5-4B54-9652-29E668B20E99 Content-Disposition: attachment; filename="smime.p7s" Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIDTzCCA0sw ggIzoAMCAQICAQEwCwYJKoZIhvcNAQEFMEYxFzAVBgNVBAMMDldlc3RvbiBBZGFtc29uMQswCQYD VQQGEwJVUzEeMBwGCSqGSIb3DQEJARYPZHJvc0BuZXRhcHAuY29tMB4XDTExMDYwODIyMDc0NloX DTEyMDYwNzIyMDc0NlowRjEXMBUGA1UEAwwOV2VzdG9uIEFkYW1zb24xCzAJBgNVBAYTAlVTMR4w HAYJKoZIhvcNAQkBFg9kcm9zQG5ldGFwcC5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEK AoIBAQC8/tJxtovJEXYRfSsrFOWKHxIZGY7/2mBee1DpWuoGDbVNapefCC7WXe+Nqxz609w2J/Mk /k3trZ3Ge2NXK0tGnP9NzjkzpGA7rSpM3wUFsvbLMUEGfQpvV24/nYvcLHTvOOEUaDPpHduN94bD dwvyowzDIRIpF2MeRnOzBNeHkrGHlZdzPmGjm8tkhrDRRkDYHhlxaiG4z30KCfAazxomuINiy1kj vbndXooYMDoh9H63hgW4NkOedtLdflLa322DXQ3nFU7YbyOIjHVl1tgWJLDWf7WT3lsAB8KvuJZ5 zhsUB+fqxCKPJVRPDO1gjChvvtGiG1tGUUZz0H9Wx00zAgMBAAGjRjBEMA4GA1UdDwEB/wQEAwIH gDAWBgNVHSUBAf8EDDAKBggrBgEFBQcDBDAaBgNVHREEEzARgQ9kcm9zQG5ldGFwcC5jb20wDQYJ KoZIhvcNAQEFBQADggEBACv0niZSmW+psB1sJXULh3mecDbN2mj0bFpN1YNdjcV7BiOLJ1Rs1ibV f13h73z8C7SBsPXTM5si8gmJtOnXM5jsgtlql44h/RrjUr8+mtK5DPCZls9J7iz3cGthzwOPvxUj nMSv3BpRX5oJom5ESgCM9Nn4u/ECTlLMhEIOYnBFiN0eDxcxz+r1cpbHg3r0otIKyxLpeaCjP6AH F93EHp4T8Rb63y3CcDgxrQGHlTdVi3QvxaMUexUXD81fiA+UqsB/MKmRxB1Hs4Vf3Q/+ejcm78K1 ROF8TNPmNWRlKg3Y7cSFjZGzLuzXsvSsCbw4HLn0oZe/OfgSbarTAxttL5IxggHRMIIBzQIBATBL MEYxFzAVBgNVBAMMDldlc3RvbiBBZGFtc29uMQswCQYDVQQGEwJVUzEeMBwGCSqGSIb3DQEJARYP ZHJvc0BuZXRhcHAuY29tAgEBMAkGBSsOAwIaBQCgXTAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcB MBwGCSqGSIb3DQEJBTEPFw0xMjAyMTYxNzQxNTlaMCMGCSqGSIb3DQEJBDEWBBQs/J0m80qqhAFD jaFekY8B/1wuDDANBgkqhkiG9w0BAQEFAASCAQA1Gn/h6awrCdV/1wFaug2wFnFcCTJ1bblYjwdv O3Zwz6GqdNODmEZcfEycedHjvwDJRlN040Qiy3Pu/X0luTIm4OS50eH8YYgm8ftVhLvnc+r3Y8D6 Hoq4OLHmTmrOEfJahgnQrc3Kb01ZxNeVfzntvIYyCN5cQkXrk8zDyfJ9pL9eht5iF5reVhVdlPMt gz88tT86l1t/ucGcsCeSs0mCuZw3GKk2eI91xBoxpCjGJfPrrZGOUg3UTGB7YsBJunbzn+dS2zIT u5YSWNVfm/q0+/xSeDCrUV4Kc0hNpZ9ar+SUt7ndJBaZ+8ranJd/+CXOulN5J8ar7Tgka2r5xXrG AAAAAAAA --Apple-Mail=_3B5CF786-8FA5-4B54-9652-29E668B20E99--