Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail209.messagelabs.com ([216.82.255.3]:54898 "EHLO mail209.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751034Ab2BOPGf (ORCPT ); Wed, 15 Feb 2012 10:06:35 -0500 Message-ID: <4F3BC9F6.90409@nexenta.com> Date: Wed, 15 Feb 2012 19:06:30 +0400 From: Vitaliy Gusev MIME-Version: 1.0 To: "Adamson, Andy" CC: "Myklebust, Trond" , "J. Bruce Fields" , "linux-nfs@vger.kernel.org" Subject: Re: [PATCH] nfs41: Initialize slot->seq_nr at nfs4_init_slot_table() References: <1329256108-1535-1-git-send-email-gusev.vitaliy@nexenta.com> <1329259606.11759.15.camel@lade.trondhjem.org> <4F3AFD84.3020709@nexenta.com> <1329266587.28837.4.camel@lade.trondhjem.org> <20120215005315.GA9018@fieldses.org> <1329270628.28837.15.camel@lade.trondhjem.org> <0C12B635-0094-4099-B96C-3637B914A814@netapp.com> In-Reply-To: <0C12B635-0094-4099-B96C-3637B914A814@netapp.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-nfs-owner@vger.kernel.org List-ID: On 02/15/2012 07:01 PM, Adamson, Andy wrote: > > No, commit aacd5537270a752fe12a9914a207284fc2341c6d initializes and resets the slot tables with the ivalue > which is 1 for the forechannel and 0 for the back channel, just as in 3.2. nfs4_init_slot_table() doesn't use ivalue at all. > > To be clear from aacd5537: > > -static int nfs4_init_slot_tables(struct nfs4_session *session) > +static int nfs4_setup_session_slot_tables(struct nfs4_session *ses) > { > struct nfs4_slot_table *tbl; > - int status = 0; > + int status; > > - tbl =&session->fc_slot_table; > + dprintk("--> %s\n", __func__); > + /* Fore channel */ > + tbl =&ses->fc_slot_table; > if (tbl->slots == NULL) { > - status = nfs4_init_slot_table(tbl, > - session->fc_attrs.max_reqs, 1); > ^^^^^^^ > ivalue of 1 >