Return-Path: linux-nfs-owner@vger.kernel.org Received: from aa.linuxbox.com ([134.215.213.37]:1181 "EHLO aa.linuxbox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753850Ab2C2Oab (ORCPT ); Thu, 29 Mar 2012 10:30:31 -0400 Date: Thu, 29 Mar 2012 10:29:58 -0400 (EDT) From: "Matt W. Benjamin" To: "J. Bruce Fields" Cc: Jeff Layton , linux-nfs@vger.kernel.org, Trond Myklebust Message-ID: <482476724.65.1333031398432.JavaMail.root@thunderbeast.private.linuxbox.com> In-Reply-To: <1996969981.63.1333031372979.JavaMail.root@thunderbeast.private.linuxbox.com> Subject: Re: [PATCH] nfsd4: use auth_unix unconditionally on backchannel MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: Er, I meant to type, only with respect to v41. ----- "Matt W. Benjamin" wrote: > Hi, > > Am I correct that this limitation is only with respect to v40 (that's > how I read the comment and the code in fs/nfs/callback.c)? > > Thanks, > > Matt > > ----- "J. Bruce Fields" wrote: > > > On Wed, Mar 28, 2012 at 11:16:49PM +0000, Myklebust, Trond wrote: > > > On Wed, 2012-03-28 at 19:09 -0400, J. Bruce Fields wrote: > > > > This is a bandaid. > > > > > > > > I have a series of patches that actually implement the correct > > behavior, > > > > but that may not quite be ready for 3.4. > > > > > > > > --b. > > > > > > > > commit 2f026867c76171d26f003b211063ff0562097d5e > > > > Author: J. Bruce Fields > > > > Date: Wed Mar 28 14:18:16 2012 -0400 > > > > > > > > nfsd4: use auth_unix unconditionally on backchannel > > > > > > > > This isn't actually correct, but it works with the Linux > > client, and > > > > agrees with the behavior we used to have before commit > > 80fc015bdfe. > > > > > > Question: does the Linux client ever send you anything other than > > > AUTH_SYS credentials for the csa_sec_parms argument in > > CREATE_SESSION? > > > Anything other than that would be a bug, since our client doesn't > > > actually support RPCSEC_GSS in the callback channel. > > > > Right, I've never seen anything else, so I think the client's > > behaving > > as expected. > > > > But the server needs to be fixed to deal with the range of possible > > csa_sec_parms possibilities regardless. > > > > The only thing I find odd about the client behavior is why it even > > bothers with auth_sys when auth_null would work just as well and be > > even > > slightly simpler. > > > > --b. > > > > > > > > > Later patches will implement the spec-mandated behavior > (which > > is to use > > > > the security parameters explicitly given by the client in > > create_session > > > > or backchannel_ctl). > > > > > > > > > > > > > -- > > > Trond Myklebust > > > Linux NFS client maintainer > > > > > > NetApp > > > Trond.Myklebust@netapp.com > > > www.netapp.com > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-nfs" > > in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > Matt Benjamin > The Linux Box > 206 South Fifth Ave. Suite 150 > Ann Arbor, MI 48104 > > http://linuxbox.com > > tel. 734-761-4689 > fax. 734-769-8938 > cel. 734-216-5309 -- Matt Benjamin The Linux Box 206 South Fifth Ave. Suite 150 Ann Arbor, MI 48104 http://linuxbox.com tel. 734-761-4689 fax. 734-769-8938 cel. 734-216-5309