Date: Sun, 4 Mar 2012 22:46:38 -0600
From: Malahal Naineni <malahal@us.ibm.com>
To: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] Get normalized paths for comparing NFS export paths
Message-ID: <20120305044638.GA12833@us.ibm.com>
References: <4F2E620F.5090100@panasas.com>
 <20120207204401.GA31752@us.ibm.com>
 <4F511B21.1020907@RedHat.com>
 <20120302192758.GA28389@us.ibm.com>
 <4F513429.1050209@RedHat.com>
 <20120302220108.GA17119@us.ibm.com>
 <4F525741.2060404@RedHat.com>
 <1330801976.2781.19.camel@lade.trondhjem.org>
 <4F53ED3C.2020209@RedHat.com>
 <1330901196.14357.7.camel@lade.trondhjem.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <1330901196.14357.7.camel@lade.trondhjem.org>
Sender: linux-nfs-owner@vger.kernel.org

Myklebust, Trond [Trond.Myklebust@netapp.com] wrote:
> No. Please don't strip the multiple slashes either. Just leave the path
> alone after you've separated it from the devicename.
> 
> It is quite OK to normalize the path on the _client_ side (i.e.
> change //mnt to /mnt or whatever) but don't touch the server side.

As I understand, we can normalize and store it in /etc/mtab and
normalization is done by the kernel for /proc/mounts. In other words,
follow the kernel and make the /etc/mtab entries consistent with the
kernel.

In my patch, I decided to normalize at umount time when we compare the
mtab and proc file entries.

Any opinion on which one is better?

Thanks, Malahal.