From: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
To: "Adamson, Andy" <William.Adamson@netapp.com>
CC: Andy Adamson <androsadamson@gmail.com>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH Version 1 08/11] SUNRPC: add rpc_drain_queue to empty an
 rpc_waitq
Date: Mon, 19 Mar 2012 17:31:37 +0000
Message-ID: <1332178298.2636.11.camel@lade.trondhjem.org>
References: <1331836850-5195-1-git-send-email-andros@netapp.com>
	 <1331836850-5195-9-git-send-email-andros@netapp.com>
	 <1331856643.24392.3.camel@lade.trondhjem.org>
	 <CAHVgHyWPPu_+9-6mr__n3q-BP=0C+=_5SwTwzZqMiBqQJonp+A@mail.gmail.com>
	 <1331911317.2518.14.camel@lade.trondhjem.org>
	 <8587FE07-0E16-4E0B-BCBE-7B295B89062C@netapp.com>
	 <69F651CF-0BAF-491F-B557-BC0607356E4F@netapp.com>
	 <1BF4551A-75CC-4E5F-A39B-A8DE645653F3@netapp.com>
In-Reply-To: <1BF4551A-75CC-4E5F-A39B-A8DE645653F3@netapp.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-nfs-owner@vger.kernel.org

T24gTW9uLCAyMDEyLTAzLTE5IGF0IDE2OjQ5ICswMDAwLCBBZGFtc29uLCBBbmR5IHdyb3RlOg0K
PiBPbiBNYXIgMTksIDIwMTIsIGF0IDEyOjQ0IFBNLCBBbmR5IEFkYW1zb24gd3JvdGU6DQo+IA0K
PiA+IA0KPiA+IFRoZSByZWFzb24gcnBjX3dha2VfdXAoKSBkb2VzIG5vdCB3YWtlIHVwIGFsbCB0
aGUgdGFza3MsIGlzIHRoYXQgaXQgdXNlcyBsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUgd2hpY2gg
YXNzaWducyB0aGUgIm5leHQiIHRhc2stPnUudGtfd2FpdC5saXN0cyBwb2ludGVyIGluIGl0J3Mg
Zm9yIGxvb3Agd2l0aG91dCB0YWtpbmcgaW50byBjb25zaWRlcmF0aW9uIHRoZSBwcmlvcml0eSBx
dWV1ZSB0YXNrcyBoYW5naW5nIG9mZiB0aGUgIHRhc2stPnUudGtfd2FpdC5saW5rcyBsaXN0IChu
b3RlICJsaXN0IiB2cnMgImxpbmsiKSBhc3NpZ25lZCBpbiB0aGUgZm9yIGxvb3AgYm9keSBieSB0
aGUgY2FsbCB0byBycGNfd2FrZV91cF90YXNrX3F1ZXVlX2xvY2tlZC4NCj4gPiANCj4gPiBTYXkg
d2UgaGF2ZSBhIHdhaXQgcXVldWUgd2l0aCB0aGUgZm9sbG93aW5nOiBPbmUgdGFzayBpbiB0aGUg
bGlzdCAoVDEpIGFuZCB0d28gcHJpb3JpdHkgdGFza3MgaW4gVDEncyAibGlua3MiIGxpc3QgKFQy
LCBUMykuDQo+ID4gDQo+ID4gSCAtPiBUMSAtPiBIICAgIHRoZSBuZXh0IHBvaW50ZXJzIGluIHRo
ZSAibGlzdHMiIGxpc3QgKFQxLT51LnRrX3dhaXQubGlzdCkgaGFuZ2luZyBvZmYgdGhlIGxpc3Qg
aGVhZCAiSCINCj4gPiANCj4gPiBUMSAtPiBUMiAtPiBUMy0+VDEgIHRoZSBuZXh0IHBvaW50ZXJz
IGluIHRoZSAibGlua3MiIGxpc3QuIChUMS0+dS50a193YWl0LmxpbmtzIGlzIHRoZSBsaXN0IGhl
YWQpDQo+ID4gDQo+ID4gSGVyZSBpcyB3aGF0IHJwY193YWtlX3VwX3Rhc2tfcXVldWVfbG9ja2Vk
IGRvZXMgKGl0IGNhbGxzIF9fcnBjX3JlbW92ZV93YWl0X3F1ZXVlX3ByaW9yaXR5IG9uIHByaW9y
aXR5IHF1ZXVlcykNCj4gPiANCj4gPiBIIC0+IFQyIC0+SA0KPiA+IA0KPiA+IFQyIC0+IFQzIC0+
IFQyDQo+ID4gDQo+ID4gd2l0aCBUMSByZW1vdmVkLiAgVGhpcyBpcyBleGFjdGx5IHdoYXQgc2hv
dWxkIGhhcHBlbiwgVDEgaXMgcmVtb3ZlZCwgVDEncyB1LnRrX3dhaXQubGlua3MgbGlzdCBpcyBz
cGxpY2VkIG9udG8gVDIncyB1LnRrX3dhaXQubGlua3MsIGFuZCBUMiBpcyBtb3ZlZCB0byBIJ3Mg
bGlzdCBvZiB1LnRrX3dhaXQubGlzdCB0YXNrcy4NCj4gPiANCj4gPiANCj4gPiAjZGVmaW5lIGxp
c3RfZm9yX2VhY2hfZW50cnlfc2FmZShwb3MsIG4sIGhlYWQsIG1lbWJlcikgICAgICAgICAgICAg
ICAgICBcDQo+ID4gICAgICAgIGZvciAocG9zID0gbGlzdF9lbnRyeSgoaGVhZCktPm5leHQsIHR5
cGVvZigqcG9zKSwgbWVtYmVyKSwgICAgICBcDQo+ID4gICAgICAgICAgICAgICAgbiA9IGxpc3Rf
ZW50cnkocG9zLT5tZW1iZXIubmV4dCwgdHlwZW9mKCpwb3MpLCBtZW1iZXIpOyBcDQo+ID4gICAg
ICAgICAgICAgJnBvcy0+bWVtYmVyICE9IChoZWFkKTsgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBcDQo+ID4gICAgICAgICAgICAgcG9zID0gbiwgbiA9IGxpc3RfZW50cnkobi0+
bWVtYmVyLm5leHQsIHR5cGVvZigqbiksIG1lbWJlcikpDQo+ID4gDQo+ID4gDQo+ID4gQlVUISAg
dGhlIGZvciBsb29wIGluICBsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUodGFzaywgbmV4dCwgaGVh
ZCwgdS50a193YWl0Lmxpc3QpICBkb2VzIHRoZSBmb2xsb3dpbmcgb24gdGhlIGFib3ZlIGV4YW1w
bGU6DQo+ID4gDQo+ID4gU3RhcnQ6DQo+ID4gDQo+ID4gSC0+IFQxIC0+IEgNCj4gPiBUMSAtPiBU
MiAtPiBUMyAtPiBUMQ0KPiA+IA0KPiA+IGZvciBsb29wIEluaWl0aWFsaXplcjoNCj4gPiANCj4g
PiB0YXNrID0gbGlzdF9lbnRyeSgoaGVhZCktPm5leHQsIHR5cGVvZigqdGFzayksIHUudGtfd2Fp
dC5saXN0KTogDQo+ID4gbmV4dCA9IGxpc3RfZW50cnkodGFzay0+dS50a193YWl0Lmxpc3QubmV4
dCwgdHlwZW9mKCp0YXNrKSwgdS50a193YWl0Lmxpc3QpDQo+ID4gDQo+ID4gc28gdGFzayA9IFQx
LCBuZXh0ID0gSC4NCj4gPiANCj4gPiBmb3IgbG9vcCB0ZXN0Og0KPiA+IHRhc2sgIT0gSC4gVGhp
cyBpcyBGQUxTRQ0KPiANCj4gb29wcyAtIGdvdCBteSBUUlVFL0ZBTFNFIG1peGVkIDspDQo+ICB0
aGlzIGlzIFRSVUUgc28gZXhlY3V0ZSBib2R5DQo+IA0KPiA+IA0KPiA+IGZvciBsb29wIGJvZHk6
DQo+ID4gY2FsbCBycGNfd2FrZV91cF90YXNrX3F1ZXVlX2xvY2tlZA0KPiA+IA0KPiA+IEggLT4g
VDIgLT4gSA0KPiA+IFQyIC0+LlQzIC0+IFQyDQo+ID4gDQo+ID4gZm9yIGxvb3AgaW5jcmVtZW50
IHN0ZXANCj4gPiB0YXNrID0gbmV4dDsgDQo+ID4gbmV4dCA9IGxpc3RfZW50cnkobmV4dC0+dS50
a193YWl0Lmxpc3QubmV4dCwgdHlwZW9mKCpuZXh0KSwgdS50a193YWl0Lmxpc3QpOw0KPiA+IA0K
PiA+IHNvIHRhc2sgPSBILCBuZXh0ID0gSC4NCj4gPiANCj4gPiBmb3IgbG9vcCB0ZXN0DQo+ID4g
DQo+ID4gdGFzayAhPSBIICBUaGlzIGlzIFRSVUUNCj4gDQo+IGFuZCB0aGlzIGlzIEZBTFNFIGRv
IGRvbid0IGV4ZWN1dGUgYm9keQ0KPiANCj4gLS0+QW5keQ0KPiA+IA0KPiA+IHNvIHN0b3AuDQo+
ID4gDQo+ID4gTm90ZSB0aGF0IG9ubHkgVDEgd2FzIHByb2Nlc3NlZCAtIFQyIGFuZCBUMyBhcmUg
c3RpbGwgb24gdGhlIHF1ZXVlLg0KPiA+IA0KPiA+IFNvIGxpc3RfZm9yX2VhY2hfZW50cnlfc2Fm
ZSB3aWxsIG5vdCBwcm9jZXNzIGFueSB1LnRrX3dhaXQubGlua3MgdGFza3MsIGJlY2F1c2UgdGhl
IG5leHQgcG9pbnRlciBpcyBhc3NpZ25lZCBwcmlvciB0byB0aGUgY2FsbCB0byBycGNfd2FrZV91
cF90YXNrX3F1ZXVlX2xvY2tlZCwgc28gdGhlIGZvciBsb29wIGluY3JlbWVudCAob3IgaW5pdGlh
bGl6YXRpb24pIHNldHRpbmcgb2Y6DQo+ID4gDQo+ID4gdGFzayA9IG5leHQ6DQo+ID4gDQo+ID4g
ZG9lcyBOT1QgcGljayB1cCB0aGUgZmFjdCB0aGF0IChpbiBvdXIgZXhhbXBsZSkgVDEgd2FzIFJF
UExBQ0VEIGJ5IFQyLCBub3QganVzdCByZW1vdmVkLg0KPiA+IA0KPiA+IE9uIHRoZSBvdGhlciBo
YW5kLCB0aGUgcnBjX2RyYWluX3F1ZXVlKCkgcGF0Y2ggdXNlcyB3aGlsZSghbGlzdF9lbXB0eSgp
KSBpbnN0ZWFkIG9mIGxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZSgpIGFuZCBoYXBwaWx5IHByb2Nl
c3NlcyBhbGwgb2YgdGhlIHRhc2tzIG9uIHRoZSBxdWV1ZToNCj4gPiANCj4gPiBIIC0+IFQxIC0+
IEgNCj4gPiANCj4gPiBsaWxzdCBpcyBub3QgZW1wdHksIHNvIGNhbGwgcnBjX3dha2VfdXBfdGFz
a19xdWV1ZV9sb2NrZWQuDQo+ID4gDQo+ID4gSCAtPiBUMiAtPiBIDQo+ID4gDQo+ID4gbGlzdCBp
cyBub3QgZW1wdHk7IHNvIGNhbGwgcnBjX3dha2VfdXAgX3Rhc2tfcXVldWVfbG9ja2VkLg0KPiA+
IA0KPiA+IEggLT4gVDMgLT4gSA0KPiA+IA0KPiA+IGxpc3QgaXMgbm90IGVtcHR5OyBzbyBjYWxs
IHJwY193YWtlX3VwX3Rhc2tfcXVldWVfbG9ja2VkDQo+ID4gDQo+ID4gbGlzdCBpcyBlbXB0eS4N
Cj4gPiANCj4gPiANCj4gPiAtLT5BbmR5DQo+ID4gDQoNClRoYW5rcyBBbmR5ISEhIFlvdXIgZXhw
bGFuYXRpb24gbWFrZXMgcGVyZmVjdCBzZW5zZS4gSSBjYW4ndCBiZWxpZXZlDQp0aGF0IHdlJ3Zl
IG1pc3NlZCB0aGlzLi4uDQoNCkknbGwgd3JpdGUgYSBwYXRjaCBmb3IgdGhlIHZhcmlvdXMgY2Fz
ZXMgdGhhdCB3ZSBuZWVkIHRvIGZpeC4NCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5G
UyBjbGllbnQgbWFpbnRhaW5lcg0KDQpOZXRBcHANClRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29t
DQp3d3cubmV0YXBwLmNvbQ0KDQo=