Return-Path: linux-nfs-owner@vger.kernel.org Received: from natasha.panasas.com ([67.152.220.90]:49722 "EHLO natasha.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753683Ab2CBWGw (ORCPT ); Fri, 2 Mar 2012 17:06:52 -0500 Message-ID: <4F514470.9050201@panasas.com> Date: Fri, 2 Mar 2012 14:06:40 -0800 From: Boaz Harrosh MIME-Version: 1.0 To: Chuck Lever CC: Benny Halevy , Linux NFS Mailing List , Trond Myklebust Subject: Re: [PATCH 15/15] NFS: Fix some minor problems with nfs4_deviceids References: <20120301215755.2138.73488.stgit@degas.1015granger.net> <20120301220222.2138.65095.stgit@degas.1015granger.net> <1330641595.15828.16.camel@lade.trondhjem.org> <4D0F430A-73F2-4AAE-A087-302EE08D29C0@oracle.com> <4F51429B.1040106@panasas.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Sender: linux-nfs-owner@vger.kernel.org List-ID: On 03/02/2012 02:03 PM, Chuck Lever wrote: > > On Mar 2, 2012, at 4:58 PM, Boaz Harrosh wrote: >> If you want I can use the get_unaligned() macro if you prefer. That should be perfectly safe. >> (And will do nothing on x86 ARCs) > > Basically we would just use get_unaligned() in the _DEVID_LO and _DEVID_HI macros. > Perfect yes! Could you spin that or you need that I'll send it? >> I agree that it should stay just old plain "char data[NFS4_DEVICEID4_SIZE];" >> >> Thanks >> Boaz Thanks Chuck, for catching this Boaz