Return-Path: linux-nfs-owner@vger.kernel.org Received: from acsinet15.oracle.com ([141.146.126.227]:25170 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757089Ab2CBWLd convert rfc822-to-8bit (ORCPT ); Fri, 2 Mar 2012 17:11:33 -0500 Subject: Re: [PATCH 15/15] NFS: Fix some minor problems with nfs4_deviceids Mime-Version: 1.0 (Apple Message framework v1257) Content-Type: text/plain; charset=us-ascii From: Chuck Lever In-Reply-To: <4F514470.9050201@panasas.com> Date: Fri, 2 Mar 2012 17:11:26 -0500 Cc: Benny Halevy , Linux NFS Mailing List , Trond Myklebust Message-Id: <938067E8-AD4F-49B1-B499-5146FBBB2AEC@oracle.com> References: <20120301215755.2138.73488.stgit@degas.1015granger.net> <20120301220222.2138.65095.stgit@degas.1015granger.net> <1330641595.15828.16.camel@lade.trondhjem.org> <4D0F430A-73F2-4AAE-A087-302EE08D29C0@oracle.com> <4F51429B.1040106@panasas.com> <4F514470.9050201@panasas.com> To: Boaz Harrosh Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mar 2, 2012, at 5:06 PM, Boaz Harrosh wrote: > On 03/02/2012 02:03 PM, Chuck Lever wrote: >> >> On Mar 2, 2012, at 4:58 PM, Boaz Harrosh wrote: >>> If you want I can use the get_unaligned() macro if you prefer. That should be perfectly safe. >>> (And will do nothing on x86 ARCs) >> >> Basically we would just use get_unaligned() in the _DEVID_LO and _DEVID_HI macros. >> > > Perfect yes! > > Could you spin that or you need that I'll send it? I still need someone with OSD pNFS set up to test. Can I send you a proposed patch? > >>> I agree that it should stay just old plain "char data[NFS4_DEVICEID4_SIZE];" >>> >>> Thanks >>> Boaz > > Thanks Chuck, for catching this > Boaz > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Chuck Lever chuck[dot]lever[at]oracle[dot]com