Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-yx0-f174.google.com ([209.85.213.174]:48724 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752932Ab2CUPfY (ORCPT ); Wed, 21 Mar 2012 11:35:24 -0400 Received: by yenl12 with SMTP id l12so1030337yen.19 for ; Wed, 21 Mar 2012 08:35:23 -0700 (PDT) Date: Wed, 21 Mar 2012 08:35:19 -0700 From: Greg KH To: Boaz Harrosh Cc: Andrew Morton , "Rafael J. Wysocki" , keyrings@linux-nfs.org, linux-security-module@vger.kernel.org, linux-fsdevel , linux-kernel , NFS list , Trond Myklebust , "Bhamare, Sachin" , David Howells , Eric Paris , "Srivatsa S. Bhat" , Kay Sievers , James Morris , "Eric W. Biederman" , Greg Kroah-Hartman Subject: Re: [PATCHSET 0/4] kmod: Optional timeout on the wait in call_usermodehelper_exec Message-ID: <20120321153519.GB30250@kroah.com> References: <4F691059.30405@panasas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4F691059.30405@panasas.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, Mar 20, 2012 at 04:18:49PM -0700, Boaz Harrosh wrote: > Andrew Hi > > I'm picking on you because I don't have any one else to pick on. > The 3 first patches here, are just good for today. Please see if > you would like to take them? or tell me who should take them? > > The 4th patch is an RFC, which got me looking into this. > > My motivation is that I added yet another Kernel dependency on the > call_usermodehelper() function and am not completely happy with the > error case of having the user-mode program stuck forever. In such > case I would like the Kernel part to timeout and properly error recover > and clean up. So therefor the proposed 4th patch. What is this new use of call_usermodhelper that you are doing this work for? Ideally, you never want to make this call, as it's slow and messy, as you have found out. Is there an in-kernel user that you have recently added? thanks, greg k-h