Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx2.netapp.com ([216.240.18.37]:53263 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755623Ab2CSVcs convert rfc822-to-8bit (ORCPT ); Mon, 19 Mar 2012 17:32:48 -0400 From: "Adamson, Andy" To: Andy Adamson CC: "Myklebust, Trond" , "Adamson, Andy" , "linux-nfs@vger.kernel.org" Subject: Re: [PATCH Version 1 07/11] NFSv4.1 Check invalid deviceid upon slot table waitq wakeup Date: Mon, 19 Mar 2012 21:32:45 +0000 Message-ID: <110373F8-CDA5-416C-85D3-F31775667D03@netapp.com> References: <1331836850-5195-1-git-send-email-andros@netapp.com> <1331836850-5195-8-git-send-email-andros@netapp.com> <1331857679.24392.9.camel@lade.trondhjem.org> In-Reply-To: Content-Type: text/plain; charset="Windows-1252" MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mar 16, 2012, at 11:12 AM, Andy Adamson wrote: > On Thu, Mar 15, 2012 at 8:27 PM, Myklebust, Trond > wrote: >> On Thu, 2012-03-15 at 14:40 -0400, andros@netapp.com wrote: >>> From: Andy Adamson >>> >>> Register a new filelayout DS rpc_action callback for sleeping on the fore >>> channel slot table waitq. Avoid any additional RPC FSM states >>> (such as timeout) when waking up to an invalid deviceid and reset >>> the task for io to the MDS. >> >> Why can't you simply put this call to filelayout_write_sleepon_cb in >> filelayout_write_prepare (before calling nfs41_setup_sequence())? > > I guess I can. Will do. Actually, I that won't work. > > -->Andy > >> >> Since nothing is going to change the task->tk_action if >> nfs41_setup_sequence() puts you to sleep, what value does the callback >> add? The rpc_action remains rpc_call_prepare. But! We want the tasks coming off the failed DS fore channel slot table queue to be redirected to the MDS nfs_XXX_prepare, not the filelayout_xxx_prepare. Note that filelayout_reset_read and filelayout_reset_write set the data->ds_clp to NULL which makes the call to nfs41_setup_sequence() in filelayout_write/read_prepare Oops?.. So, I'll keep this patch as is. -->Andy > >> Linux NFS client maintainer >> >> NetApp >> Trond.Myklebust@netapp.com >> www.netapp.com >>