Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:30099 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932241Ab2CBSua (ORCPT ); Fri, 2 Mar 2012 13:50:30 -0500 Message-ID: <4F511675.8000500@RedHat.com> Date: Fri, 02 Mar 2012 13:50:29 -0500 From: Steve Dickson MIME-Version: 1.0 To: Chuck Lever CC: "Myklebust, Trond" , "linux-nfs@vger.kernel.org" Subject: Re: [PATCH 09/15] NFS: Add a client-side function to display NFS file handles References: <20120301215755.2138.73488.stgit@degas.1015granger.net> <20120301220131.2138.63609.stgit@degas.1015granger.net> <1330640881.15828.9.camel@lade.trondhjem.org> <4F51009E.6030906@RedHat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 03/02/2012 12:19 PM, Chuck Lever wrote: > > On Mar 2, 2012, at 12:17 PM, Steve Dickson wrote: > >> >> >> On 03/01/2012 05:28 PM, Myklebust, Trond wrote: >>> On Thu, 2012-03-01 at 17:01 -0500, Chuck Lever wrote: >>>> For debugging, introduce a simplistic function to print NFS file >>>> handles on the system console. The main function is hooked into the >>>> dprintk debugging facility, but you can directly call the helper, >>>> _nfs_display_fhandle(), if you want to print a handle unconditionally. >>>> >>>> Signed-off-by: Chuck Lever >>>> --- >>>> >>> >>> One of the things that I really like about wireshark is that it also >>> displays a 32-bit hexadecimal hash of the filehandle. That allows you to >>> compare 2 filehandles _much_ faster than trying to look at the full >>> shebang. >>> >>> >> +1 Being able to easily trace filehandle in both the kernel debug and >> wireshark would be huge.... IMHO... > > Dros mentioned a possible follow-on patch last night at the pub that would add exactly this functionality. > And they say good things don't come out of debauchery!!! 8-)