Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-ob0-f174.google.com ([209.85.214.174]:57273 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751324Ab2DNA4k (ORCPT ); Fri, 13 Apr 2012 20:56:40 -0400 Received: by obbta14 with SMTP id ta14so1292053obb.19 for ; Fri, 13 Apr 2012 17:56:39 -0700 (PDT) Message-ID: <4F88CB43.6020506@gmail.com> Date: Fri, 13 Apr 2012 19:56:35 -0500 From: Calvin Owens MIME-Version: 1.0 To: Dean CC: "Myklebust, Trond" , "linux-nfs@vger.kernel.org" Subject: Re: [GSoC Project] Implementing NFS v4.2 References: <4F7E32D4.3030201@gmail.com> <1333682276.4792.32.camel@lade.trondhjem.org> <4F88B124.9030002@gmail.com> In-Reply-To: <4F88B124.9030002@gmail.com> Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 04/13/2012 06:05 PM, Dean wrote: >> >> >> >> The efficient sparse file read and fadvise support might be nice too, >> but I'd like to see numbers for how they improve matters before I feel >> comfortable saying yea or nay to adding those specific features. > > Instead of '...but I'd like to see...' I assume you meant, '...since I'd like to see...', as it would be hard to see how they improve matters without actually implementing them. > > Although for sparse file reads, I think the low overhead design to avoid bloating every file upon read in NFSv4.2 makes it easy to see the benefit without any implementation. For ioadvise, I think the benefit will be dependent upon support from the exported file system (or possibly nfs server). So any prototype would have to be combined with appropriate support in the server file system or nfs server. > > Dean Well, that would make my project a lot more straightforward: if you guys want the ADB sparse file reads, I could just call it "Implementing Sparse File Support for NFS", and implement sections 3, 4, and 6 of the v4.2 internet-draft. That seems like enough. fadvise() has the same behaviour for all filesystems, doesn't it? If wanting more efficient VM virtual disks over NFS is driving the sparse file stuff, I can see how POSIX_FADV_RANDOM on the server end would help with that. Calvin