Return-Path: linux-nfs-owner@vger.kernel.org Received: from fieldses.org ([174.143.236.118]:38318 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756559Ab2D3Vlm (ORCPT ); Mon, 30 Apr 2012 17:41:42 -0400 Date: Mon, 30 Apr 2012 17:41:37 -0400 From: "J. Bruce Fields" To: Randy Dunlap Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , linux-nfs@vger.kernel.org, Andrew Morton , Linus Torvalds Subject: Re: [PATCH resend] nfsd: fix nfs4recover.c printk format warning Message-ID: <20120430214137.GC22323@fieldses.org> References: <20120419164643.d9f918d44c890722b7707508@canb.auug.org.au> <4F909C78.7000008@xenotime.net> <4F9EE72B.1020401@xenotime.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4F9EE72B.1020401@xenotime.net> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, Apr 30, 2012 at 12:25:31PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix printk format warnings -- both items are size_t, > so use %zu to print them. > > fs/nfsd/nfs4recover.c:580:3: warning: format '%lu' expects type 'long unsigned int', but argument 3 has type 'size_t' > fs/nfsd/nfs4recover.c:580:3: warning: format '%lu' expects type 'long unsigned int', but argument 4 has type 'unsigned int' > > Signed-off-by: Randy Dunlap > Cc: "J. Bruce Fields" > Cc: linux-nfs@vger.kernel.org Looks like Linus just took this. (Thanks!) --b. > --- > fs/nfsd/nfs4recover.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > This patch was originally sent on Apr.19/2012 for linux-next. > It is still needed in linux-next and in mainline. > > > --- linux-next-20120419.orig/fs/nfsd/nfs4recover.c > +++ linux-next-20120419/fs/nfsd/nfs4recover.c > @@ -577,7 +577,7 @@ cld_pipe_downcall(struct file *filp, con > struct cld_net *cn = nn->cld_net; > > if (mlen != sizeof(*cmsg)) { > - dprintk("%s: got %lu bytes, expected %lu\n", __func__, mlen, > + dprintk("%s: got %zu bytes, expected %zu\n", __func__, mlen, > sizeof(*cmsg)); > return -EINVAL; > }