Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx2.netapp.com ([216.240.18.37]:45661 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754920Ab2D3SFO (ORCPT ); Mon, 30 Apr 2012 14:05:14 -0400 Received: from vmwexceht02-prd.hq.netapp.com (vmwexceht02-prd.hq.netapp.com [10.106.76.240]) by smtp2.corp.netapp.com (8.13.1/8.13.1/NTAP-1.6) with ESMTP id q3UI5DII016434 for ; Mon, 30 Apr 2012 11:05:14 -0700 (PDT) From: "Myklebust, Trond" To: "linux-nfs@vger.kernel.org" CC: "Isaman, Fred" Subject: Re: [PATCH 2/3] NFS: O_DIRECT pgio_completion_ops error_cleanup must unlock the request Date: Mon, 30 Apr 2012 18:05:12 +0000 Message-ID: <1335809108.11828.1.camel@lade.trondhjem.org> References: <1335808841-11623-1-git-send-email-Trond.Myklebust@netapp.com> <1335808841-11623-2-git-send-email-Trond.Myklebust@netapp.com> In-Reply-To: <1335808841-11623-2-git-send-email-Trond.Myklebust@netapp.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gTW9uLCAyMDEyLTA0LTMwIGF0IDE0OjAwIC0wNDAwLCBUcm9uZCBNeWtsZWJ1c3Qgd3JvdGU6 DQo+IFNpZ25lZC1vZmYtYnk6IFRyb25kIE15a2xlYnVzdCA8VHJvbmQuTXlrbGVidXN0QG5ldGFw cC5jb20+DQo+IENjOiBGcmVkIElzYW1hbiA8aWlzYW1hbkBuZXRhcHAuY29tPg0KPiAtLS0NCj4g IGZzL25mcy9kaXJlY3QuYyB8ICAgMTggKysrKysrKysrKysrKysrLS0tDQo+ICAxIGZpbGVzIGNo YW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0 IGEvZnMvbmZzL2RpcmVjdC5jIGIvZnMvbmZzL2RpcmVjdC5jDQo+IGluZGV4IDVjZTVjNmIuLjQ1 MGJhNTQgMTAwNjQ0DQo+IC0tLSBhL2ZzL25mcy9kaXJlY3QuYw0KPiArKysgYi9mcy9uZnMvZGly ZWN0LmMNCj4gQEAgLTI5Miw3ICsyOTIsNyBAQCBvdXRfcHV0Og0KPiAgCWhkci0+cmVsZWFzZSho ZHIpOw0KPiAgfQ0KPiAgDQo+IC1zdGF0aWMgdm9pZCBuZnNfc3luY19wZ2lvX2Vycm9yKHN0cnVj dCBsaXN0X2hlYWQgKmhlYWQpDQo+ICtzdGF0aWMgdm9pZCBuZnNfcmVhZF9zeW5jX3BnaW9fZXJy b3Ioc3RydWN0IGxpc3RfaGVhZCAqaGVhZCkNCj4gIHsNCj4gIAlzdHJ1Y3QgbmZzX3BhZ2UgKnJl cTsNCj4gIA0KPiBAQCAtMzA5LDcgKzMwOSw3IEBAIHN0YXRpYyB2b2lkIG5mc19kaXJlY3RfcGdp b19pbml0KHN0cnVjdCBuZnNfcGdpb19oZWFkZXIgKmhkcikNCj4gIH0NCj4gIA0KPiAgc3RhdGlj IGNvbnN0IHN0cnVjdCBuZnNfcGdpb19jb21wbGV0aW9uX29wcyBuZnNfZGlyZWN0X3JlYWRfY29t cGxldGlvbl9vcHMgPSB7DQo+IC0JLmVycm9yX2NsZWFudXAgPSBuZnNfc3luY19wZ2lvX2Vycm9y LA0KPiArCS5lcnJvcl9jbGVhbnVwID0gbmZzX3JlYWRfc3luY19wZ2lvX2Vycm9yLA0KPiAgCS5p bml0X2hkciA9IG5mc19kaXJlY3RfcGdpb19pbml0LA0KPiAgCS5jb21wbGV0aW9uID0gbmZzX2Rp cmVjdF9yZWFkX2NvbXBsZXRpb24sDQo+ICB9Ow0KPiBAQCAtNzcyLDggKzc3MiwyMCBAQCBvdXRf cHV0Og0KPiAgCWhkci0+cmVsZWFzZShoZHIpOw0KPiAgfQ0KPiAgDQo+ICtzdGF0aWMgdm9pZCBu ZnNfd3JpdGVfc3luY19wZ2lvX2Vycm9yKHN0cnVjdCBsaXN0X2hlYWQgKmhlYWQpDQo+ICt7DQo+ ICsJc3RydWN0IG5mc19wYWdlICpyZXE7DQo+ICsNCj4gKwl3aGlsZSAoIWxpc3RfZW1wdHkoaGVh ZCkpIHsNCj4gKwkJcmVxID0gbmZzX2xpc3RfZW50cnkoaGVhZC0+bmV4dCk7DQo+ICsJCW5mc19s aXN0X3JlbW92ZV9yZXF1ZXN0KHJlcSk7DQo+ICsJCW5mc19yZWxlYXNlX3JlcXVlc3QocmVxKTsN Cj4gKwkJbmZzX3VubG9ja19yZXF1ZXN0KHJlcSk7DQo+ICsJfQ0KPiArfQ0KPiArDQo+ICBzdGF0 aWMgY29uc3Qgc3RydWN0IG5mc19wZ2lvX2NvbXBsZXRpb25fb3BzIG5mc19kaXJlY3Rfd3JpdGVf Y29tcGxldGlvbl9vcHMgPSB7DQo+IC0JLmVycm9yX2NsZWFudXAgPSBuZnNfc3luY19wZ2lvX2Vy cm9yLA0KPiArCS5lcnJvcl9jbGVhbnVwID0gbmZzX3dyaXRlX3N5bmNfcGdpb19lcnJvciwNCj4g IAkuaW5pdF9oZHIgPSBuZnNfZGlyZWN0X3BnaW9faW5pdCwNCj4gIAkuY29tcGxldGlvbiA9IG5m c19kaXJlY3Rfd3JpdGVfY29tcGxldGlvbiwNCj4gIH07DQoNCkFsdGVybmF0aXZlbHksIHdlIGNv dWxkIHByb2JhYmx5IGp1c3Qgc2VuZCB0aGUgd3JpdGUgcmVxdWVzdHMgaW4gYW4NCnVubG9ja2Vk IHN0YXRlLiBUaGV5IGFyZW4ndCBzdXBwb3NlZCB0byBiZSB2aXNpYmxlIHRvIGFueXRoaW5nIHZp YSBhbnkNCmdsb2JhbCBsaXN0cy4uLg0KDQotLSANClRyb25kIE15a2xlYnVzdA0KTGludXggTkZT IGNsaWVudCBtYWludGFpbmVyDQoNCk5ldEFwcA0KVHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20N Cnd3dy5uZXRhcHAuY29tDQoNCg==