Date: Thu, 31 May 2012 14:35:44 -0500
From: Malahal Naineni <malahal@us.ibm.com>
To: Sachin Prabhu <sprabhu@redhat.com>
Cc: Linux NFS mailing list <linux-nfs@vger.kernel.org>,
        Trond Myklebust <trond.myklebust@netapp.com>
Subject: Re: [PATCH] NFSv2: EOF incorrectly set on short read
Message-ID: <20120531193544.GA4094@us.ibm.com>
References: <1338482700-15470-1-git-send-email-sprabhu@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <1338482700-15470-1-git-send-email-sprabhu@redhat.com>
Sender: linux-nfs-owner@vger.kernel.org

Sachin Prabhu [sprabhu@redhat.com] wrote:
> In cases where the server returns fewer bytes then those requested, we
> can incorrectly set the eof flag for the file. Fixing this allows the
> request to be retried with updated offset and count arguments.
> 
> Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
> ---
>  fs/nfs/proc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/nfs/proc.c b/fs/nfs/proc.c
> index a706b6b..617c741 100644
> --- a/fs/nfs/proc.c
> +++ b/fs/nfs/proc.c
> @@ -651,7 +651,7 @@ static int nfs_read_done(struct rpc_task *task, struct nfs_read_data *data)
>  		/* Emulate the eof flag, which isn't normally needed in NFSv2
>  		 * as it is guaranteed to always return the file attributes
>  		 */
> -		if (data->args.offset + data->args.count >= data->res.fattr->size)
> +		if (data->args.offset + data->res.count >= data->res.fattr->size)
>  			data->res.eof = 1;
>  	}
>  	return 0;

Good catch!

Regards, Malahal.