Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-wg0-f44.google.com ([74.125.82.44]:60108 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753305Ab2E1S3K (ORCPT ); Mon, 28 May 2012 14:29:10 -0400 Received: by wgbdr13 with SMTP id dr13so3158395wgb.1 for ; Mon, 28 May 2012 11:29:09 -0700 (PDT) Message-ID: <4FC3C3F1.8090507@tonian.com> Date: Mon, 28 May 2012 21:29:05 +0300 From: Benny Halevy MIME-Version: 1.0 To: Boaz Harrosh CC: NFS list Subject: Re: Does our Kernel PNFSD-Server supports recurring layout_get with open_state_id References: <4FBD7DE8.9090002@panasas.com> <4FBE2C8C.9090403@tonian.com> <4FBE3C4D.7050507@panasas.com> <4FC3A235.8090908@tonian.com> <4FC3A974.60107@panasas.com> <4FC3BC2B.6060709@tonian.com> <4FC3BF67.7010402@panasas.com> In-Reply-To: <4FC3BF67.7010402@panasas.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 2012-05-28 21:09, Boaz Harrosh wrote: > On 05/28/2012 08:55 PM, Benny Halevy wrote: > >> On 2012-05-28 19:36, Boaz Harrosh wrote: >>> On 05/28/2012 07:05 PM, Benny Halevy wrote: >>> >>>> Yup, see patchset in reply. >>>> >>> >>> >>> That I wish you wouldn't do. I have a patchset pending that makes >>> major changes to all this and totally conflicts with your code. >> >> Sorry, I didn't know that. >> >>> >>> You can carry this for a while but I might revert your core >>> code in my new patchset. >> >> I hope that at least it will all be for the better. >> >> Benny >> > > > NP. Yes it is all for the better. I think you'll like what I did. > > BTW after I finish implementing my stuff. I think it would be easy > to implement that open_state_id thing. All we need is to save the > open_state_id somewhere per-file or somehow identify it's receive, > And then just call nfs4_roc() which will do the proper work. It's any non layout stateid so it should be pretty easy (in theory :). See nfs4_process_layout_stateid() if (stid->sc_type != NFS4_LAYOUT_STID) {} We should be able to locate the layout stateid, if any, on the fp->fi_layout_states list by matching stid->sc_client. Benny > > But please wait for me to finish. > > (It is all done and debugged, but will be divided and patched > on Wednesday) Sure. Thanks! Benny > > Thanks > Boaz > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html