Return-Path: linux-nfs-owner@vger.kernel.org Received: from natasha.panasas.com ([67.152.220.90]:46431 "EHLO natasha.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753359Ab2E1Kob (ORCPT ); Mon, 28 May 2012 06:44:31 -0400 Message-ID: <4FC356FA.2070008@panasas.com> Date: Mon, 28 May 2012 13:44:10 +0300 From: Boaz Harrosh MIME-Version: 1.0 To: CC: , , Subject: Re: [PATCH 1/3] NFS41: add pnfs_dio_begin/dio_end References: <1338096780-2763-1-git-send-email-bergwolf@gmail.com> <1338096780-2763-2-git-send-email-bergwolf@gmail.com> <1338136170.3044.7.camel@lade.trondhjem.org> <1338176574.2265.7.camel@lade.trondhjem.org> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Sender: linux-nfs-owner@vger.kernel.org List-ID: On 05/28/2012 07:13 AM, tao.peng@emc.com wrote: >> -----Original Message----- >> From: Myklebust, Trond [mailto:Trond.Myklebust@netapp.com] >> Sent: Monday, May 28, 2012 11:43 AM >> To: Peng, Tao >> Cc: bergwolf@gmail.com; linux-nfs@vger.kernel.org >> Subject: RE: [PATCH 1/3] NFS41: add pnfs_dio_begin/dio_end >> >> On Sun, 2012-05-27 at 22:30 -0400, tao.peng@emc.com wrote: >>> I'm afraid there is. There is no way to pass struct blk_plug around pg_init/pg_doio, unless we put >> it in struct nfs_pageio_descriptor, which I think is more intrusive and less efficient as it is only >> useful for block layout driver in DIO case. >> >> Then add a 'void *pg_layout_private' field to nfs_pageio_descriptor and >> allocate the struct blk_plug dynamically. >> > OK. I thought data structure change is more intrusive because it > affects all layout drivers and generic NFS as well. But since you > think it is OK, I will change it as you suggested. > I want a pg_layout_private in nfs_pageio_descriptor as well. I even wrote the ML about it. And everyone agreed. (Just never had time to finish) So yes please do add it. it will have more users. > Thanks, > Tao > Thanks Boaz