Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-wg0-f44.google.com ([74.125.82.44]:55764 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753049Ab2E1R6V (ORCPT ); Mon, 28 May 2012 13:58:21 -0400 Received: by wgbdr13 with SMTP id dr13so3142197wgb.1 for ; Mon, 28 May 2012 10:58:20 -0700 (PDT) Message-ID: <4FC3BCB9.6040604@tonian.com> Date: Mon, 28 May 2012 20:58:17 +0300 From: Benny Halevy MIME-Version: 1.0 To: Boaz Harrosh CC: linux-nfs@vger.kernel.org Subject: Re: [PATCH 4/5] pnfsd-lexp: return_on_close config option References: <4FC3A235.8090908@tonian.com> <1338221387-22621-1-git-send-email-bhalevy@tonian.com> <4FC3AD59.4050703@panasas.com> In-Reply-To: <4FC3AD59.4050703@panasas.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 2012-05-28 19:52, Boaz Harrosh wrote: > On 05/28/2012 07:09 PM, Benny Halevy wrote: > >> Signed-off-by: Benny Halevy >> --- >> fs/nfsd/Kconfig | 7 +++++++ >> fs/nfsd/pnfsd_lexp.c | 5 +++++ >> 2 files changed, 12 insertions(+), 0 deletions(-) >> >> diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig >> index 9d4d79b..f9b3426 100644 >> --- a/fs/nfsd/Kconfig >> +++ b/fs/nfsd/Kconfig >> @@ -132,3 +132,10 @@ config PNFSD_LEXP_LAYOUT_SEGMENT_SIZE >> Set simulated layout segment size. >> >> If unsure, say N. >> + >> +config PNFSD_LEXP_RETURN_ON_CLOSE >> + bool "Reply to LAYOUTGET with return_on_close set to true" >> + depends on PNFSD_LOCAL_EXPORT >> + default false >> + help >> + Set return_on_close response flag. >> diff --git a/fs/nfsd/pnfsd_lexp.c b/fs/nfsd/pnfsd_lexp.c >> index 30d9757..33a724c 100644 >> --- a/fs/nfsd/pnfsd_lexp.c >> +++ b/fs/nfsd/pnfsd_lexp.c >> @@ -153,6 +153,11 @@ static int get_stripe_unit(int blocksize) >> res->lg_seg.offset = 0; >> res->lg_seg.length = NFS4_MAX_UINT64; >> #endif /* CONFIG_PNFSD_LEXP_LAYOUT_SEGMENTS */ >> +#ifdef CONFIG_PNFSD_LEXP_RETURN_ON_CLOSE >> + res->lg_return_on_close = true; >> +#else /* CONFIG_PNFSD_LEXP_RETURN_ON_CLOSE */ >> + res->lg_return_on_close = false; > > > Back to my original question. With current code this case is a BUG. > It will leak layouts and therefore file-reference in case of a layout-get > with open-state ID. > > So I suggest hardcoding to true until such time that we actually can > support it so how will you debug the leak case? pnfsd-lexp is for testing, and the default is on. Benny > > Boaz > >> +#endif /* CONFIG_PNFSD_LEXP_RETURN_ON_CLOSE */ >> >> layout = kzalloc(sizeof(*layout), GFP_KERNEL); >> if (layout == NULL) { > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html