Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx2.netapp.com ([216.240.18.37]:55705 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751065Ab2EGRqz (ORCPT ); Mon, 7 May 2012 13:46:55 -0400 Received: from vmwexceht05-prd.hq.netapp.com (vmwexceht05-prd.hq.netapp.com [10.106.77.35]) by smtp1.corp.netapp.com (8.13.1/8.13.1/NTAP-1.6) with ESMTP id q47HkgI6009917 for ; Mon, 7 May 2012 10:46:43 -0700 (PDT) From: "Myklebust, Trond" To: "Schumaker, Bryan" CC: "linux-nfs@vger.kernel.org" Subject: Re: [PATCH 3/7] NFS: Consistent arguments to nfs_fscache_get_super_cookie() Date: Mon, 7 May 2012 17:46:41 +0000 Message-ID: <1336412807.9499.4.camel@lade.trondhjem.org> References: <1335811229-2989-1-git-send-email-bjschuma@netapp.com> <1335811229-2989-4-git-send-email-bjschuma@netapp.com> In-Reply-To: <1335811229-2989-4-git-send-email-bjschuma@netapp.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gTW9uLCAyMDEyLTA0LTMwIGF0IDE0OjQwIC0wNDAwLCBianNjaHVtYUBuZXRhcHAuY29tIHdy b3RlOg0KPiBGcm9tOiBCcnlhbiBTY2h1bWFrZXIgPGJqc2NodW1hQG5ldGFwcC5jb20+DQo+IA0K PiBJIGludGVuZCBvbiBjcmVhdGluZyBhIHNpbmdsZSBuZnNfZnNfbW91bnQoKSBmdW5jdGlvbiB1 c2VkIGJ5IGFsbCBvdXINCj4gbW91bnQgcGF0aHMuICBUbyBhdm9pZCBjaGVja2luZyBiZXR3ZWVu IG5ldyBtb3VudHMgYW5kIGNsb25lIG1vdW50cywgSQ0KPiBpbnN0ZWFkIHBhc3MgYm90aCBzdHJ1 Y3R1cmVzIHRvIHRoZSBnZXRfc3VwZXJfY29va2llKCkgZnVuY3Rpb24gYW5kIGxldA0KPiB0aGlz IGZ1bmN0aW9uIGRlY2lkZSB0aGUgYmVzdCB3YXkgdG8gaGFuZGxlIHRoZSBzaXR1YXRpb24uDQo+ IA0KPiBTaWduZWQtb2ZmLWJ5OiBCcnlhbiBTY2h1bWFrZXIgPGJqc2NodW1hQG5ldGFwcC5jb20+ DQo+IC0tLQ0KPiAgZnMvbmZzL2ZzY2FjaGUuYyB8ICAgMTMgKysrKysrKystLS0tLQ0KPiAgZnMv bmZzL2ZzY2FjaGUuaCB8ICAgIDIgKy0NCj4gIGZzL25mcy9zdXBlci5jICAgfCAgICA0ICsrLS0N Cj4gIDMgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkNCj4g DQo+IGRpZmYgLS1naXQgYS9mcy9uZnMvZnNjYWNoZS5jIGIvZnMvbmZzL2ZzY2FjaGUuYw0KPiBp bmRleCBhZTY1YzE2Li4zNTQxMWY4IDEwMDY0NA0KPiAtLS0gYS9mcy9uZnMvZnNjYWNoZS5jDQo+ ICsrKyBiL2ZzL25mcy9mc2NhY2hlLmMNCj4gQEAgLTY0LDE4ICs2NCwyMSBAQCB2b2lkIG5mc19m c2NhY2hlX3JlbGVhc2VfY2xpZW50X2Nvb2tpZShzdHJ1Y3QgbmZzX2NsaWVudCAqY2xwKQ0KPiAg ICogZWl0aGVyIGJ5IHRoZSAnZnNjPXh4eCcgb3B0aW9uIHRvIG1vdW50LCBvciBieSBpbmhlcml0 aW5nIGl0IGZyb20gdGhlIHBhcmVudA0KPiAgICogc3VwZXJibG9jayBhY3Jvc3MgYW4gYXV0b21v dW50IHBvaW50IG9mIHNvbWUgbmF0dXJlLg0KPiAgICovDQo+IC12b2lkIG5mc19mc2NhY2hlX2dl dF9zdXBlcl9jb29raWUoc3RydWN0IHN1cGVyX2Jsb2NrICpzYiwgY29uc3QgY2hhciAqdW5pcSwN Cj4gLQkJCQkgIHN0cnVjdCBuZnNfY2xvbmVfbW91bnQgKm1udGRhdGEpDQo+ICt2b2lkIG5mc19m c2NhY2hlX2dldF9zdXBlcl9jb29raWUoc3RydWN0IHN1cGVyX2Jsb2NrICpzYiwNCj4gKwkJCQkg IHN0cnVjdCBuZnNfcGFyc2VkX21vdW50X2RhdGEgKnBhcnNlZCwNCj4gKwkJCQkgIHN0cnVjdCBu ZnNfY2xvbmVfbW91bnQgKmNsb25lZCkNCj4gIHsNCj4gIAlzdHJ1Y3QgbmZzX2ZzY2FjaGVfa2V5 ICprZXksICp4a2V5Ow0KPiAgCXN0cnVjdCBuZnNfc2VydmVyICpuZnNzID0gTkZTX1NCKHNiKTsN Cj4gIAlzdHJ1Y3QgcmJfbm9kZSAqKnAsICpwYXJlbnQ7DQo+ICsJY2hhciAqdW5pcSA9IE5VTEw7 DQo+ICAJaW50IGRpZmYsIHVsZW47DQo+ICANCj4gLQlpZiAodW5pcSkgew0KPiArCWlmIChwYXJz ZWQgJiYgcGFyc2VkLT5mc2NhY2hlX3VuaXEpIHsNCj4gKwkJdW5pcSA9IHBhcnNlZC0+ZnNjYWNo ZV91bmlxOw0KPiAgCQl1bGVuID0gc3RybGVuKHVuaXEpOw0KPiAtCX0gZWxzZSBpZiAobW50ZGF0 YSkgew0KPiAtCQlzdHJ1Y3QgbmZzX3NlcnZlciAqbW50X3MgPSBORlNfU0IobW50ZGF0YS0+c2Ip Ow0KPiArCX0gZWxzZSBpZiAoY2xvbmVkKSB7DQo+ICsJCXN0cnVjdCBuZnNfc2VydmVyICptbnRf cyA9IE5GU19TQihjbG9uZWQtPnNiKTsNCg0KSW5zdGVhZCBvZiBwYXNzaW5nIGluIHRoZSB3aG9s ZSBuZnNfY2xvbmVfbW91bnQgc3RydWN0dXJlIGhlcmUsIGp1c3QgaW4NCm9yZGVyIHRvIGV4dHJh Y3QgdGhlIHVuaXF1aWZpZXIsIHdoeSBub3QgcGFzcyBpbiB0aGUgc3RydWN0DQpuZnNfZnNjYWNo ZV9rZXkgZnJvbSBjbG9uZWQtPnNiPw0KDQoNCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4 IE5GUyBjbGllbnQgbWFpbnRhaW5lcg0KDQpOZXRBcHANClRyb25kLk15a2xlYnVzdEBuZXRhcHAu Y29tDQp3d3cubmV0YXBwLmNvbQ0KDQo=