Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-yw0-f42.google.com ([209.85.213.42]:40749 "EHLO mail-yw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932617Ab2F2S6M (ORCPT ); Fri, 29 Jun 2012 14:58:12 -0400 Received: by mail-yw0-f42.google.com with SMTP id q11so4407178yhf.1 for ; Fri, 29 Jun 2012 11:58:12 -0700 (PDT) From: Jeff Layton To: viro@ZenIV.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, michael.brantley@deshaw.com, hch@infradead.org, miklos@szeredi.hu, pstaubach@exagrid.com Subject: [PATCH v3 03/17] vfs: make fstatat retry on ESTALE errors from getattr call Date: Fri, 29 Jun 2012 14:57:46 -0400 Message-Id: <1340996280-27123-4-git-send-email-jlayton@redhat.com> In-Reply-To: <1340996280-27123-1-git-send-email-jlayton@redhat.com> References: <1340996280-27123-1-git-send-email-jlayton@redhat.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: Signed-off-by: Jeff Layton --- fs/namei.c | 2 +- fs/stat.c | 21 ++++++++++++++++----- include/linux/fs.h | 3 ++- 3 files changed, 19 insertions(+), 7 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 3f46b2f..44c7ccd 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -117,7 +117,7 @@ * POSIX.1 2.4: an empty pathname is invalid (ENOENT). * PATH_MAX includes the nul terminator --RR. */ -static char *getname_flags(const char __user *filename, int flags, int *empty) +char *getname_flags(const char __user *filename, int flags, int *empty) { char *result = __getname(), *err; int len; diff --git a/fs/stat.c b/fs/stat.c index b6ff118..5afeb37 100644 --- a/fs/stat.c +++ b/fs/stat.c @@ -72,9 +72,11 @@ EXPORT_SYMBOL(vfs_fstat); int vfs_fstatat(int dfd, const char __user *filename, struct kstat *stat, int flag) { + char *name; struct path path; int error = -EINVAL; - int lookup_flags = 0; + unsigned int try = 0; + unsigned int lookup_flags = 0; if ((flag & ~(AT_SYMLINK_NOFOLLOW | AT_NO_AUTOMOUNT | AT_EMPTY_PATH)) != 0) @@ -85,12 +87,21 @@ int vfs_fstatat(int dfd, const char __user *filename, struct kstat *stat, if (flag & AT_EMPTY_PATH) lookup_flags |= LOOKUP_EMPTY; - error = user_path_at(dfd, filename, lookup_flags, &path); - if (error) + name = getname_flags(filename, lookup_flags, NULL); + if (IS_ERR(name)) { + error = PTR_ERR(name); goto out; + } + do { + error = kern_path_at(dfd, name, lookup_flags, &path); + if (error) + break; - error = vfs_getattr(path.mnt, path.dentry, stat); - path_put(&path); + error = vfs_getattr(path.mnt, path.dentry, stat); + path_put(&path); + lookup_flags |= LOOKUP_REVAL; + } while (retry_estale(error, try++)); + putname(name); out: return error; } diff --git a/include/linux/fs.h b/include/linux/fs.h index 4a2aa04..c7d60db 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2060,7 +2060,8 @@ extern struct file *file_open_root(struct dentry *, struct vfsmount *, extern struct file * dentry_open(struct dentry *, struct vfsmount *, int, const struct cred *); extern int filp_close(struct file *, fl_owner_t id); -extern char * getname(const char __user *); +extern char *getname_flags(const char __user *, int, int *); +extern char *getname(const char __user *); /** * retry_estale - determine whether the caller should retry an operation -- 1.7.7.6