From: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
To: Chuck Lever <chuck.lever@oracle.com>
CC: "Schumaker, Bryan" <Bryan.Schumaker@netapp.com>,
        "J. Bruce Fields" <bfields@redhat.com>,
        Olga Kornievskaia <aglo@citi.umich.edu>,
        "Linux NFS Mailing List" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFS: Check if rpcauth_create() returns an error code
Date: Tue, 26 Jun 2012 22:02:53 +0000
Message-ID: <1340748167.2576.39.camel@lade.trondhjem.org>
References: <1340734373-5596-1-git-send-email-bjschuma@netapp.com>
	 <9ED25AEF-945E-4908-8D78-4CC040D9A26A@oracle.com>
	 <4FEA06E3.9060109@netapp.com>
	 <0B660C97-1E4E-4032-8791-66A26275E7F1@oracle.com>
In-Reply-To: <0B660C97-1E4E-4032-8791-66A26275E7F1@oracle.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-nfs-owner@vger.kernel.org

T24gVHVlLCAyMDEyLTA2LTI2IGF0IDE3OjM0IC0wNDAwLCBDaHVjayBMZXZlciB3cm90ZToNCj4g
T24gSnVuIDI2LCAyMDEyLCBhdCAzOjAwIFBNLCBCcnlhbiBTY2h1bWFrZXIgd3JvdGU6DQo+IA0K
PiA+IE9uIDA2LzI2LzIwMTIgMDI6MjMgUE0sIENodWNrIExldmVyIHdyb3RlOg0KPiA+PiANCj4g
Pj4gT24gSnVuIDI2LCAyMDEyLCBhdCAyOjEyIFBNLCBianNjaHVtYUBuZXRhcHAuY29tIHdyb3Rl
Og0KPiA+PiANCj4gPj4+IEZyb206IEJyeWFuIFNjaHVtYWtlciA8YmpzY2h1bWFAbmV0YXBwLmNv
bT4NCj4gPj4+IA0KPiA+Pj4gSSB3YXMgdHJlYXRpbmcgYSBOVUxMIHJldHVybiB2YWx1ZSBhcyBh
biBlcnJvciwgYnV0IHRoaXMgZnVuY3Rpb24gd2lsbA0KPiA+Pj4gaW5zdGVhZCByZXR1cm4gYW4g
RVJSX1BUUigpLiAgTm93IHRoYXQgSSdtIGNoZWNraW5nIGlmIHRoZSBmdW5jdGlvbg0KPiA+Pj4g
cmV0dXJucyBhbiBlcnJvciwgSSBzaG91bGQgYWxzbyBwYXNzIHRoZSBlcnJvciB1cCB0aGUgY2Fs
bCBzdGFjay4NCj4gPj4gDQo+ID4+IA0KPiA+Pj4gU2lnbmVkLW9mZi1ieTogQnJ5YW4gU2NodW1h
a2VyIDxianNjaHVtYUBuZXRhcHAuY29tPg0KPiA+Pj4gLS0tDQo+ID4+PiBmcy9uZnMvbmZzNG5h
bWVzcGFjZS5jIHwgIDQgKystLQ0KPiA+Pj4gZnMvbmZzL25mczRwcm9jLmMgICAgICB8IDE1ICsr
KystLS0tLS0tLS0tLQ0KPiA+Pj4gMiBmaWxlcyBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDEz
IGRlbGV0aW9ucygtKQ0KPiA+Pj4gDQo+ID4+PiBkaWZmIC0tZ2l0IGEvZnMvbmZzL25mczRuYW1l
c3BhY2UuYyBiL2ZzL25mcy9uZnM0bmFtZXNwYWNlLmMNCj4gPj4+IGluZGV4IDAxN2I0YjAuLmE4
YWFmYzYgMTAwNjQ0DQo+ID4+PiAtLS0gYS9mcy9uZnMvbmZzNG5hbWVzcGFjZS5jDQo+ID4+PiAr
KysgYi9mcy9uZnMvbmZzNG5hbWVzcGFjZS5jDQo+ID4+PiBAQCAtMjA1LDkgKzIwNSw5IEBAIHN0
cnVjdCBycGNfY2xudCAqbmZzNF9jcmVhdGVfc2VjX2NsaWVudChzdHJ1Y3QgcnBjX2NsbnQgKmNs
bnQsIHN0cnVjdCBpbm9kZSAqaW5vDQo+ID4+PiAJCXJldHVybiBjbG9uZTsNCj4gPj4+IA0KPiA+
Pj4gCWF1dGggPSBycGNhdXRoX2NyZWF0ZShmbGF2b3IsIGNsb25lKTsNCj4gPj4+IC0JaWYgKCFh
dXRoKSB7DQo+ID4+PiArCWlmIChJU19FUlIoYXV0aCkpIHsNCj4gPj4+IAkJcnBjX3NodXRkb3du
X2NsaWVudChjbG9uZSk7DQo+ID4+PiAtCQljbG9uZSA9IEVSUl9QVFIoLUVJTyk7DQo+ID4+PiAr
CQljbG9uZSA9IEVSUl9DQVNUKGF1dGgpOw0KPiA+Pj4gCX0NCj4gPj4gDQo+ID4+IFRoaXMgZWNo
b2VzIG5mc19pbml0X3NlcnZlcl9ycGNjbGllbnQoKSwgc28gaXQgc2hvdWxkIGJlIGFkZXF1YXRl
Lg0KPiA+PiANCj4gPj4+IA0KPiA+Pj4gCXJldHVybiBjbG9uZTsNCj4gPj4+IGRpZmYgLS1naXQg
YS9mcy9uZnMvbmZzNHByb2MuYyBiL2ZzL25mcy9uZnM0cHJvYy5jDQo+ID4+PiBpbmRleCA1YTdi
MzcyLi5mODE3NTg3IDEwMDY0NA0KPiA+Pj4gLS0tIGEvZnMvbmZzL25mczRwcm9jLmMNCj4gPj4+
ICsrKyBiL2ZzL25mcy9uZnM0cHJvYy5jDQo+ID4+PiBAQCAtMjM1NiwxNyArMjM1NiwxMCBAQCBv
dXQ6DQo+ID4+PiBzdGF0aWMgaW50IG5mczRfbG9va3VwX3Jvb3Rfc2VjKHN0cnVjdCBuZnNfc2Vy
dmVyICpzZXJ2ZXIsIHN0cnVjdCBuZnNfZmggKmZoYW5kbGUsDQo+ID4+PiAJCQkJc3RydWN0IG5m
c19mc2luZm8gKmluZm8sIHJwY19hdXRoZmxhdm9yX3QgZmxhdm9yKQ0KPiA+Pj4gew0KPiA+Pj4g
LQlzdHJ1Y3QgcnBjX2F1dGggKmF1dGg7DQo+ID4+PiAtCWludCByZXQ7DQo+ID4+PiAtDQo+ID4+
PiAtCWF1dGggPSBycGNhdXRoX2NyZWF0ZShmbGF2b3IsIHNlcnZlci0+Y2xpZW50KTsNCj4gPj4+
IC0JaWYgKCFhdXRoKSB7DQo+ID4+PiAtCQlyZXQgPSAtRUlPOw0KPiA+Pj4gLQkJZ290byBvdXQ7
DQo+ID4+PiAtCX0NCj4gPj4+IC0JcmV0ID0gbmZzNF9sb29rdXBfcm9vdChzZXJ2ZXIsIGZoYW5k
bGUsIGluZm8pOw0KPiA+Pj4gLW91dDoNCj4gPj4+IC0JcmV0dXJuIHJldDsNCj4gPj4+ICsJc3Ry
dWN0IHJwY19hdXRoICphdXRoID0gcnBjYXV0aF9jcmVhdGUoZmxhdm9yLCBzZXJ2ZXItPmNsaWVu
dCk7DQo+ID4+PiArCWlmIChJU19FUlIoYXV0aCkpDQo+ID4+PiArCQlyZXR1cm4gUFRSX0VSUihh
dXRoKTsNCj4gPj4+ICsJcmV0dXJuIG5mczRfbG9va3VwX3Jvb3Qoc2VydmVyLCBmaGFuZGxlLCBp
bmZvKTsNCj4gPj4+IH0NCj4gPj4+IA0KPiA+Pj4gc3RhdGljIGludCBuZnM0X2ZpbmRfcm9vdF9z
ZWMoc3RydWN0IG5mc19zZXJ2ZXIgKnNlcnZlciwgc3RydWN0IG5mc19maCAqZmhhbmRsZSwNCj4g
Pj4gDQo+ID4+IFRoaXMgbG9naWMgY2FsbHMgcnBjYXV0aF9jcmVhdGUoKSBpbiBhIGxvb3AsIGNv
cnJlY3Q/ICBUaGUgZXhwZWN0YXRpb24gaXMgdGhhdCBycGNhdXRoX2NyZWF0ZSgpIHNob3VsZCBz
aW1wbHkgcmVwbGFjZSB0aGUgbmZzX2NsaWVudCdzIHJwY19hdXRoIHdpdGggdGhlIG5leHQgZmxh
dm9yIGVhY2ggdGltZSBpdCBpcyBjYWxsZWQ/DQo+ID4+IA0KPiA+IA0KPiA+IFllYWgsIHRoYXQn
cyB3aGF0IEknbSBleHBlY3RpbmcgdG8gaGFwcGVuLg0KPiA+IA0KPiA+PiBXaXRoIHRoZSBjdXJy
ZW50IGNvZGUgaW4gbmZzNF9maW5kX3Jvb3Rfc2VjKCksIHJwY2F1dGhfY3JlYXRlKCkgd2l0aCBh
IEdTUyBmbGF2b3IgZmFpbHMgdGhlIHNlY29uZCB0aW1lIHlvdSBjYWxsIGl0IGJlY2F1c2UgKEkg
c3VzcGVjdCkgdGhlcmUncyBhIHBpcGUgZGVudHJ5IGxlZnQgb3ZlciBmcm9tIHRoZSBwcmV2aW91
cyBjYWxsLiAgU28gdGhlcmUncyBubyB3YXkgdG8gd2FsayBhbiBlbnRpcmUgbGlzdCByZXR1cm5l
ZCBmcm9tIGdzc19tZWNoX2xpc3RfZmxhdm9ycygpLCBpdCB3aWxsIGZhaWwgb24gdGhlIHNlY29u
ZCBHU1MgZmxhdm9yIGV2ZXJ5IHRpbWUuDQo+ID4gDQo+ID4gcnBjYXV0aF9jcmVhdGUoKSBoYXMg
dGhpcyBiaXQgb2YgY29kZSBpbiBpdDoNCj4gPiANCj4gPiAJaWYgKGNsbnQtPmNsX2F1dGgpDQo+
ID4gCQlycGNhdXRoX3JlbGVhc2UoY2xudC0+Y2xfYXV0aCk7DQo+ID4gCWNsbnQtPmNsX2F1dGgg
PSBhdXRoOw0KPiA+IA0KPiA+IA0KPiA+IEkgZ3Vlc3MgSSBmaWd1cmVkIHJwY2F1dGhfcmVsZWFz
ZSgpIHdhcyBhbHJlYWR5IGRvaW5nIHRoZSBuZWNlc3NhcnkgY2xlYW51cC4NCj4gDQo+IFRoZSBw
cm9ibGVtIGlzIHRoYXQgYWxsIEdTUyBwc2V1ZG9mbGF2b3JzIHVzZSB0aGUgc2FtZSAiZ3NzZCIg
dXBjYWxsIHBpcGUsIGJ1dCB0aGUgUlBDIGNsaWVudCBkb2VzIG5vdCBhcHBlYXIgdG8gYmUgcHJl
cGFyZWQgdG8gc2hhcmUgdGhhdCBwaXBlIGFtb25nc3QgcHNldWRvZmxhdm9ycyB0aGF0IGV4aXN0
IGNvbmN1cnJlbnRseS4NCj4gDQo+IFNvIGlmIHJwY2F1dGhfY3JlYXRlKCkgaXMgY2FsbGVkIHRv
IHN1YnN0aXR1dGUgb25lIEdTUyBwc2V1ZG9mbGF2b3IgZm9yIGFub3RoZXIsIGl0IHdpbGwgYWx3
YXlzIGZhaWwgYmVjYXVzZSB0aGUgImdzc2QiIHBpcGUgYWxyZWFkeSBleGlzdHMuDQo+IA0KPiBJ
dCBhcHBlYXJzIHRoaXMgYnVnIGhhcyBiZWVuIGFyb3VuZCBzaW5jZSBsYXRlIDIwMDggd2hlbiB0
aGUgbmV3IEdTUyB1cGNhbGwgbWVjaGFuaXNtIHdhcyBhZGRlZC4gIFdlJ3ZlIG5ldmVyIGhpdCBp
dCBiZWNhdXNlIHdlJ3ZlIG5ldmVyIHRyaWVkIHRvIHVzZSBycGNhdXRoX2NyZWF0ZSgpIHRvIHJl
cGxhY2UgYW4gcnBjX2F1dGggYmVmb3JlLiAgQW55IGNhbGxlciB3aG8gaXMgc2V0dGluZyB1cCBh
IGZyZXNoIHJwY19jbG50IGNhbiBoYW5kbGUgYSBmYWlsdXJlIGZyb20gcnBjYXV0aF9jcmVhdGUo
KSByZWFzb25hYmx5IHdlbGwuDQo+IA0KPiBCdXQgYSBjYWxsZXIgd2hvIGlzIGF0dGVtcHRpbmcg
dG8gcmV0cnkgYW4gcnBjYXV0aF9jcmVhdGUoKSB3aXRoIGEgbGlzdCBvZiBkaWZmZXJlbnQgZmxh
dm9ycyBpcyBTT0w7IGF0IGxlYXN0IHRoZSBjdXJyZW50IGNvZGUgbGVhdmVzIHRoZSBycGNfY2xu
dCB3aXRoIHRoZSBvcmlnaW5hbCwgd29ya2luZyBycGNfYXV0aCwgYnV0IGl0IHdvbid0IGFsbG93
IGEgY2FsbGVyIHRvIHJlcGxhY2UgYSBHU1MgZmxhdm9yIHdpdGggYW5vdGhlci4NCj4gDQo+IEhv
dyBoYXJkIHdvdWxkIGl0IGJlIHRvIGVuYWJsZSB0aGUgZ3NzZCB1cGNhbGwgcGlwZSB0byBiZSBz
aGFyZWQ/DQoNCk5vLiBUaGlzIGlzIGEgbmV3IHByb2JsZW0sIGFuZCBpcyBwcm9iYWJseSBhIGNv
bnNlcXVlbmNlIG9mIHRoZSBuZXQNCm5hbWVzcGFjZSBjb2RlLiBQcmlvciB0byB0aGF0LCB0aGUg
cnBjYXV0aCBjb2RlIHdvdWxkIGp1c3QgdGFrZSBhDQpyZWZlcmVuY2UgdG8gdGhlIGV4aXN0aW5n
IHVwY2FsbCBwaXBlIGlmIGl0IGhhZCBhbHJlYWR5IGJlZW4gY3JlYXRlZC4NCg0KVGhlIHNvbHV0
aW9uIGhlcmUgd291bGQgYmUgdG8gY3JlYXRlIGEgcGVyLXJwY19jbGllbnQsIHBlci1waXBlbmFt
ZQ0Kc2hhcmVkICdycGNzZWNfZ3NzX3BpcGUnIG9iamVjdCB0aGF0IGhvbGRzIHRoZSB1cGNhbGwg
cGlwZSBkYXRhLg0KDQotLSANClRyb25kIE15a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBtYWlu
dGFpbmVyDQoNCk5ldEFwcA0KVHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20NCnd3dy5uZXRhcHAu
Y29tDQoNCg==