Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx2.netapp.com ([216.240.18.37]:40064 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755178Ab2HQBPC (ORCPT ); Thu, 16 Aug 2012 21:15:02 -0400 From: "Myklebust, Trond" To: Shai Lazmi CC: William Dauchy , "Schumaker, Bryan" , "linux-nfs@vger.kernel.org" Subject: Re: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails Date: Fri, 17 Aug 2012 01:14:45 +0000 Message-ID: <4FA345DA4F4AE44899BD2B03EEEC2FA93B5D38@SACEXCMBX04-PRD.hq.netapp.com> References: <1345148622-10845-1-git-send-email-Trond.Myklebust@netapp.com> <21641D3714F5AF449DC483E699E1124E86E640957F@AVEXMB2.qlogic.org> <4FA345DA4F4AE44899BD2B03EEEC2FA93B542B@SACEXCMBX04-PRD.hq.netapp.com> <21641D3714F5AF449DC483E699E1124E86E6409585@AVEXMB2.qlogic.org> <4FA345DA4F4AE44899BD2B03EEEC2FA93B54EC@SACEXCMBX04-PRD.hq.netapp.com> <21641D3714F5AF449DC483E699E1124E86E640958D@AVEXMB2.qlogic.org> <4FA345DA4F4AE44899BD2B03EEEC2FA93B5646@SACEXCMBX04-PRD.hq.netapp.com> <21641D3714F5AF449DC483E699E1124E86E6409593@AVEXMB2.qlogic.org> <4FA345DA4F4AE44899BD2B03EEEC2FA93B56F2@SACEXCMBX04-PRD.hq.netapp.com> <21641D3714F5AF449DC483E699E1124E86E64095A8@AVEXMB2.qlogic.org> In-Reply-To: <21641D3714F5AF449DC483E699E1124E86E64095A8@AVEXMB2.qlogic.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gVGh1LCAyMDEyLTA4LTE2IGF0IDE4OjA5IC0wNzAwLCBTaGFpIExhem1pIHdyb3RlOg0KPiBJ J3ZlIGxvb2tlZCBhdCB0aGUgcmVwbyAoaHR0cDovL2dpdC5rZXJuZWwub3JnLz9wPWxpbnV4L2tl cm5lbC9naXQvdG9ydmFsZHMvbGludXguZ2l0O2E9YmxvYjtmPWZzL25mcy9pZG1hcC5jO2g9Yjcw MTM1OGMzOWMzNTFkMDYxM2QxZGIyOWViY2YzODJjYThjYjBhNjtoYj1kZGYzNDNmNjM1ZmU0NDQw Y2FkNTI4ZTEyZjk2ZjI4YmQ1MGFhMDk5KSwgc2VlbXMganVzdCBsaWtlIHdoYXQgSSBoYXZlDQo+ IENhbiBpdCBiZSBhbHJlYWR5IGNoYW5nZWQgb24gdGhlIHRyZWU/DQoNCk5vLiBJdCBoYXNuJ3Qg YmVlbiBtZXJnZWQgdXBzdHJlYW0geWV0Lg0KDQpIb3dldmVyLCBJJ3ZlIG5vdyBwdXNoZWQgdGhl IHBhdGNoZXMgdXBzdHJlYW0gdG8gdGhlIE5GUyBidWdmaXhlcw0KYnJhbmNoLiBJbnN0ZWFkIG9m IGFwcGx5aW5nIHRoZSBwYXRjaGVzLCBwZXJoYXBzIHlvdSBjb3VsZCBqdXN0IHB1bGwgdGhlDQpm dWxsIHNldCBvZiBORlMgY2xpZW50IGJ1Z2ZpeGVzIGJ5IGRvaW5nDQoNCmdpdCBwdWxsIGdpdDov L2dpdC5saW51eC1uZnMub3JnL3Byb2plY3RzL3Ryb25kbXkvbGludXgtbmZzLmdpdCBidWdmaXhl cw0KDQpDaGVlcnMNCiAgVHJvbmQNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBG cm9tOiBNeWtsZWJ1c3QsIFRyb25kIFttYWlsdG86VHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb21d DQo+IFNlbnQ6IFRodXJzZGF5LCBBdWd1c3QgMTYsIDIwMTIgNToyMiBQTQ0KPiBUbzogU2hhaSBM YXptaQ0KPiBDYzogV2lsbGlhbSBEYXVjaHk7IFNjaHVtYWtlciwgQnJ5YW47IGxpbnV4LW5mc0B2 Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCAxLzJdIE5GUzogQ2xlYXIga2V5 IGNvbnN0cnVjdGlvbiBkYXRhIGlmIHRoZSBpZG1hcCB1cGNhbGwgZmFpbHMNCj4gDQo+IE9uIFRo dSwgMjAxMi0wOC0xNiBhdCAxNzoxNSAtMDcwMCwgU2hhaSBMYXptaSB3cm90ZToNCj4gPiBnaXQg YXBwbHkgLS1jaGVjayAwMDAxLU5GUy1DbGVhci1rZXktY29uc3RydWN0aW9uLWRhdGEtaWYtdGhl LWlkbWFwLXVwY2FsbC0ucGF0Y2gNCj4gPiBlcnJvcjogcGF0Y2ggZmFpbGVkOiBmcy9uZnMvaWRt YXAuYzo2MQ0KPiA+IGVycm9yOiBmcy9uZnMvaWRtYXAuYzogcGF0Y2ggZG9lcyBub3QgYXBwbHkN Cj4gPg0KPiA+DQo+ID4gaWRtYXAuYw0KPiA+IGRlZmluZSBORlNfVUlOVF9NQVhMRU4gMTENCj4g Pg0KPiA+IHN0YXRpYyBjb25zdCBzdHJ1Y3QgY3JlZCAqaWRfcmVzb2x2ZXJfY2FjaGU7DQo+ID4g c3RhdGljIHN0cnVjdCBrZXlfdHlwZSBrZXlfdHlwZV9pZF9yZXNvbHZlcl9sZWdhY3k7DQo+ID4N Cj4gPiBzdHJ1Y3QgaWRtYXAgew0KPiA+ICAgICAgICAgc3RydWN0IHJwY19waXBlICAgICAgICAg KmlkbWFwX3BpcGU7DQo+ID4gICAgICAgICBzdHJ1Y3Qga2V5X2NvbnN0cnVjdGlvbiAqaWRtYXBf a2V5X2NvbnM7DQo+ID4gICAgICAgICBzdHJ1Y3QgbXV0ZXggICAgICAgICAgICBpZG1hcF9tdXRl eDsNCj4gPiB9Ow0KPiANCj4gVGhhdCdzIGhvdyBpdCBzaG91bGQgbW9yZSBvciBsZXNzIGxvb2sg YWZ0ZXIgYXBwbHlpbmcgdGhlIHBhdGNoLiBJJ20NCj4gZ3Vlc3NpbmcgdGhhdCBvbmUgb2YgeW91 ciBwcmV2aW91cyBhdHRlbXB0cyBoYXMgcGFydGlhbGx5IHdvcmtlZCwgYW5kDQo+IGhhcyBsZWZ0 IHlvdXIgY2hlY2tlZCBvdXQgZ2l0IHRyZWUgaW4gYSAiZGlydHkiIHN0YXRlLg0KPiANCj4gUGxl YXNlIHRyeSB0aGUgZm9sbG93aW5nOg0KPiANCj4gJCBnaXQgcmVzZXQgLS1oYXJkIEhFQUQNCj4g JCBnaXQgYXBwbHkgLS1jaGVjayAwMDAxLU5GUy1DbGVhci1rZXktY29uc3RydWN0aW9uLWRhdGEt aWYtdGhlLWlkbWFwLXVwY2FsbC0ucGF0Y2gNCj4gJCBnaXQgYXBwbHkgLS1jaGVjayAwMDAyLU5G Uy1yZXR1cm4tRU5PS0VZLXdoZW4tdGhlLXVwY2FsbC1mYWlscy10by1tYXAtdGhlLW4ucGF0Y2gN Cj4gDQo+IA0KPiA+DQo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiBGcm9tOiBN eWtsZWJ1c3QsIFRyb25kIFttYWlsdG86VHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb21dDQo+ID4g U2VudDogVGh1cnNkYXksIEF1Z3VzdCAxNiwgMjAxMiA1OjE0IFBNDQo+ID4gVG86IFNoYWkgTGF6 bWkNCj4gPiBDYzogV2lsbGlhbSBEYXVjaHk7IFNjaHVtYWtlciwgQnJ5YW47IGxpbnV4LW5mc0B2 Z2VyLmtlcm5lbC5vcmcNCj4gPiBTdWJqZWN0OiBSZTogW1BBVENIIDEvMl0gTkZTOiBDbGVhciBr ZXkgY29uc3RydWN0aW9uIGRhdGEgaWYgdGhlIGlkbWFwIHVwY2FsbCBmYWlscw0KPiA+DQo+ID4g T24gVGh1LCAyMDEyLTA4LTE2IGF0IDE3OjA3IC0wNzAwLCBTaGFpIExhem1pIHdyb3RlOg0KPiA+ ID4gU29ycnkgLSBjb21wYW55J3MgcG9saWN5IC4uLg0KPiA+ID4gV2hhdCBpZG1hcCB2ZXJzaW9u IHdhcyB0aGlzIHBhdGNoIHVzZWQgYWdhaW5zdD8gVGhlIG9uZSBJIGhhdmUgKGI3MDEzNThjKSBz ZWVtcyB0byBiZSBhIGJpdCBkaWZmZXJlbnQgKEkgdXNlZCBsYXRlc3QgcHVsbCBjb21taXQgZGRm MzQzZjYzNWZlNDQ0MGNhZDUyOGUxMmY5NmYyOGJkNTBhYTA5OSksIGhlbmNlIHRoZSBwYXRjaCBm YWlscyBhZ2Fpbg0KPiA+DQo+ID4gSXQgd29ya3MgZmluZSBmb3IgbWUgYWdhaW5zdCBjb21taXQg ZGRmMzQzZjYzNWZlNDQ0MGNhZDUyOGUxMmY5NmYyOGJkNTBhYTA5OToNCj4gPg0KPiA+IFt0cm9u ZG15QGxhZGUgbGludXgtbmZzXSQgZ2l0IGJyYW5jaCB0ZXN0LWFwcGx5IGRkZjM0M2Y2MzVmZTQ0 NDBjYWQ1MjhlMTJmOTZmMjhiZDUwYWEwOTkNCj4gPiBbdHJvbmRteUBsYWRlIGxpbnV4LW5mc10k IGdpdCBjaGVja291dCB0ZXN0LWFwcGx5DQo+ID4gU3dpdGNoZWQgdG8gYnJhbmNoICd0ZXN0LWFw cGx5Jw0KPiA+IFt0cm9uZG15QGxhZGUgbGludXgtbmZzXSQgZ2l0IGFtIH4vRGVza3RvcC9mb3Jf c2hhaS8wMDAxLU5GUy1DbGVhci1rZXktY29uc3RydWN0aW9uLWRhdGEtaWYtdGhlLWlkbWFwLXVw Y2FsbC0ucGF0Y2gNCj4gPiBBcHBseWluZzogTkZTOiBDbGVhciBrZXkgY29uc3RydWN0aW9uIGRh dGEgaWYgdGhlIGlkbWFwIHVwY2FsbCBmYWlscw0KPiA+IFt0cm9uZG15QGxhZGUgbGludXgtbmZz XSQgZ2l0IGFtIH4vRGVza3RvcC9mb3Jfc2hhaS8wMDAyLU5GUy1yZXR1cm4tRU5PS0VZLXdoZW4t dGhlLXVwY2FsbC1mYWlscy10by1tYXAtdGhlLW4ucGF0Y2gNCj4gPiBBcHBseWluZzogTkZTOiBy ZXR1cm4gLUVOT0tFWSB3aGVuIHRoZSB1cGNhbGwgZmFpbHMgdG8gbWFwIHRoZSBuYW1lDQo+ID4N Cj4gPiBXaGF0IGVycm9yIG1lc3NhZ2VzIGFyZSB5b3Ugc2VlaW5nPw0KPiA+DQo+ID4gQ2hlZXJz DQo+ID4gICBUcm9uZA0KPiA+DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ ID4gRnJvbTogTXlrbGVidXN0LCBUcm9uZCBbbWFpbHRvOlRyb25kLk15a2xlYnVzdEBuZXRhcHAu Y29tXQ0KPiA+ID4gU2VudDogVGh1cnNkYXksIEF1Z3VzdCAxNiwgMjAxMiA0OjU3IFBNDQo+ID4g PiBUbzogU2hhaSBMYXptaQ0KPiA+ID4gQ2M6IFdpbGxpYW0gRGF1Y2h5OyBTY2h1bWFrZXIsIEJy eWFuOyBsaW51eC1uZnNAdmdlci5rZXJuZWwub3JnDQo+ID4gPiBTdWJqZWN0OiBSZTogW1BBVENI IDEvMl0gTkZTOiBDbGVhciBrZXkgY29uc3RydWN0aW9uIGRhdGEgaWYgdGhlIGlkbWFwIHVwY2Fs bCBmYWlscw0KPiA+ID4NCj4gPiA+IE9uIFRodSwgMjAxMi0wOC0xNiBhdCAxNjo1MCAtMDcwMCwg U2hhaSBMYXptaSB3cm90ZToNCj4gPiA+ID4gTVMgb3V0bG9vaw0KPiA+ID4NCj4gPiA+IERvbid0 IGV2ZXIgdXNlIExvb2tPdXQgZm9yIHBhdGNoZXMuIEl0cyAiSSBqdXN0IHJlZm9ybWF0dGVkIHlv dXIgZW1haWwiDQo+ID4gPiB3b25kZXIgZmVhdHVyZSBicmVha3MgYWxsIHRoZSB3aGl0ZXNwYWNl Lg0KPiA+ID4NCj4gPiA+ID4gQmVzdCB0aGluZyBpcyB0byBhdHRhY2hlZCB0aGUgcGF0Y2gNCj4g PiA+DQo+ID4gPiBXZSBkbyBub3Qgbm9ybWFsbHkgdXNlIGF0dGFjaG1lbnRzIG9uIHRoZSBtYWls aW5nIGxpc3QgYmVjYXVzZSBpdCBtYWtlcyBpdCBpbXBvc3NpYmxlIHRvIGNvbW1lbnQgdGhlIHBh dGNoZXMgaW5saW5lLiBBaCB3ZWxsLCBoZXJlIGdvZXMuLi4NCj4gPiA+DQo+ID4gPiAtLQ0KPiA+ ID4gVHJvbmQgTXlrbGVidXN0DQo+ID4gPiBMaW51eCBORlMgY2xpZW50IG1haW50YWluZXINCj4g PiA+DQo+ID4gPiBOZXRBcHANCj4gPiA+IFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tDQo+ID4g PiB3d3cubmV0YXBwLmNvbQ0KPiA+ID4NCj4gPiA+DQo+ID4gPiBUaGlzIG1lc3NhZ2UgYW5kIGFu eSBhdHRhY2hlZCBkb2N1bWVudHMgY29udGFpbiBpbmZvcm1hdGlvbiBmcm9tIFFMb2dpYyBDb3Jw b3JhdGlvbiBvciBpdHMgd2hvbGx5LW93bmVkIHN1YnNpZGlhcmllcyB0aGF0IG1heSBiZSBjb25m aWRlbnRpYWwuIElmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZCByZWNpcGllbnQsIHlvdSBtYXkg bm90IHJlYWQsIGNvcHksIGRpc3RyaWJ1dGUsIG9yIHVzZSB0aGlzIGluZm9ybWF0aW9uLiBJZiB5 b3UgaGF2ZSByZWNlaXZlZCB0aGlzIHRyYW5zbWlzc2lvbiBpbiBlcnJvciwgcGxlYXNlIG5vdGlm eSB0aGUgc2VuZGVyIGltbWVkaWF0ZWx5IGJ5IHJlcGx5IGUtbWFpbCBhbmQgdGhlbiBkZWxldGUg dGhpcyBtZXNzYWdlLg0KPiA+DQo+ID4gLS0NCj4gPiBUcm9uZCBNeWtsZWJ1c3QNCj4gPiBMaW51 eCBORlMgY2xpZW50IG1haW50YWluZXINCj4gPg0KPiA+IE5ldEFwcA0KPiA+IFRyb25kLk15a2xl YnVzdEBuZXRhcHAuY29tDQo+ID4gd3d3Lm5ldGFwcC5jb20NCj4gPg0KPiA+DQo+ID4gVGhpcyBt ZXNzYWdlIGFuZCBhbnkgYXR0YWNoZWQgZG9jdW1lbnRzIGNvbnRhaW4gaW5mb3JtYXRpb24gZnJv bSBRTG9naWMgQ29ycG9yYXRpb24gb3IgaXRzIHdob2xseS1vd25lZCBzdWJzaWRpYXJpZXMgdGhh dCBtYXkgYmUgY29uZmlkZW50aWFsLiBJZiB5b3UgYXJlIG5vdCB0aGUgaW50ZW5kZWQgcmVjaXBp ZW50LCB5b3UgbWF5IG5vdCByZWFkLCBjb3B5LCBkaXN0cmlidXRlLCBvciB1c2UgdGhpcyBpbmZv cm1hdGlvbi4gSWYgeW91IGhhdmUgcmVjZWl2ZWQgdGhpcyB0cmFuc21pc3Npb24gaW4gZXJyb3Is IHBsZWFzZSBub3RpZnkgdGhlIHNlbmRlciBpbW1lZGlhdGVseSBieSByZXBseSBlLW1haWwgYW5k IHRoZW4gZGVsZXRlIHRoaXMgbWVzc2FnZS4NCj4gDQo+IC0tDQo+IFRyb25kIE15a2xlYnVzdA0K PiBMaW51eCBORlMgY2xpZW50IG1haW50YWluZXINCj4gDQo+IE5ldEFwcA0KPiBUcm9uZC5NeWts ZWJ1c3RAbmV0YXBwLmNvbQ0KPiB3d3cubmV0YXBwLmNvbQ0KPiANCj4gDQo+IFRoaXMgbWVzc2Fn ZSBhbmQgYW55IGF0dGFjaGVkIGRvY3VtZW50cyBjb250YWluIGluZm9ybWF0aW9uIGZyb20gUUxv Z2ljIENvcnBvcmF0aW9uIG9yIGl0cyB3aG9sbHktb3duZWQgc3Vic2lkaWFyaWVzIHRoYXQgbWF5 IGJlIGNvbmZpZGVudGlhbC4gSWYgeW91IGFyZSBub3QgdGhlIGludGVuZGVkIHJlY2lwaWVudCwg eW91IG1heSBub3QgcmVhZCwgY29weSwgZGlzdHJpYnV0ZSwgb3IgdXNlIHRoaXMgaW5mb3JtYXRp b24uIElmIHlvdSBoYXZlIHJlY2VpdmVkIHRoaXMgdHJhbnNtaXNzaW9uIGluIGVycm9yLCBwbGVh c2Ugbm90aWZ5IHRoZSBzZW5kZXIgaW1tZWRpYXRlbHkgYnkgcmVwbHkgZS1tYWlsIGFuZCB0aGVu IGRlbGV0ZSB0aGlzIG1lc3NhZ2UuDQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMg Y2xpZW50IG1haW50YWluZXINCg0KTmV0QXBwDQpUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbQ0K d3d3Lm5ldGFwcC5jb20NCg0K