Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx2.netapp.com ([216.240.18.37]:35552 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030774Ab2HIPko (ORCPT ); Thu, 9 Aug 2012 11:40:44 -0400 From: "Myklebust, Trond" To: Peng Tao CC: "linux-nfs@vger.kernel.org" , Tigran Mkrtchyan , Boaz Harrosh , Benny Halevy , "Isaman, Fred" Subject: Re: [PATCH] NFSv4.1: Remove a bogus BUG_ON() in nfs4_layoutreturn_done Date: Thu, 9 Aug 2012 15:39:42 +0000 Message-ID: <1344526780.25447.6.camel@lade.trondhjem.org> References: <1344457310-26442-1-git-send-email-Trond.Myklebust@netapp.com> <1344522979.23523.2.camel@lade.trondhjem.org> In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gVGh1LCAyMDEyLTA4LTA5IGF0IDIzOjAxICswODAwLCBQZW5nIFRhbyB3cm90ZToNCj4gT24g VGh1LCBBdWcgOSwgMjAxMiBhdCAxMDozNiBQTSwgTXlrbGVidXN0LCBUcm9uZA0KPiA8VHJvbmQu TXlrbGVidXN0QG5ldGFwcC5jb20+IHdyb3RlOg0KPiA+IE9uIFRodSwgMjAxMi0wOC0wOSBhdCAy MjozMCArMDgwMCwgUGVuZyBUYW8gd3JvdGU6DQo+ID4+IE9uIFRodSwgQXVnIDksIDIwMTIgYXQg NDoyMSBBTSwgVHJvbmQgTXlrbGVidXN0DQo+ID4+IDxUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNv bT4gd3JvdGU6DQo+ID4+ID4gRXZlciBzaW5jZSBjb21taXQgMGE1N2NkYWMzZiAoTkZTdjQuMSBz ZW5kIGxheW91dHJldHVybiB0byBmZW5jZQ0KPiA+PiA+IGRpc2Nvbm5lY3RlZCBkYXRhIHNlcnZl cikgd2UndmUgYmVlbiBzZW5kaW5nIGxheW91dHJldHVybiBjYWxscw0KPiA+PiA+IHdoaWxlIHRo ZXJlIGlzIHBvdGVudGlhbGx5IHN0aWxsIG91dHN0YW5kaW5nIEkvTyB0byB0aGUgZGF0YQ0KPiA+ PiA+IHNlcnZlcnMuIFRoZSByZWFzb24gd2UgZG8gdGhpcyBpcyB0byBhdm9pZCByYWNlcyBiZXR3 ZWVuIHJlcGxheWVkDQo+ID4+ID4gd3JpdGVzIHRvIHRoZSBNRFMgYW5kIHRoZSBvcmlnaW5hbCB3 cml0ZXMgdG8gdGhlIERTLg0KPiA+PiA+DQo+ID4+ID4gV2hlbiB0aGlzIGhhcHBlbnMsIHRoZSBC VUdfT04oKSBpbiBuZnM0X2xheW91dHJldHVybl9kb25lIGNhbg0KPiA+PiA+IGJlIHRyaWdnZXJl ZCBiZWNhdXNlIGl0IGFzc3VtZXMgdGhhdCB3ZSB3b3VsZCBuZXZlciBjYWxsDQo+ID4+ID4gbGF5 b3V0cmV0dXJuIHdpdGhvdXQga25vd2luZyB0aGF0IGFsbCBJL08gdG8gdGhlIERTIGlzDQo+ID4+ ID4gZmluaXNoZWQuIFRoZSBmaXggaXMgdG8gcmVtb3ZlIHRoZSBCVUdfT04oKSBub3cgdGhhdCB0 aGUNCj4gPj4gPiBhc3N1bXB0aW9ucyBiZWhpbmQgdGhlIHRlc3QgYXJlIG9ic29sZXRlLg0KPiA+ PiA+DQo+ID4+IElzbid0IE1EUyBzdXBwb3NlZCB0byByZWNhbGwgdGhlIGxheW91dCBpZiByYWNl cyBhcmUgcG9zc2libGUgYmV0d2Vlbg0KPiA+PiBvdXRzdGFuZGluZyB3cml0ZS10by1EUyBhbmQg d3JpdGUtdGhyb3VnaC1NRFM/DQo+ID4NCj4gPiBXaGVyZSBkbyB5b3UgcmVhZCB0aGF0IGluIFJG QzU2NjE/DQo+ID4NCj4gVGhhdCdzIG15IChtYXliZSBtaXMtKXVuZGVyc3RhbmRpbmcgb2YgaG93 IHNlcnZlciB3b3Jrcy4uLiBCdXQgbG9va2luZw0KPiBhdCByZmM1NjYxIHNlY3Rpb24gMTguNDQu My4gbGF5b3V0cmV0dXJuIGltcGxlbWVudGF0aW9uLg0KPiAiDQo+IEFmdGVyIHRoaXMgY2FsbCwN Cj4gICAgdGhlIGNsaWVudCBNVVNUIE5PVCB1c2UgdGhlIHJldHVybmVkIGxheW91dChzKSBhbmQg dGhlIGFzc29jaWF0ZWQNCj4gICAgc3RvcmFnZSBwcm90b2NvbCB0byBhY2Nlc3MgdGhlIGZpbGUg ZGF0YS4NCj4gIg0KPiBBbmQgZ2l2ZW4gY29tbWl0IDBhNTdjZGFjM2YsIGNsaWVudCBpcyB1c2lu ZyB0aGUgbGF5b3V0IGV2ZW4gYWZ0ZXINCj4gbGF5b3V0cmV0dXJuLCB3aGljaCBJTUhPIGlzIGEg dmlvbGF0aW9uIG9mIHJmYzU2NjEuDQoNCk5vLiBJdCBpcyB1c2luZyB0aGUgbGF5b3V0cmV0dXJu IHRvIHRlbGwgdGhlIE1EUyB0byBmZW5jZSBvZmYgSS9PIHRvIGENCmRhdGEgc2VydmVyIHRoYXQg aXMgbm90IHJlc3BvbmRpbmcuIEl0IGlzbid0IGF0dGVtcHRpbmcgdG8gdXNlIHRoZQ0KbGF5b3V0 IGFmdGVyIHRoZSBsYXlvdXRyZXR1cm46IHRoZSB3aG9sZSBwb2ludCBpcyB0aGF0IHdlIGFyZSBh dHRlbXB0aW5nDQp3cml0ZS10aHJvdWdoLU1EUyBhZnRlciB0aGUgYXR0ZW1wdCB0byB3cml0ZSB0 aHJvdWdoIHRoZSBEUyB0aW1lZCBvdXQuDQoNCj4gPj4gQW5kIGl0IGNhdXNlcyBkYXRhIGNvcnJ1 cHRpb24gZm9yIGJsb2NrbGF5b3V0IGlmIGNsaWVudCByZXR1cm5zIGxheW91dA0KPiA+PiB3aGls ZSB0aGVyZSBpcyBpbi1mbGlnaHQgZGlzayBJTy4uLg0KPiA+DQo+ID4gVGhlbiBpdCBuZWVkcyB0 byB0dXJuIG9mZiBmYXN0IGZhaWxvdmVyIHRvIHdyaXRlLXRocm91Z2gtTURTLg0KPiA+DQo+IElm IHlvdSBzdGlsbCBjb25zaWRlciBpdCBmb2xsb3dpbmcgcmZjNTY2MSwgSSdkIGNob29zZSB0byBk aXNhYmxlDQo+IGxheW91dHJldHVybiBpbiBiZWZvcmUgd3JpdGUtdGhyb3VnaC1NRFMgZm9yIGJs b2NrbGF5b3V0LCBieSBhZGRpbmcNCj4gc29tZSBmbGFnIGxpa2UgUE5GU19OT19MQVlPVVRSRVRf T05fRkFMTFRIUlUgc2ltaWxhciB0byBvYmplY3RzJw0KPiBQTkZTX0xBWU9VVFJFVF9PTl9TRVRB VFRSLg0KDQpJIGRvbid0IHNlZSBob3cgdGhhdCB3aWxsIHByZXZlbnQgY29ycnVwdGlvbi4NCg0K SW4gZmFjdCwgSUlSQywgaW4gTkZTdjQuMiBTb3JpbidzIHByb3Bvc2VkIGNoYW5nZXMgc3BlY2lm aWNhbGx5IHVzZSB0aGUNCmxheW91dHJldHVybiB0byBjb21tdW5pY2F0ZSB0byB0aGUgTURTIHRo YXQgdGhlIERTIGlzIHRpbWluZyBvdXQgdmlhIGFuDQplcnJvciBjb2RlIChsaWtlIHRoZSBvYmpl Y3QgbGF5b3V0IGhhcyBkb25lIGFsbCB0aGUgdGltZSkuIEhvdyBjYW4geW91DQpyZWNvbmNpbGUg dGhhdCBjaGFuZ2Ugd2l0aCBhIGZsYWcgc3VjaCBhcyB0aGUgb25lIHlvdSBwcm9wb3NlPw0KDQot LSANClRyb25kIE15a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBtYWludGFpbmVyDQoNCk5ldEFw cA0KVHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20NCnd3dy5uZXRhcHAuY29tDQoNCg==