Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-wi0-f178.google.com ([209.85.212.178]:49623 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759032Ab2HHRvJ (ORCPT ); Wed, 8 Aug 2012 13:51:09 -0400 Received: by wibhr14 with SMTP id hr14so970593wib.1 for ; Wed, 08 Aug 2012 10:51:08 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1344447279.8925.5.camel@lade.trondhjem.org> References: <1344447279.8925.5.camel@lade.trondhjem.org> Date: Wed, 8 Aug 2012 13:51:08 -0400 Message-ID: Subject: Re: client kernel panic on server restart From: Fred Isaman To: "Myklebust, Trond" Cc: "tigran.mkrtchyan@desy.de" , Boaz Harrosh , Benny Halevy , "Isaman, Fred" , linux-nfs Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, Aug 8, 2012 at 1:34 PM, Myklebust, Trond wrote: > On Wed, 2012-08-08 at 18:48 +0200, Tigran Mkrtchyan wrote: >> Hi, >> >> It's quite some time without kernel panic reports from me .... >> >> Observer on MDS and DS shutdown during IO. >> >> This is with 3.5.0-2.fc17.x86_64 kernel. Line in code: >> >> nfs4proc.c:6252 : BUG_ON(!list_empty(&lo->plh_segs)); >> > > If the server doesn't return a stateid, then that is supposed to > indicate that it thinks that it doesn't hold any more layout segments > for this file. > To me, that indicates that we should be calling > mark_matching_lsegs_invalid() rather than Oopsing. > > Any dissenting voices from the pNFS crowd? > But this implies that the client thinks it has a layout which the server does not believe it has, which seems to me to imply an earlier bug. If you change to mark_matching_lsegs_invalid, I would suggest keeping a WARN_ON. Fred