Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx2.netapp.com ([216.240.18.37]:56269 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756080Ab2HIQaR (ORCPT ); Thu, 9 Aug 2012 12:30:17 -0400 From: "Myklebust, Trond" To: Peng Tao CC: "linux-nfs@vger.kernel.org" , Tigran Mkrtchyan , Boaz Harrosh , Benny Halevy , "Isaman, Fred" Subject: Re: [PATCH] NFSv4.1: Remove a bogus BUG_ON() in nfs4_layoutreturn_done Date: Thu, 9 Aug 2012 16:29:44 +0000 Message-ID: <1344529783.25447.32.camel@lade.trondhjem.org> References: <1344457310-26442-1-git-send-email-Trond.Myklebust@netapp.com> <1344522979.23523.2.camel@lade.trondhjem.org> <1344526780.25447.6.camel@lade.trondhjem.org> In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gRnJpLCAyMDEyLTA4LTEwIGF0IDAwOjIyICswODAwLCBQZW5nIFRhbyB3cm90ZToNCj4gT24g VGh1LCBBdWcgOSwgMjAxMiBhdCAxMTozOSBQTSwgTXlrbGVidXN0LCBUcm9uZA0KPiA8VHJvbmQu TXlrbGVidXN0QG5ldGFwcC5jb20+IHdyb3RlOg0KPiA+IE9uIFRodSwgMjAxMi0wOC0wOSBhdCAy MzowMSArMDgwMCwgUGVuZyBUYW8gd3JvdGU6DQo+ID4+IE9uIFRodSwgQXVnIDksIDIwMTIgYXQg MTA6MzYgUE0sIE15a2xlYnVzdCwgVHJvbmQNCj4gPj4gPFRyb25kLk15a2xlYnVzdEBuZXRhcHAu Y29tPiB3cm90ZToNCj4gPj4gPiBPbiBUaHUsIDIwMTItMDgtMDkgYXQgMjI6MzAgKzA4MDAsIFBl bmcgVGFvIHdyb3RlOg0KPiA+PiA+PiBPbiBUaHUsIEF1ZyA5LCAyMDEyIGF0IDQ6MjEgQU0sIFRy b25kIE15a2xlYnVzdA0KPiA+PiA+PiA8VHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20+IHdyb3Rl Og0KPiA+PiA+PiA+IEV2ZXIgc2luY2UgY29tbWl0IDBhNTdjZGFjM2YgKE5GU3Y0LjEgc2VuZCBs YXlvdXRyZXR1cm4gdG8gZmVuY2UNCj4gPj4gPj4gPiBkaXNjb25uZWN0ZWQgZGF0YSBzZXJ2ZXIp IHdlJ3ZlIGJlZW4gc2VuZGluZyBsYXlvdXRyZXR1cm4gY2FsbHMNCj4gPj4gPj4gPiB3aGlsZSB0 aGVyZSBpcyBwb3RlbnRpYWxseSBzdGlsbCBvdXRzdGFuZGluZyBJL08gdG8gdGhlIGRhdGENCj4g Pj4gPj4gPiBzZXJ2ZXJzLiBUaGUgcmVhc29uIHdlIGRvIHRoaXMgaXMgdG8gYXZvaWQgcmFjZXMg YmV0d2VlbiByZXBsYXllZA0KPiA+PiA+PiA+IHdyaXRlcyB0byB0aGUgTURTIGFuZCB0aGUgb3Jp Z2luYWwgd3JpdGVzIHRvIHRoZSBEUy4NCj4gPj4gPj4gPg0KPiA+PiA+PiA+IFdoZW4gdGhpcyBo YXBwZW5zLCB0aGUgQlVHX09OKCkgaW4gbmZzNF9sYXlvdXRyZXR1cm5fZG9uZSBjYW4NCj4gPj4g Pj4gPiBiZSB0cmlnZ2VyZWQgYmVjYXVzZSBpdCBhc3N1bWVzIHRoYXQgd2Ugd291bGQgbmV2ZXIg Y2FsbA0KPiA+PiA+PiA+IGxheW91dHJldHVybiB3aXRob3V0IGtub3dpbmcgdGhhdCBhbGwgSS9P IHRvIHRoZSBEUyBpcw0KPiA+PiA+PiA+IGZpbmlzaGVkLiBUaGUgZml4IGlzIHRvIHJlbW92ZSB0 aGUgQlVHX09OKCkgbm93IHRoYXQgdGhlDQo+ID4+ID4+ID4gYXNzdW1wdGlvbnMgYmVoaW5kIHRo ZSB0ZXN0IGFyZSBvYnNvbGV0ZS4NCj4gPj4gPj4gPg0KPiA+PiA+PiBJc24ndCBNRFMgc3VwcG9z ZWQgdG8gcmVjYWxsIHRoZSBsYXlvdXQgaWYgcmFjZXMgYXJlIHBvc3NpYmxlIGJldHdlZW4NCj4g Pj4gPj4gb3V0c3RhbmRpbmcgd3JpdGUtdG8tRFMgYW5kIHdyaXRlLXRocm91Z2gtTURTPw0KPiA+ PiA+DQo+ID4+ID4gV2hlcmUgZG8geW91IHJlYWQgdGhhdCBpbiBSRkM1NjYxPw0KPiA+PiA+DQo+ ID4+IFRoYXQncyBteSAobWF5YmUgbWlzLSl1bmRlcnN0YW5kaW5nIG9mIGhvdyBzZXJ2ZXIgd29y a3MuLi4gQnV0IGxvb2tpbmcNCj4gPj4gYXQgcmZjNTY2MSBzZWN0aW9uIDE4LjQ0LjMuIGxheW91 dHJldHVybiBpbXBsZW1lbnRhdGlvbi4NCj4gPj4gIg0KPiA+PiBBZnRlciB0aGlzIGNhbGwsDQo+ ID4+ICAgIHRoZSBjbGllbnQgTVVTVCBOT1QgdXNlIHRoZSByZXR1cm5lZCBsYXlvdXQocykgYW5k IHRoZSBhc3NvY2lhdGVkDQo+ID4+ICAgIHN0b3JhZ2UgcHJvdG9jb2wgdG8gYWNjZXNzIHRoZSBm aWxlIGRhdGEuDQo+ID4+ICINCj4gPj4gQW5kIGdpdmVuIGNvbW1pdCAwYTU3Y2RhYzNmLCBjbGll bnQgaXMgdXNpbmcgdGhlIGxheW91dCBldmVuIGFmdGVyDQo+ID4+IGxheW91dHJldHVybiwgd2hp Y2ggSU1ITyBpcyBhIHZpb2xhdGlvbiBvZiByZmM1NjYxLg0KPiA+DQo+ID4gTm8uIEl0IGlzIHVz aW5nIHRoZSBsYXlvdXRyZXR1cm4gdG8gdGVsbCB0aGUgTURTIHRvIGZlbmNlIG9mZiBJL08gdG8g YQ0KPiA+IGRhdGEgc2VydmVyIHRoYXQgaXMgbm90IHJlc3BvbmRpbmcuIEl0IGlzbid0IGF0dGVt cHRpbmcgdG8gdXNlIHRoZQ0KPiA+IGxheW91dCBhZnRlciB0aGUgbGF5b3V0cmV0dXJuOiB0aGUg d2hvbGUgcG9pbnQgaXMgdGhhdCB3ZSBhcmUgYXR0ZW1wdGluZw0KPiA+IHdyaXRlLXRocm91Z2gt TURTIGFmdGVyIHRoZSBhdHRlbXB0IHRvIHdyaXRlIHRocm91Z2ggdGhlIERTIHRpbWVkIG91dC4N Cj4gPg0KPiBCdXQgaXQgaXMgUkZDIHZpb2xhdGlvbiB0aGF0IHRoZXJlIGlzIGluLWZsaWdodCBE UyBJTyB3aGVuIGNsaWVudA0KPiBzZW5kcyBsYXlvdXRyZXR1cm4sIHJpZ2h0PyBOb3QganVzdCBp bi1mbGlnaHQsIGNsaWVudCBpcyB3ZWxsIHBvc3NpYmxlDQo+IHRvIHNlbmQgSU8gdG8gRFMgX2Fm dGVyXyBsYXlvdXRyZXR1cm4gYmVjYXVzZSBzb21lIHRocmVhZCBjYW4gaG9sZA0KPiBsc2VnIHJl ZmVyZW5jZSBhbmQgbm90IHlldCBzZW5kIElPLg0KDQpPbmNlIHRoZSB3cml0ZSBoYXMgYmVlbiBz ZW50LCBob3cgZG8geW91IGtub3cgdGhhdCBpdCBpcyBubyBsb25nZXINCidpbi1mbGlnaHQnIHVu bGVzcyB0aGUgRFMgcmVzcG9uZHM/DQoNCj4gPj4gPj4gQW5kIGl0IGNhdXNlcyBkYXRhIGNvcnJ1 cHRpb24gZm9yIGJsb2NrbGF5b3V0IGlmIGNsaWVudCByZXR1cm5zIGxheW91dA0KPiA+PiA+PiB3 aGlsZSB0aGVyZSBpcyBpbi1mbGlnaHQgZGlzayBJTy4uLg0KPiA+PiA+DQo+ID4+ID4gVGhlbiBp dCBuZWVkcyB0byB0dXJuIG9mZiBmYXN0IGZhaWxvdmVyIHRvIHdyaXRlLXRocm91Z2gtTURTLg0K PiA+PiA+DQo+ID4+IElmIHlvdSBzdGlsbCBjb25zaWRlciBpdCBmb2xsb3dpbmcgcmZjNTY2MSwg SSdkIGNob29zZSB0byBkaXNhYmxlDQo+ID4+IGxheW91dHJldHVybiBpbiBiZWZvcmUgd3JpdGUt dGhyb3VnaC1NRFMgZm9yIGJsb2NrbGF5b3V0LCBieSBhZGRpbmcNCj4gPj4gc29tZSBmbGFnIGxp a2UgUE5GU19OT19MQVlPVVRSRVRfT05fRkFMTFRIUlUgc2ltaWxhciB0byBvYmplY3RzJw0KPiA+ PiBQTkZTX0xBWU9VVFJFVF9PTl9TRVRBVFRSLg0KPiA+DQo+ID4gSSBkb24ndCBzZWUgaG93IHRo YXQgd2lsbCBwcmV2ZW50IGNvcnJ1cHRpb24uDQo+ID4NCj4gPiBJbiBmYWN0LCBJSVJDLCBpbiBO RlN2NC4yIFNvcmluJ3MgcHJvcG9zZWQgY2hhbmdlcyBzcGVjaWZpY2FsbHkgdXNlIHRoZQ0KPiA+ IGxheW91dHJldHVybiB0byBjb21tdW5pY2F0ZSB0byB0aGUgTURTIHRoYXQgdGhlIERTIGlzIHRp bWluZyBvdXQgdmlhIGFuDQo+ID4gZXJyb3IgY29kZSAobGlrZSB0aGUgb2JqZWN0IGxheW91dCBo YXMgZG9uZSBhbGwgdGhlIHRpbWUpLiBIb3cgY2FuIHlvdQ0KPiA+IHJlY29uY2lsZSB0aGF0IGNo YW5nZSB3aXRoIGEgZmxhZyBzdWNoIGFzIHRoZSBvbmUgeW91IHByb3Bvc2U/DQo+IEkganVzdCBp bnRlbmQgdG8gdXNlIHRoZSBmbGFnIHRvIGRpc2FibGUgbGF5b3V0cmV0dXJuIGluDQo+IHBuZnNf bGRfd3JpdGVfZG9uZS4gYmxvY2sgZXh0ZW50cyBhcmUgZGF0YSBhY2Nlc3MgcGVybWlzc2lvbnMg cGVyDQo+IHJmYzU2NjMuIFdoZW4gd2UgZG9uJ3QgbGF5b3V0cmV0dXJuIGluIHBuZnNfbGRfd3Jp dGVfZG9uZSgpLCBibG9jaw0KPiBsYXlvdXQgd29ya3MgY29ycmVjdGx5IGJlY2F1c2Ugc2VydmVy IGNhbiBkZWNpZGUgaWYgdGhlcmUgaXMgZGF0YQ0KPiBhY2Nlc3MgcmFjZSBhbmQgaWYgdGhlcmUg aXMsIE1EUyBjYW4gcmVjYWxsIHRoZSBsYXlvdXQgZnJvbSBjbGllbnQNCj4gYmVmb3JlIGFwcGx5 aW5nIHRoZSBNRFMgd3JpdGVzLg0KPiANCj4gU29yaW4ncyBwcm9wb3NlZCBlcnJvciBjb2RlIGlz IGp1c3QgYSBjbGllbnQgaW5kaWNhdGlvbiB0byBzZXJ2ZXIgdGhhdA0KPiB0aGVyZSBpcyBkaXNr IGFjY2VzcyBlcnJvci4gSXQgaXMgbm90IGludGVuZGVkIHRvIHNvbHZlIHRoZSBkYXRhIHJhY2UN Cj4gYmV0d2VlbiB3cml0ZS10aHJvdWdoLU1EUyBhbmQgd3JpdGUtdGhyb3VnaC1EUy4NCg0KVGhl biBob3cgZG8geW91IHNvbHZlIHRoYXQgcmFjZSBvbiBhIGJsb2NrIGRldmljZT8NCg0KLS0gDQpU cm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRhaW5lcg0KDQpOZXRBcHANClRy b25kLk15a2xlYnVzdEBuZXRhcHAuY29tDQp3d3cubmV0YXBwLmNvbQ0KDQo=