Return-Path: linux-nfs-owner@vger.kernel.org Received: from fieldses.org ([174.143.236.118]:39653 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756200Ab2JQOAZ (ORCPT ); Wed, 17 Oct 2012 10:00:25 -0400 Date: Wed, 17 Oct 2012 10:00:20 -0400 From: Bruce Fields To: "Myklebust, Trond" Cc: Larry McVoy , Linus Torvalds , Linux NFS Mailing List Subject: Re: kernel BUG at /build/buildd/linux-3.2.0/fs/lockd/clntxdr.c:226! Message-ID: <20121017140020.GA25488@fieldses.org> References: <20121012211701.GA8301@bitmover.com> <20121013002100.GB23247@bitmover.com> <4FA345DA4F4AE44899BD2B03EEEC2FA9091FDED5@SACEXCMBX04-PRD.hq.netapp.com> <20121013023147.GJ23247@bitmover.com> <4FA345DA4F4AE44899BD2B03EEEC2FA9091FE478@SACEXCMBX04-PRD.hq.netapp.com> <20121013025600.GL23247@bitmover.com> <4FA345DA4F4AE44899BD2B03EEEC2FA9091FFA38@SACEXCMBX04-PRD.hq.netapp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4FA345DA4F4AE44899BD2B03EEEC2FA9091FFA38@SACEXCMBX04-PRD.hq.netapp.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Sat, Oct 13, 2012 at 04:42:05AM +0000, Myklebust, Trond wrote: > On Fri, 2012-10-12 at 19:56 -0700, Larry McVoy wrote: > > On Sat, Oct 13, 2012 at 02:52:51AM +0000, Myklebust, Trond wrote: > > > On Fri, 2012-10-12 at 19:31 -0700, Larry McVoy wrote: > > > > As I've said, debugging this is going to be hard, it means stopping my > > > > company. We can do one more crash, you guys can tell me what to do, > > > > but that's about it. > > > > > > Do you have a reproducer? > > > > Oh yeah, it happens every time. Run skype on a mac w/ your home dir NFS > > mounted. Skype tries to do some lock operation and the machine panics. > > > > We've done it 4 times in a row to be sure we weren't smoking crack. No > > crack. Just panics. > > OK. I think I can see what is happening. We need to filter the return > values from nlm_lookup_file() when dealing with NLMv1 and NLMv3. > > Can you please try the attached patch? Larry, did you get a chance to test this patch? It seems obviously right anyway, so I'll go ahead and pass it along regardless, but it would be nice to have the confirmation. --b.