Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx12.netapp.com ([216.240.18.77]:57050 "EHLO mx12.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753302Ab2KPV7V (ORCPT ); Fri, 16 Nov 2012 16:59:21 -0500 From: "Myklebust, Trond" To: Jim Rees CC: "linux-nfs@vger.kernel.org" Subject: Re: [PATCH] NFS: Reduce stack use in encode_exchange_id() Date: Fri, 16 Nov 2012 21:59:18 +0000 Message-ID: <4FA345DA4F4AE44899BD2B03EEEC2FA9092E9FA3@SACEXCMBX04-PRD.hq.netapp.com> References: <1353101475-11613-1-git-send-email-rees@umich.edu> In-Reply-To: <1353101475-11613-1-git-send-email-rees@umich.edu> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gRnJpLCAyMDEyLTExLTE2IGF0IDE2OjMxIC0wNTAwLCBKaW0gUmVlcyB3cm90ZToNCj4gZW5j b2RlX2V4Y2hhbmdlX2lkKCkgdXNlcyBtb3JlIHN0YWNrIHNwYWNlIHRoYW4gbmVjZXNzYXJ5LCBn aXZpbmcgYSBjb21waWxlDQo+IHRpbWUgd2FybmluZy4gUmVkdWNlIHRoZSBzaXplIG9mIHRoZSBz dGF0aWMgYnVmZmVyIGZvciBpbXBsZW1lbnRhdGlvbiBuYW1lLg0KPiANCj4gU2lnbmVkLW9mZi1i eTogSmltIFJlZXMgPHJlZXNAdW1pY2guZWR1Pg0KPiBSZXZpZXdlZC1ieTogIkFkYW1zb24sIERy b3MiIDxXZXN0b24uQWRhbXNvbkBuZXRhcHAuY29tPg0KPiAtLS0NCj4gIGZzL25mcy9uZnM0eGRy LmMgfCAgICA3ICsrKysrLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZnMvbmZzL25mczR4ZHIuYyBiL2ZzL25m cy9uZnM0eGRyLmMNCj4gaW5kZXggNjcyZDliMC4uZTljMTAxZCAxMDA2NDQNCj4gLS0tIGEvZnMv bmZzL25mczR4ZHIuYw0KPiArKysgYi9mcy9uZnMvbmZzNHhkci5jDQo+IEBAIC0xNzA2LDEyICsx NzA2LDE1IEBAIHN0YXRpYyB2b2lkIGVuY29kZV9iaW5kX2Nvbm5fdG9fc2Vzc2lvbihzdHJ1Y3Qg eGRyX3N0cmVhbSAqeGRyLA0KPiAgCSpwID0gMDsJLyogdXNlX2Nvbm5faW5fcmRtYV9tb2RlID0g RmFsc2UgKi8NCj4gIH0NCj4gIA0KPiArI2RlZmluZSBJTVBMX05BTUVfTElNSVQgKHNpemVvZih1 dHNuYW1lKCktPnN5c25hbWUpICsgc2l6ZW9mKHV0c25hbWUoKS0+cmVsZWFzZSkgKyBcDQo+ICsJ CQkgc2l6ZW9mKHV0c25hbWUoKS0+dmVyc2lvbikgKyBzaXplb2YodXRzbmFtZSgpLT5tYWNoaW5l KSArIDgpDQo+ICsNCj4gIHN0YXRpYyB2b2lkIGVuY29kZV9leGNoYW5nZV9pZChzdHJ1Y3QgeGRy X3N0cmVhbSAqeGRyLA0KPiAgCQkJICAgICAgIHN0cnVjdCBuZnM0MV9leGNoYW5nZV9pZF9hcmdz ICphcmdzLA0KPiAgCQkJICAgICAgIHN0cnVjdCBjb21wb3VuZF9oZHIgKmhkcikNCj4gIHsNCj4g IAlfX2JlMzIgKnA7DQo+IC0JY2hhciBpbXBsX25hbWVbTkZTNF9PUEFRVUVfTElNSVRdOw0KPiAr CWNoYXIgaW1wbF9uYW1lW0lNUExfTkFNRV9MSU1JVF07DQoNCkhtbS4uLiBTaG91bGRuJ3Qgd2Ug YWxzbyBiZSBjaGFuZ2luZyBlbmNvZGVfZXhjaGFuZ2VfaWRfbWF4c3ogdG8gbWlycm9yDQp0aGlz IG5ldyBidWZmZXIgbGltaXQ/DQoNCj4gIAlpbnQgbGVuID0gMDsNCj4gIA0KPiAgCWVuY29kZV9v cF9oZHIoeGRyLCBPUF9FWENIQU5HRV9JRCwgZGVjb2RlX2V4Y2hhbmdlX2lkX21heHN6LCBoZHIp Ow0KPiBAQCAtMTcyNiw3ICsxNzI5LDcgQEAgc3RhdGljIHZvaWQgZW5jb2RlX2V4Y2hhbmdlX2lk KHN0cnVjdCB4ZHJfc3RyZWFtICp4ZHIsDQo+ICAJaWYgKHNlbmRfaW1wbGVtZW50YXRpb25faWQg JiYNCj4gIAkgICAgc2l6ZW9mKENPTkZJR19ORlNfVjRfMV9JTVBMRU1FTlRBVElPTl9JRF9ET01B SU4pID4gMSAmJg0KPiAgCSAgICBzaXplb2YoQ09ORklHX05GU19WNF8xX0lNUExFTUVOVEFUSU9O X0lEX0RPTUFJTikNCj4gLQkJPD0gTkZTNF9PUEFRVUVfTElNSVQgKyAxKQ0KPiArCQk8PSBzaXpl b2YoaW1wbF9uYW1lKSArIDEpDQo+ICAJCWxlbiA9IHNucHJpbnRmKGltcGxfbmFtZSwgc2l6ZW9m KGltcGxfbmFtZSksICIlcyAlcyAlcyAlcyIsDQo+ICAJCQkgICAgICAgdXRzbmFtZSgpLT5zeXNu YW1lLCB1dHNuYW1lKCktPnJlbGVhc2UsDQo+ICAJCQkgICAgICAgdXRzbmFtZSgpLT52ZXJzaW9u LCB1dHNuYW1lKCktPm1hY2hpbmUpOw0KDQotLSANClRyb25kIE15a2xlYnVzdA0KTGludXggTkZT IGNsaWVudCBtYWludGFpbmVyDQoNCk5ldEFwcA0KVHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20N Cnd3dy5uZXRhcHAuY29tDQo=