Return-Path: linux-nfs-owner@vger.kernel.org Received: from countercultured.net ([209.51.175.25]:48932 "HELO countercultured.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752841Ab2KLPEA (ORCPT ); Mon, 12 Nov 2012 10:04:00 -0500 Message-ID: <50A10E53.4080206@davequigley.com> Date: Mon, 12 Nov 2012 09:57:23 -0500 From: Dave Quigley MIME-Version: 1.0 To: "J. Bruce Fields" CC: trond.myklebust@netapp.com, sds@tycho.nsa.gov, linux-nfs@vger.kernel.org, selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org, "Matthew N. Dodd" , Miguel Rodel Felipe , Phua Eu Gene , Khin Mi Mi Aung Subject: Re: [PATCH 05/13] KConfig: Add KConfig entries for Labeled NFS References: <1352700947-3915-1-git-send-email-dpquigl@davequigley.com> <1352700947-3915-6-git-send-email-dpquigl@davequigley.com> <20121112144555.GF30713@fieldses.org> In-Reply-To: <20121112144555.GF30713@fieldses.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-nfs-owner@vger.kernel.org List-ID: On 11/12/2012 9:45 AM, J. Bruce Fields wrote: > On Mon, Nov 12, 2012 at 01:15:39AM -0500, David Quigley wrote: >> From: David Quigley >> >> This patch adds two entries into the fs/KConfig file. The first entry >> NFS_V4_SECURITY_LABEL enables security label support for the NFSv4 client while >> the second entry NFSD_V4_SECURITY_LABEL enables security labeling support on >> the server side. >> >> Signed-off-by: Matthew N. Dodd >> Signed-off-by: Miguel Rodel Felipe >> Signed-off-by: Phua Eu Gene >> Signed-off-by: Khin Mi Mi Aung >> Signed-off-by: David Quigley >> --- >> fs/nfs/Kconfig | 16 ++++++++++++++++ >> fs/nfsd/Kconfig | 13 +++++++++++++ >> 2 files changed, 29 insertions(+) >> >> diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig >> index 13ca196..0077197 100644 >> --- a/fs/nfs/Kconfig >> +++ b/fs/nfs/Kconfig >> @@ -131,6 +131,22 @@ config NFS_V4_1_IMPLEMENTATION_ID_DOMAIN >> If the NFS client is unchanged from the upstream kernel, this >> option should be set to the default "kernel.org". >> >> +config NFS_V4_SECURITY_LABEL >> + bool "Provide Security Label support for NFSv4 client" >> + depends on NFS_V4 && SECURITY >> + help >> + >> + Say Y here if you want enable fine-grained security label attribute >> + support for NFS version 4. Security labels allow security modules like >> + SELinux and Smack to label files to facilitate enforcement of their policies. >> + Without this an NFSv4 mount will have the same label on each file. >> + >> + If you do not wish to enable fine-grained security labels SELinux or >> + Smack policies on NFSv4 files, say N. > > Here and below we also need some warning abouot the current state of > this: we definitely want to warn any distro that might be tempted to > turn this on by default that there's still a chance of > backwards-incompatible protocol changes. > > --b. > Sounds good to me I'll make sure to include that. >> + >> + >> + If unsure, say N. >> + >> config ROOT_NFS >> bool "Root file system on NFS" >> depends on NFS_FS=y && IP_PNP >> diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig >> index 8df1ea4..75ba894 100644 >> --- a/fs/nfsd/Kconfig >> +++ b/fs/nfsd/Kconfig >> @@ -81,6 +81,19 @@ config NFSD_V4 >> >> If unsure, say N. >> >> +config NFSD_V4_SECURITY_LABEL >> + bool "Provide Security Label support for NFSv4 server" >> + depends on NFSD_V4 && SECURITY >> + help >> + >> + Say Y here if you want enable fine-grained security label attribute >> + support for NFS version 4. Security labels allow security modules like >> + SELinux and Smack to label files to facilitate enforcement of their policies. >> + Without this an NFSv4 mount will have the same label on each file. >> + >> + If you do not wish to enable fine-grained security labels SELinux or >> + Smack policies on NFSv4 files, say N. >> + >> config NFSD_FAULT_INJECTION >> bool "NFS server manual fault injection" >> depends on NFSD_V4 && DEBUG_KERNEL >> -- >> 1.7.11.7 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-security-module" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >