Return-Path: linux-nfs-owner@vger.kernel.org Received: from fieldses.org ([174.143.236.118]:48850 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754681Ab3ADVMG (ORCPT ); Fri, 4 Jan 2013 16:12:06 -0500 Date: Fri, 4 Jan 2013 16:12:05 -0500 From: "J. Bruce Fields" To: ycnian@gmail.com Cc: linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH] nfsd: Remove write permission from file content Message-ID: <20130104211204.GA14712@fieldses.org> References: <1357299935-9321-1-git-send-email-ycnian@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1357299935-9321-1-git-send-email-ycnian@gmail.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, Jan 04, 2013 at 07:45:35PM +0800, ycnian@gmail.com wrote: > From: Yanchuan Nian > > The write function doesn't be implemented in file content, and it's meaningless > to write data into this file directly. Remove write permission from it. So does it really matter either way? OK, applying, but I wonder. --b. > > Signed-off-by: Yanchuan Nian > --- > net/sunrpc/cache.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c > index 9afa439..9f84703 100644 > --- a/net/sunrpc/cache.c > +++ b/net/sunrpc/cache.c > @@ -1614,7 +1614,7 @@ static int create_cache_proc_entries(struct cache_detail *cd, struct net *net) > goto out_nomem; > } > if (cd->cache_show) { > - p = proc_create_data("content", S_IFREG|S_IRUSR|S_IWUSR, > + p = proc_create_data("content", S_IFREG|S_IRUSR, > cd->u.procfs.proc_ent, > &content_file_operations_procfs, cd); > cd->u.procfs.content_ent = p; > -- > 1.7.4.4 >