Return-Path: linux-nfs-owner@vger.kernel.org Received: from ironport2-out.teksavvy.com ([206.248.154.182]:31872 "EHLO ironport2-out.teksavvy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752076Ab3AQXk0 (ORCPT ); Thu, 17 Jan 2013 18:40:26 -0500 Message-ID: <50F88BE7.80800@teksavvy.com> Date: Thu, 17 Jan 2013 18:40:23 -0500 From: Mark Lord MIME-Version: 1.0 To: "J. Bruce Fields" CC: linux-nfs@vger.kernel.org, Linux Kernel Subject: Re: BUG at net/sunrpc/svc_xprt.c:921 References: <50F42F85.50907@teksavvy.com> <50F7F898.5050605@teksavvy.com> <20130117135333.GF6598@fieldses.org> In-Reply-To: <20130117135333.GF6598@fieldses.org> Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 13-01-17 08:53 AM, J. Bruce Fields wrote: > On Thu, Jan 17, 2013 at 08:11:52AM -0500, Mark Lord wrote: >> On 13-01-14 11:17 AM, Mark Lord wrote: >>> >>> Here's the code with the BUG() at net/sunrpc/svc_xprt.c line 921: >>> >>> /* >>> * Remove a dead transport >>> */ >>> static void svc_delete_xprt(struct svc_xprt *xprt) >>> { >>> struct svc_serv *serv = xprt->xpt_server; >>> struct svc_deferred_req *dr; >>> >>> /* Only do this once */ >>> if (test_and_set_bit(XPT_DEAD, &xprt->xpt_flags)) >>> BUG(); >> >> >> Shouldn't there also be a return statement after the BUG() line, >> inside the if-stmt ? > > BUG() kills the thread that calls it Oh, does it? Well, taken care of then, I guess. With a sledgehammer. :)