Return-Path: linux-nfs-owner@vger.kernel.org Received: from zeniv.linux.org.uk ([195.92.253.2]:60372 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757136Ab3BVWPI (ORCPT ); Fri, 22 Feb 2013 17:15:08 -0500 Date: Fri, 22 Feb 2013 22:15:06 +0000 From: Al Viro To: "J. Bruce Fields" Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH] nfsd: handle vfs_getattr errors in acl protocol Message-ID: <20130222221506.GM4503@ZenIV.linux.org.uk> References: <20130201131537.GC30668@fieldses.org> <20130201185721.GP4503@ZenIV.linux.org.uk> <20130201201304.GE30668@fieldses.org> <20130222214634.GB30856@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20130222214634.GB30856@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, Feb 22, 2013 at 04:46:34PM -0500, J. Bruce Fields wrote: > > Actually, we have precisely the same interface except for the name: > > > > __be32 fh_getattr(struct svc_fh *fh, struct kstat *stat) > > vs. > > __be32 nfsd_getattr(struct svc_fh *fh, struct kstat *stat) > > > > but I'm fine with your name. > > > > Do you want to take these patches, or should I? *blink* I blame being very low on caffeine; that, or being a blind idiot... My apologies ;-/ > I guess what I'll do unless I hear otherwise is apply both your patch > and mine to my tree for 3.9. FWIW, I'm going to push the first part of VFS queue later tonight...