Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:62333 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932993Ab3BSPk5 (ORCPT ); Tue, 19 Feb 2013 10:40:57 -0500 Message-ID: <51239CFF.9000600@RedHat.com> Date: Tue, 19 Feb 2013 10:40:47 -0500 From: Steve Dickson MIME-Version: 1.0 To: "J. Bruce Fields" CC: Trond Myklebust , "J. Bruce Fields" , "David P. Quigley" , Linux NFS list , Linux FS devel list , Linux Security List , SELinux List Subject: Re: [PATCH 00/14] lnfs: 3.8-rc7 release References: <1361213276-17962-1-git-send-email-SteveD@redhat.com> <20130218195834.GA3391@fieldses.org> <512395D7.5010205@RedHat.com> <20130219151808.GE3391@fieldses.org> In-Reply-To: <20130219151808.GE3391@fieldses.org> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 19/02/13 10:18, J. Bruce Fields wrote: > On Tue, Feb 19, 2013 at 10:10:15AM -0500, Steve Dickson wrote: >> >> >> On 18/02/13 14:58, J. Bruce Fields wrote: >>> On Mon, Feb 18, 2013 at 01:47:42PM -0500, Steve Dickson wrote: >>>>> From: Steve Dickson >>>>> >>>>> Here is the next release of the Label NFS patches, forward >>>>> ported to linux-3.8-rc7 >>>>> >>>>> I believe I've incorporated all code review that were made >>>>> from the last release, >>> Except I think this doesn't turn on minor version 2? >> Are you saying we need a -o v4.2 mount option to enable this feature? > > Yes. And the client needs to send requests with minor version 2, and > server needs to accept such requests. Boy this puts a damper on the party.... ;-) I'll assume the negotiation should be similar to how v4.1 is done. > >>> Also: did you figure out why NFSv4 wasn't working when the labeled NFS >>> support is configured out? >> I'll look into this but this was not the case the last time I checked... > > Let me know how I can help reproduce the problem. All I did was: > > - build a kernel with CONFIG_NFS_V4_SECURITY_LABEL and > CONFIG_NFSD_V4_SECURITY_LABEL both off. > - attempt a v4 mount between client and server both running that > kernel. I thought I had done this testing at one point... hmmm... Thanks for the cycles! steved