Return-Path: linux-nfs-owner@vger.kernel.org Received: from fieldses.org ([174.143.236.118]:56337 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932801Ab3CYV1h (ORCPT ); Mon, 25 Mar 2013 17:27:37 -0400 Date: Mon, 25 Mar 2013 17:27:36 -0400 From: "J. Bruce Fields" To: Steve Dickson Cc: Linux NFS Mailing list Subject: Re: [PATCH] mountd: regression in crossmounts Message-ID: <20130325212736.GC10887@fieldses.org> References: <1364049149-3751-1-git-send-email-steved@redhat.com> <20130325181314.GA10120@fieldses.org> <5150B1FD.1070405@RedHat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <5150B1FD.1070405@RedHat.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, Mar 25, 2013 at 04:22:21PM -0400, Steve Dickson wrote: > > > On 25/03/13 14:13, J. Bruce Fields wrote: > > On Sat, Mar 23, 2013 at 10:32:29AM -0400, Steve Dickson wrote: > >> commit 8e2fb3fc cause a regression in mount export > >> that are on different local file system. > >> Exports like (all on different filesystems) > >> > >> /home *(rw,fsid=0,crossmnt) > >> /home/fs1 *(rw,crossmnt) > >> /home/fs1/fs2/fs3 *(rw,nohide) > >> > >> and then a mount of the root 'mount /home /mnt' > >> would end up mounting /home/fs1/fs2/fs3 not /home > > > > That's strange. > Yeah... I had this guy reporting from day one that the > latest nfs-utils broke his export world... > > > > >> Reverting the logic of commit 8e2fb3fc until > >> a better solution can be found for the original > >> problem. > > > > I can't figure out why the patch below would help. The only change I > > can see is to the way that an export of "/" would be handled. > The reason I didn't debug this further was I did not know how to > reproduce the original problem the patch was trying to fix... Could you remind me where the bug report for this is? The patch reverted here seems obviously correct to me, so I'm concerned. --b.