Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx12.netapp.com ([216.240.18.77]:47795 "EHLO mx12.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753152Ab3CSOQV convert rfc822-to-8bit (ORCPT ); Tue, 19 Mar 2013 10:16:21 -0400 From: "Myklebust, Trond" To: "J. Bruce Fields" CC: "linux-nfs@vger.kernel.org" Subject: Re: [PATCH 10/11] NFSv4.1: Enable open-by-filehandle Date: Tue, 19 Mar 2013 14:16:15 +0000 Message-ID: <1363702570.7515.6.camel@leira.trondhjem.org> References: <1363698463-3681-1-git-send-email-Trond.Myklebust@netapp.com> <1363698463-3681-2-git-send-email-Trond.Myklebust@netapp.com> <1363698463-3681-3-git-send-email-Trond.Myklebust@netapp.com> <1363698463-3681-4-git-send-email-Trond.Myklebust@netapp.com> <1363698463-3681-5-git-send-email-Trond.Myklebust@netapp.com> <1363698463-3681-6-git-send-email-Trond.Myklebust@netapp.com> <1363698463-3681-7-git-send-email-Trond.Myklebust@netapp.com> <1363698463-3681-8-git-send-email-Trond.Myklebust@netapp.com> <1363698463-3681-9-git-send-email-Trond.Myklebust@netapp.com> <1363698463-3681-10-git-send-email-Trond.Myklebust@netapp.com> <20130319140901.GB7912@fieldses.org> In-Reply-To: <20130319140901.GB7912@fieldses.org> Content-Type: text/plain; charset=US-ASCII MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, 2013-03-19 at 10:09 -0400, J. Bruce Fields wrote: > On Tue, Mar 19, 2013 at 09:07:42AM -0400, Trond Myklebust wrote: > > Sometimes, we actually _want_ to do open-by-filehandle, for instance > > when recovering opens after a network partition, or when called > > from nfs4_file_open. > > Enable that functionality using a new capability NFS_CAP_ATOMIC_OPEN_V1, > > and which is only enabled for NFSv4.1 servers that support it. > > So you're assuming NFS4ERR_INVAL is how the server indicates lack of > support? Looking at the list of valid errors for OPEN in section 15.2 of RFC5661, I don't see what else fits the bill. > Looking back at NFS server history.... I think that's what it did before > supporting these types, but I wonder if that was really right. Possibly > it's just a bug not to support the new claim types in a 4.1 server. I've assumed that it isn't. NFSv4.1 is the very first minor version, so it's not supposed to contain any mandatory new features. Yes, I know we broke the rules on that one in spectacular fashion with sessions, but I'm assuming that is the only exception... -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com