Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:53016 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755102Ab3CVTPG (ORCPT ); Fri, 22 Mar 2013 15:15:06 -0400 Date: Fri, 22 Mar 2013 12:14:56 -0700 From: Zach Brown To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, "J. Bruce Fields" , Al Viro , "Eric W. Biederman" Subject: Re: [PATCH] nfsd: fix bad offset use Message-ID: <20130322191456.GU10038@lenny.home.zabbo.net> References: <1363976304-26093-1-git-send-email-koverstreet@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1363976304-26093-1-git-send-email-koverstreet@google.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, Mar 22, 2013 at 11:18:24AM -0700, Kent Overstreet wrote: > vfs_writev() updates the offset argument - but the code then passes the > offset to vfs_fsync_range(). Since offset now points to the offset after > what was just written, this is probably not what was intended Agreed, the original code does look fishy and this fix right to me. Reviewed-by: Zach Brown - z