Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:41966 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752479Ab3CKSfM (ORCPT ); Mon, 11 Mar 2013 14:35:12 -0400 Date: Mon, 11 Mar 2013 14:35:07 -0400 From: Jeff Layton To: Pavel Shilovsky Cc: linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, wine-devel@winehq.org, sprabhu@redhat.com Subject: Re: [PATCH v3 5/7] CIFS: Translate SHARING_VIOLATION to -ETXTBSY error code for SMB2 Message-ID: <20130311143507.737f2ab0@corrin.poochiereds.net> In-Reply-To: <1362065133-9490-6-git-send-email-piastry@etersoft.ru> References: <1362065133-9490-1-git-send-email-piastry@etersoft.ru> <1362065133-9490-6-git-send-email-piastry@etersoft.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, 28 Feb 2013 19:25:31 +0400 Pavel Shilovsky wrote: > to make it match CIFS and VFS variants. > > Signed-off-by: Pavel Shilovsky > --- > fs/cifs/smb2maperror.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/cifs/smb2maperror.c b/fs/cifs/smb2maperror.c > index 494c912..11e589e 100644 > --- a/fs/cifs/smb2maperror.c > +++ b/fs/cifs/smb2maperror.c > @@ -356,7 +356,7 @@ static const struct status_to_posix_error smb2_error_map_table[] = { > {STATUS_PORT_CONNECTION_REFUSED, -ECONNREFUSED, > "STATUS_PORT_CONNECTION_REFUSED"}, > {STATUS_INVALID_PORT_HANDLE, -EIO, "STATUS_INVALID_PORT_HANDLE"}, > - {STATUS_SHARING_VIOLATION, -EBUSY, "STATUS_SHARING_VIOLATION"}, > + {STATUS_SHARING_VIOLATION, -ETXTBSY, "STATUS_SHARING_VIOLATION"}, > {STATUS_QUOTA_EXCEEDED, -EDQUOT, "STATUS_QUOTA_EXCEEDED"}, > {STATUS_INVALID_PAGE_PROTECTION, -EIO, > "STATUS_INVALID_PAGE_PROTECTION"}, Actually, I think Sachin is converting the CIFS STATUS_SHARING_VIOLATION to translate to EBUSY, since that seems to better reflect the situation. I'd suggest dropping this patch, unless you have a specific need for this error return here. -- Jeff Layton