Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-oa0-f46.google.com ([209.85.219.46]:53789 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751742Ab3CFFIF (ORCPT ); Wed, 6 Mar 2013 00:08:05 -0500 Received: by mail-oa0-f46.google.com with SMTP id k1so12064645oag.5 for ; Tue, 05 Mar 2013 21:08:04 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20130301003038.GA26533@redhat.com> Date: Tue, 5 Mar 2013 21:08:03 -0800 Message-ID: Subject: Re: lockdep trace from nfsd From: Mandeep Baines To: Yinghai Lu Cc: Dave Jones , Linux Kernel , Bruce Fields , "linux-nfs@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, Mar 1, 2013 at 4:08 PM, Yinghai Lu wrote: > On Thu, Feb 28, 2013 at 4:30 PM, Dave Jones wrote: >> [ 39.878535] ===================================== >> [ 39.879670] [ BUG: rpc.nfsd/666 still has locks held! ] >> [ 39.880871] 3.8.0+ #3 Not tainted >> [ 39.881858] ------------------------------------- >> [ 39.882850] 2 locks on stack by rpc.nfsd/666: >> [ 39.883868] #0: held: (nfsd_mutex){+.+.+.}, instance: ffffffffa01cf0b8, at: [] write_ports+0x37/0x7a0 [nfsd] >> [ 39.884750] #1: held: (rpcb_create_local_mutex){+.+.+.}, instance: ffffffffa016d878, at: [] rpcb_create_local+0x46/0x90 [sunrpc] >> [ 39.885903] >> stack backtrace: >> [ 39.897044] Pid: 666, comm: rpc.nfsd Not tainted 3.8.0+ #3 >> [ 39.898186] Call Trace: >> [ 39.900755] [] debug_check_no_locks_held+0x9a/0xa0 >> [ 39.901823] [] rpc_wait_bit_killable+0x85/0xb0 [sunrpc] >> [ 39.902866] [] __wait_on_bit+0x60/0x90 >> [ 39.903879] [] ? __rpc_execute+0x170/0x5a0 [sunrpc] >> [ 39.904900] [] ? __rpc_wait_for_completion_task+0x30/0x30 [sunrpc] >> [ 39.905969] [] out_of_line_wait_on_bit+0x7c/0x90 >> [ 39.907010] [] ? __rpc_execute+0x170/0x5a0 [sunrpc] >> [ 39.908070] [] ? autoremove_wake_function+0x50/0x50 >> [ 39.909124] [] ? call_connect+0xa0/0xa0 [sunrpc] >> [ 39.910154] [] __rpc_execute+0x1a1/0x5a0 [sunrpc] >> [ 39.911176] [] ? wake_up_bit+0x2e/0x40 >> [ 39.912058] [] rpc_execute+0x59/0x180 [sunrpc] >> [ 39.912745] [] rpc_run_task+0x70/0x90 [sunrpc] >> [ 39.913446] [] rpc_call_sync+0x43/0xa0 [sunrpc] >> [ 39.914280] [] rpc_ping+0x52/0x70 [sunrpc] >> [ 39.914992] [] rpc_create+0x188/0x230 [sunrpc] >> [ 39.915735] [] ? sched_clock+0x9/0x10 >> [ 39.916577] [] ? put_lock_stats.isra.25+0xe/0x40 >> [ 39.917635] [] ? lock_release_holdtime.part.26+0xcc/0x140 >> [ 39.918667] [] rpcb_create_local_unix+0x5c/0xe0 [sunrpc] >> [ 39.919669] [] rpcb_create_local+0x78/0x90 [sunrpc] >> [ 39.920705] [] svc_rpcb_setup+0x23/0x50 [sunrpc] >> [ 39.921725] [] svc_bind+0x34/0x50 [sunrpc] >> [ 39.921733] [] nfsd_create_serv+0x1cd/0x320 [nfsd] >> [ 39.921738] [] ? nfsd_create_serv+0x5/0x320 [nfsd] >> [ 39.921742] [] write_ports+0x52a/0x7a0 [nfsd] >> [ 39.921746] [] ? write_ports+0x418/0x7a0 [nfsd] >> [ 39.921750] [] ? _raw_spin_unlock+0x35/0x60 >> [ 39.921754] [] ? simple_transaction_get+0xca/0xe0 >> [ 39.921759] [] ? write_maxblksize+0x2e0/0x2e0 [nfsd] >> [ 39.921764] [] nfsctl_transaction_write+0x57/0x90 [nfsd] >> [ 39.921768] [] vfs_write+0xaf/0x190 >> [ 39.921771] [] sys_write+0x55/0xa0 >> [ 39.921775] [] system_call_fastpath+0x16/0x1b >> > > > when try to mount nfs dir, got > > [ 1341.534971] INFO: trying to register non-static key. > [ 1341.535279] the code is fine but needs lockdep annotation. > [ 1341.535599] turning off the locking correctness validator. > [ 1341.548353] Pid: 15681, comm: mount.nfs Not tainted > 3.8.0-yh-07300-gdae94c7-dirty #1287 > [ 1341.568229] Call Trace: > [ 1341.568356] [] __lock_acquire+0x37d/0xc90 > [ 1341.568673] [] ? trace_hardirqs_off_caller+0x28/0x160 > [ 1341.588437] [] ? native_sched_clock+0x35/0x80 > [ 1341.608187] [] lock_acquire+0xaa/0x130 > [ 1341.608460] [] ? flush_work+0x5/0x270 > [ 1341.628195] [] flush_work+0x4c/0x270 > [ 1341.628468] [] ? flush_work+0x5/0x270 > [ 1341.628729] [] ? flush_work+0x68/0x270 > [ 1341.648425] [] ? flush_work+0x5/0x270 > [ 1341.648696] [] ? mark_held_locks+0x123/0x140 > [ 1341.668484] [] ? __cancel_work_timer+0x9d/0xe0 > [ 1341.688225] [] __cancel_work_timer+0xb0/0xe0 > [ 1341.688515] [] cancel_delayed_work_sync+0x13/0x20 > [ 1341.708312] [] xs_destroy+0x3f/0x90 > [ 1341.708587] [] xprt_destroy+0x8e/0xa0 > [ 1341.728280] [] xprt_put+0x18/0x20 > [ 1341.728540] [] rpc_free_client+0x164/0x180 > [ 1341.748282] [] ? rpc_free_client+0x91/0x180 > [ 1341.748667] [] rpc_release_client+0x74/0xb0 > [ 1341.768339] [] rpc_shutdown_client+0x141/0x150 > [ 1341.768706] [] ? rpc_ping+0x5d/0x70 > [ 1341.788331] [] rpc_create+0x150/0x200 > [ 1341.788710] [] ? rpcb_get_local+0xbf/0xd0 > [ 1341.808378] [] rpcb_create_local_unix+0x5c/0xf0 > [ 1341.808792] [] rpcb_create_local+0x50/0x80 > [ 1341.828434] [] svc_rpcb_setup+0x23/0x50 > [ 1341.828791] [] svc_bind+0x34/0x50 > [ 1341.848377] [] lockd_up+0x152/0x360 > [ 1341.848698] [] ? lockd_up+0xc8/0x360 > [ 1341.874014] [] ? nfs_init_client+0x5b/0xb0 > [ 1341.874415] [] nlmclnt_init+0x27/0x80 > [ 1341.890014] [] nfs_start_lockd+0xa3/0xd0 > [ 1341.890364] [] nfs_create_server+0x288/0x520 > [ 1341.908405] [] nfs3_create_server+0xe/0x30 > [ 1341.908779] [] nfs_try_mount+0x59/0x90 > [ 1341.928405] [] nfs_fs_mount+0xacc/0xb40 > [ 1341.928770] [] ? nfs_clone_super+0x140/0x140 > [ 1341.948439] [] ? nfs_sb_active+0x30/0x30 > [ 1341.948843] [] mount_fs+0x20/0xf0 > [ 1341.968413] [] vfs_kern_mount+0x76/0x100 > [ 1341.968747] [] do_mount+0x810/0x9e0 > [ 1341.988421] [] ? copy_mount_options+0x3a/0x170 > [ 1341.988824] [] sys_mount+0x9c/0xe0 > [ 1342.008444] [] system_call_fastpath+0x16/0x1b > > > so that is same problem ? No. This is different. This is lockdep verifying that the lock class key is statically allocated. Apparently its not in this case. Regards, Mandeep > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/