Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-qc0-f173.google.com ([209.85.216.173]:33186 "EHLO mail-qc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751354Ab3CFVgn (ORCPT ); Wed, 6 Mar 2013 16:36:43 -0500 Date: Wed, 6 Mar 2013 13:36:36 -0800 From: Tejun Heo To: Linus Torvalds Cc: Oleg Nesterov , Jeff Layton , "Myklebust, Trond" , Mandeep Singh Baines , Ming Lei , "J. Bruce Fields" , Linux Kernel Mailing List , "linux-nfs@vger.kernel.org" , "Rafael J. Wysocki" , Andrew Morton , Ingo Molnar , Al Viro Subject: Re: LOCKDEP: 3.9-rc1: mount.nfs/4272 still has locks held! Message-ID: <20130306213636.GP1227@htj.dyndns.org> References: <20130305174954.GG12795@htj.dyndns.org> <20130305140312.243cb094@tlielax.poochiereds.net> <20130305190923.GI12795@htj.dyndns.org> <20130305183941.19ff39ce@tlielax.poochiereds.net> <20130305234700.GE1227@htj.dyndns.org> <20130306181608.GA18687@redhat.com> <20130306185304.GM1227@htj.dyndns.org> <20130306212452.GO1227@htj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, Mar 06, 2013 at 01:31:10PM -0800, Linus Torvalds wrote: > So I do agree that we probably have *too* many of the stupid "let's > check if we can freeze", and I suspect that the NFS code should get > rid of the "freezable_schedule()" that is causing this warning > (because I also agree that you should *not* freeze while holding > locks, because it really can cause deadlocks), but I do suspect that > network filesystems do need to have a few places where they check for > freezing on their own... Exactly because freezing isn't *quite* like a > signal. Well, I don't really know much about nfs so I can't really tell, but for most other cases, dealing with freezing like a signal should work fine from what I've seen although I can't be sure before actually trying. Trond, Bruce, can you guys please chime in? Thanks. -- tejun