Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:45869 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761319Ab3DBTLI (ORCPT ); Tue, 2 Apr 2013 15:11:08 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r32JB8Bm024410 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 2 Apr 2013 15:11:08 -0400 Message-ID: <515B2D50.1000508@RedHat.com> Date: Tue, 02 Apr 2013 15:11:12 -0400 From: Steve Dickson MIME-Version: 1.0 To: Simo Sorce CC: Linux NFS Mailing list Subject: Re: [PATCH 1/3] Fix segfault when using -R option References: <1364924947-16985-1-git-send-email-simo@redhat.com> <1364924947-16985-2-git-send-email-simo@redhat.com> In-Reply-To: <1364924947-16985-2-git-send-email-simo@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 02/04/13 13:49, Simo Sorce wrote: > The getopt string did not add : after the R option resulting in a sefgault > whenever -R was used as optarg is NULL and it is dereferenced. > > Signed-off-by: Simo Sorce committed... steved. > --- > utils/gssd/gssd.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/utils/gssd/gssd.c b/utils/gssd/gssd.c > index 0be251781bacaa562270f773341126bc95ca6b45..07b1e52e6b84e9bcba96e7a63b0505ca7823482a 100644 > --- a/utils/gssd/gssd.c > +++ b/utils/gssd/gssd.c > @@ -102,7 +102,7 @@ main(int argc, char *argv[]) > char *progname; > > memset(ccachesearch, 0, sizeof(ccachesearch)); > - while ((opt = getopt(argc, argv, "fvrlmnMp:k:d:t:R")) != -1) { > + while ((opt = getopt(argc, argv, "fvrlmnMp:k:d:t:R:")) != -1) { > switch (opt) { > case 'f': > fg = 1; >