Message-ID: <5176E3BB.4020508@RedHat.com>
Date: Tue, 23 Apr 2013 15:40:43 -0400
From: Steve Dickson <SteveD@redhat.com>
MIME-Version: 1.0
To: "J. Bruce Fields" <bfields@redhat.com>
CC: Trond Myklebust <Trond.Myklebust@netapp.com>,
        "David P. Quigley" <dpquigl@tycho.nsa.gov>,
        Linux NFS list <linux-nfs@vger.kernel.org>,
        Linux FS devel list <linux-fsdevel@vger.kernel.org>,
        Linux Security List <linux-security-module@vger.kernel.org>,
        SELinux List <selinux@tycho.nsa.gov>
Subject: Re: [PATCH 13/19] NFSD: Server implementation of MAC Labeling
References: <1364939160-20874-1-git-send-email-SteveD@redhat.com> <1364939160-20874-14-git-send-email-SteveD@redhat.com> <20130410151953.GC24404@pad.fieldses.org>
In-Reply-To: <20130410151953.GC24404@pad.fieldses.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-nfs-owner@vger.kernel.org


On 10/04/13 11:19, J. Bruce Fields wrote:
> On Tue, Apr 02, 2013 at 05:45:54PM -0400, Steve Dickson wrote:
>> +__be32 nfsd4_set_nfs4_label(struct svc_rqst *rqstp, struct svc_fh *fhp,
>> +		struct nfs4_label *label)
>> +{
>> +	return -EOPNOTSUPP;
> 
> Anything that returns a __be32 is expecting nfserr_something, not
> -ERRNO.
> 
I think it makes sense when label are not configured for this to
return nfserr_notsupp which will then get turned into a -EOPNOTSUPP, 
agreed?
 
steved.