Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-ie0-f173.google.com ([209.85.223.173]:59001 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757955Ab3DYW0Y (ORCPT ); Thu, 25 Apr 2013 18:26:24 -0400 MIME-Version: 1.0 In-Reply-To: References: <0EE9A1CDC8D6434DB00095CD7DB873462CF96C65@MTLDAG01.mtl.com> <62745258-4F3B-4C05-BFFD-03EA604576E4@ornl.gov> <0EE9A1CDC8D6434DB00095CD7DB873462CF9715B@MTLDAG01.mtl.com> <20130423210607.GJ3676@fieldses.org> <0EE9A1CDC8D6434DB00095CD7DB873462CF988C9@MTLDAG01.mtl.com> <20130424150540.GB20275@fieldses.org> <20130424152631.GC20275@fieldses.org> <517823E0.4000402@talpey.com> <51798C51.50209@talpey.com> <51799D52.1040903@opengridcomputing.com> Date: Thu, 25 Apr 2013 15:26:24 -0700 Message-ID: Subject: Re: NFS over RDMA benchmark From: Wendy Cheng To: Tom Tucker Cc: Tom Talpey , "J. Bruce Fields" , Yan Burman , "Atchley, Scott" , "linux-rdma@vger.kernel.org" , "linux-nfs@vger.kernel.org" , Or Gerlitz Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, Apr 25, 2013 at 2:58 PM, Wendy Cheng wrote: > On Thu, Apr 25, 2013 at 2:17 PM, Tom Tucker wrote: >> The Mellanox driver uses red-black trees extensively for resource >> management, e.g. QP ID, CQ ID, etc... When completions come in from the HW, >> these are used to find the associated software data structures I believe. It >> is certainly possible that these trees get hot on lookup when we're pushing >> a lot of data. I'm surprised, however, to see rb_insert_color there because >> I'm not aware of any where that resources are being inserted into and/or >> removed from a red-black tree in the data path. >> > > I think they (rb calls) are from base kernel, not from any NFS and/or > IB module (e.g. RPC, MLX, etc). See the right column ? .... it says > "/root/vmlinux". Just a guess - I don't know much about this "perf" > command. > Oops .. take my words back ! I confused Linux's RB tree w/ BSD's. BSD's is a set of macros inside a header file while Linux's implementation is a base kernel library. So every KMOD is a suspect here :) -- Wendy