Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx12.netapp.com ([216.240.18.77]:42214 "EHLO mx12.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757923Ab3ENSVN convert rfc822-to-8bit (ORCPT ); Tue, 14 May 2013 14:21:13 -0400 From: "Adamson, Dros" To: Chuck Lever CC: "" , "" Subject: Re: [PATCH] NFS: Fix security flavor negotiation with legacy binary mounts Date: Tue, 14 May 2013 18:21:11 +0000 Message-ID: References: <20130514142620.37841.9591.stgit@seurat.1015granger.net> In-Reply-To: <20130514142620.37841.9591.stgit@seurat.1015granger.net> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: Acked-by: Weston Andros Adamson -dros On May 14, 2013, at 10:26 AM, Chuck Lever wrote: > Commit 4580a92d44 "NFS: Use server-recommended security flavor by > default (NFSv3)" introduced a behavior regression for NFS mounts > done via a legacy binary mount(2) call. > > Darrick J. Wong reports: > >> I have a kvm-based testing setup that netboots VMs over NFS, the >> client end of which seems to have broken somehow in 3.10-rc1. The >> server's exports file looks like this: >> >> /storage/mtr/x64 192.168.122.0/24(ro,sync,no_root_squash,no_subtree_check) >> >> On the client end (inside the VM), the initrd runs the following >> command to try to mount the rootfs over NFS: >> >> # mount -o nolock -o ro -o retrans=10 192.168.122.1:/storage/mtr/x64/ /root >> >> (Note: This is the busybox mount command.) >> >> The mount fails with -EINVAL. > > Ensure that a default security flavor is specified for legacy binary > mounts, since they do not invoke nfs_select_flavor() in the kernel. > > Reported-by: Darrick J. Wong > Signed-off-by: Chuck Lever > --- > fs/nfs/super.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/nfs/super.c b/fs/nfs/super.c > index a366107..2d7525f 100644 > --- a/fs/nfs/super.c > +++ b/fs/nfs/super.c > @@ -1942,6 +1942,7 @@ static int nfs23_validate_mount_data(void *options, > args->namlen = data->namlen; > args->bsize = data->bsize; > > + args->auth_flavors[0] = RPC_AUTH_UNIX; > if (data->flags & NFS_MOUNT_SECFLAVOUR) > args->auth_flavors[0] = data->pseudoflavor; > if (!args->nfs_server.hostname) > @@ -2637,6 +2638,7 @@ static int nfs4_validate_mount_data(void *options, > goto out_no_address; > args->nfs_server.port = ntohs(((struct sockaddr_in *)sap)->sin_port); > > + args->auth_flavors[0] = RPC_AUTH_UNIX; > if (data->auth_flavourlen) { > if (data->auth_flavourlen > 1) > goto out_inval_auth; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html