Return-Path: linux-nfs-owner@vger.kernel.org Received: from elasmtp-dupuy.atl.sa.earthlink.net ([209.86.89.62]:50416 "EHLO elasmtp-dupuy.atl.sa.earthlink.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755141Ab3FKVBF (ORCPT ); Tue, 11 Jun 2013 17:01:05 -0400 Message-ID: <51B7900D.7090704@mindspring.com> Date: Tue, 11 Jun 2013 14:01:01 -0700 From: Frank Filz MIME-Version: 1.0 To: "J. Bruce Fields" CC: Frank Filz , Linux NFS Mailing list , "J. Bruce Fields" , ffilz@us.ibm.com Subject: Re: Some pynfs updates References: <51B75979.5070300@mindspring.com> <20130611200610.GB29634@fieldses.org> <51B78716.30703@mindspring.com> <20130611202803.GC29634@fieldses.org> In-Reply-To: <20130611202803.GC29634@fieldses.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-nfs-owner@vger.kernel.org List-ID: On 06/11/2013 01:28 PM, J. Bruce Fields wrote: > On Tue, Jun 11, 2013 at 01:22:46PM -0700, Frank Filz wrote: >> On 06/11/2013 01:06 PM, J. Bruce Fields wrote: >>> On Tue, Jun 11, 2013 at 10:08:09AM -0700, Frank Filz wrote: >>>> Please pull this branch from github: >>>> https://github.com/ffilz/pynfs/commits/master >>> >>> Thanks, applied (actually from git://github.com/ffilz/pynfs.git master). >>> >>>> commit a6548ab80a68787dc3fcb5c8531d4d189d77c3a9 >>>> Author: Frank S. Filz >>>> Date: Wed May 1 16:06:56 2013 -0700 >>>> >>>> Make mode 000 tests expect NFS4_OK when run as root >>>> >>>> They will warn if NFS4ERR_ACCESS is returned. >>> >>> ... though I'm not sure about this one. root-squashing is completely >>> normal, I'm not convinced it merits a warning. >> >> Oh, didn't think about that, good point. Would you like me to submit >> a patch to make it an acceptable return? > > In the uid=0 case, yes, I think that's best. If you want to pull again, I just added a new patch to do so. Tested the mode000 tests with root, squashed and not, and with a non-root user. Pass in all cases against Ganesha. Frank