Return-Path: linux-nfs-owner@vger.kernel.org Received: from trent.utfs.org ([94.185.90.103]:33907 "EHLO trent.utfs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755294Ab3HXWWM (ORCPT ); Sat, 24 Aug 2013 18:22:12 -0400 Date: Sat, 24 Aug 2013 15:21:56 -0700 (PDT) From: Christian Kujau To: Dave Kleikamp cc: Karl Schmidt , Jonathan McDowell , jfs-discussion@lists.sourceforge.net, "J. Bruce Fields" , Ben Hutchings , linux-nfs@vger.kernel.org Subject: Re: [Jfs-discussion] [PATCH] jfs: fix readdir cookie incompatibility with NFSv4 In-Reply-To: <520D3EA7.1010109@oracle.com> Message-ID: References: <1373245980.3428.46.camel@deadeye.wl.decadent.org.uk> <520554A5.3060401@xtronics.com> <20130812162924.GB2395@fieldses.org> <520C50F7.3010209@oracle.com> <520D3EA7.1010109@oracle.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, 15 Aug 2013 at 15:48, Dave Kleikamp wrote: > This patch replaces the one I posted yesterday. I like this better since > it doesn't require fixing existing on-disk cookies or skipping a > position in the in-inode index table. > > NFSv4 reserves readdir cookie values 0-2 for special entries (. and ..), > but jfs allows a value of 2 for a non-special entry. This incompatibility > can result in the nfs client reporting a readdir loop. > > This patch doesn't change the value stored internally, but adds one to > the value exposed to the iterate method. Out of curiosity, will this land on 3.11? Christian. -- BOFH excuse #102: Power company testing new voltage spike (creation) equipment