Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx12.netapp.com ([216.240.18.77]:39842 "EHLO mx12.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759161Ab3HMVBb (ORCPT ); Tue, 13 Aug 2013 17:01:31 -0400 From: "Myklebust, Trond" To: "Adamson, Dros" CC: "" Subject: Re: [PATCH 02/10] NFS: refactor code for calculating the crc32 hash of a filehandle Date: Tue, 13 Aug 2013 21:01:30 +0000 Message-ID: <1376427689.58367.4.camel@leira.trondhjem.org> References: <1376418952-12481-1-git-send-email-Trond.Myklebust@netapp.com> <1376418952-12481-2-git-send-email-Trond.Myklebust@netapp.com> <60B814F0-8EED-466E-B06E-4EAB9809B541@netapp.com> In-Reply-To: <60B814F0-8EED-466E-B06E-4EAB9809B541@netapp.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gVHVlLCAyMDEzLTA4LTEzIGF0IDE5OjUyICswMDAwLCBBZGFtc29uLCBEcm9zIHdyb3RlOg0K PiBJIHRoaW5rIEkgd2FzIHRoZSBsYXN0IG9uZSB0byB0b3VjaCB0aGlzLg0KPiANCj4gT24gQXVn IDEzLCAyMDEzLCBhdCAyOjM1IFBNLCBUcm9uZCBNeWtsZWJ1c3QgPFRyb25kLk15a2xlYnVzdEBu ZXRhcHAuY29tPiB3cm90ZToNCj4gDQo+ID4gV2Ugd2FudCB0byBiZSBhYmxlIHRvIGRpc3BsYXkg dGhlIGNyYzMyIGhhc2ggb2YgdGhlIGZpbGVoYW5kbGUgaW4NCj4gPiB0cmFjZXBvaW50cy4NCj4g PiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBUcm9uZCBNeWtsZWJ1c3QgPFRyb25kLk15a2xlYnVzdEBu ZXRhcHAuY29tPg0KPiA+IC0tLQ0KPiA+IGZzL25mcy9pbm9kZS5jICAgIHwgIDMgKy0tDQo+ID4g ZnMvbmZzL2ludGVybmFsLmggfCAyMCArKysrKysrKysrKysrKysrKysrKw0KPiA+IDIgZmlsZXMg Y2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4gPiANCj4gPiBkaWZm IC0tZ2l0IGEvZnMvbmZzL2lub2RlLmMgYi9mcy9uZnMvaW5vZGUuYw0KPiA+IGluZGV4IGFmNmU4 MDYuLjlhOThiMDQgMTAwNjQ0DQo+ID4gLS0tIGEvZnMvbmZzL2lub2RlLmMNCj4gPiArKysgYi9m cy9uZnMvaW5vZGUuYw0KPiA+IEBAIC0zOCw3ICszOCw2IEBADQo+ID4gI2luY2x1ZGUgPGxpbnV4 L3NsYWIuaD4NCj4gPiAjaW5jbHVkZSA8bGludXgvY29tcGF0Lmg+DQo+ID4gI2luY2x1ZGUgPGxp bnV4L2ZyZWV6ZXIuaD4NCj4gPiAtI2luY2x1ZGUgPGxpbnV4L2NyYzMyLmg+DQo+ID4gDQo+ID4g I2luY2x1ZGUgPGFzbS91YWNjZXNzLmg+DQo+ID4gDQo+ID4gQEAgLTExOTAsNyArMTE4OSw3IEBA IHUzMiBfbmZzX2Rpc3BsYXlfZmhhbmRsZV9oYXNoKGNvbnN0IHN0cnVjdCBuZnNfZmggKmZoKQ0K PiA+IHsNCj4gPiAJLyogd2lyZXNoYXJrIHVzZXMgMzItYml0IEFVVE9ESU4gY3JjIGFuZCBkb2Vz IGEgYml0d2lzZQ0KPiA+IAkgKiBub3Qgb24gdGhlIHJlc3VsdCAqLw0KPiA+IC0JcmV0dXJuIH5j cmMzMigweEZGRkZGRkZGLCAmZmgtPmRhdGFbMF0sIGZoLT5zaXplKTsNCj4gPiArCXJldHVybiBu ZnNfZmhhbmRsZV9oYXNoKGZoKTsNCj4gPiB9DQo+ID4gDQo+ID4gLyoNCj4gPiBkaWZmIC0tZ2l0 IGEvZnMvbmZzL2ludGVybmFsLmggYi9mcy9uZnMvaW50ZXJuYWwuaA0KPiA+IGluZGV4IDliNjk0 ZjEuLjUwZjcwNjggMTAwNjQ0DQo+ID4gLS0tIGEvZnMvbmZzL2ludGVybmFsLmgNCj4gPiArKysg Yi9mcy9uZnMvaW50ZXJuYWwuaA0KPiA+IEBAIC01LDYgKzUsNyBAQA0KPiA+ICNpbmNsdWRlICJu ZnM0X2ZzLmgiDQo+ID4gI2luY2x1ZGUgPGxpbnV4L21vdW50Lmg+DQo+ID4gI2luY2x1ZGUgPGxp bnV4L3NlY3VyaXR5Lmg+DQo+ID4gKyNpbmNsdWRlIDxsaW51eC9jcmMzMi5oPg0KPiA+IA0KPiA+ ICNkZWZpbmUgTkZTX01TX01BU0sgKE1TX1JET05MWXxNU19OT1NVSUR8TVNfTk9ERVZ8TVNfTk9F WEVDfE1TX1NZTkNIUk9OT1VTKQ0KPiA+IA0KPiA+IEBAIC01NzQsMyArNTc1LDIyIEBAIHU2NCBu ZnNfdGltZXNwZWNfdG9fY2hhbmdlX2F0dHIoY29uc3Qgc3RydWN0IHRpbWVzcGVjICp0cykNCj4g PiB7DQo+ID4gCXJldHVybiAoKHU2NCl0cy0+dHZfc2VjIDw8IDMwKSArIHRzLT50dl9uc2VjOw0K PiA+IH0NCj4gPiArDQo+ID4gKyNpZmRlZiBDT05GSUdfQ1JDMzINCj4gDQo+IEdvb2QgY2F0Y2gh DQo+IA0KPiA+ICsvKioNCj4gPiArICogbmZzX2ZoYW5kbGVfaGFzaCAtIGNhbGN1bGF0ZSB0aGUg Y3JjMzIgaGFzaCBmb3IgdGhlIGZpbGVoYW5kbGUNCj4gPiArICogQGZoIC0gcG9pbnRlciB0byBm aWxlaGFuZGxlDQo+ID4gKyAqDQo+ID4gKyAqIHJldHVybnMgYSBjcmMzMiBoYXNoIGZvciB0aGUg ZmlsZWhhbmRsZSB0aGF0IGlzIGNvbXBhdGlibGUgd2l0aA0KPiA+ICsgKiB0aGUgb25lIGRpc3Bs YXllZCBieSAid2lyZXNoYXJrIi4NCj4gPiArICovDQo+ID4gK3N0YXRpYyBpbmxpbmUgdTMyIG5m c19maGFuZGxlX2hhc2goY29uc3Qgc3RydWN0IG5mc19maCAqZmgpDQo+ID4gK3sNCj4gPiArCXJl dHVybiB+Y3JjMzJfbGUoMHhGRkZGRkZGRiwgJmZoLT5kYXRhWzBdLCBmaC0+c2l6ZSk7DQo+IA0K PiBXaHkgdGhlIGNoYW5nZSB0byBjcmMzMl9sZT8gSXMgdGhhdCB3aGF0IHdpcmVzaGFyayBkb2Vz PyBJIGRvbid0IHJlbWVtYmVyIGV4YWN0bHkgd2hhdCBJIGZvdW5kIHdoZW4gSSBsb29rZWQgYXQg aG93IHdpcmVzaGFyayBtYWRlIEZIIGhhc2hlcy4NCj4gDQo+IC1kcm9zDQoNCklmIHlvdSBsb29r IGluc2lkZSBpbmNsdWRlL2xpbnV4L2NyYzMyLmgsIHlvdSdsbCBzZWUgdGhhdCBjcmMzMiBpcyBq dXN0DQphIG1hY3JvIHRoYXQgZXhwYW5kcyB0byBhIGNhbGwgdG8gdGhlIGZ1bmN0aW9uIGNyYzMy X2xlKCkuIFNvIGFsbCBJJ3ZlDQpkb25lIGlzIHRvIGV4cGFuZCB0aGUgbWFjcm8uDQoNCkNoZWVy cw0KICBUcm9uZA0KDQotLSANClRyb25kIE15a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBtYWlu dGFpbmVyDQoNCk5ldEFwcA0KVHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20NCnd3dy5uZXRhcHAu Y29tDQo=