Return-Path: linux-nfs-owner@vger.kernel.org Received: from bombadil.infradead.org ([198.137.202.9]:48683 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753612Ab3HBKbK (ORCPT ); Fri, 2 Aug 2013 06:31:10 -0400 Date: Fri, 2 Aug 2013 03:31:07 -0700 From: Christoph Hellwig To: Cong Wang Cc: netdev@vger.kernel.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, cluster-devel@redhat.com, Trond Myklebust , linux-kernel@vger.kernel.org, Steve French , "David S. Miller" Subject: Re: [Cluster-devel] [Patch net-next v2 6/8] fs: use generic union inet_addr and helper functions Message-ID: <20130802103107.GA17244@infradead.org> References: <1375427674-21735-1-git-send-email-amwang@redhat.com> <1375427674-21735-7-git-send-email-amwang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1375427674-21735-7-git-send-email-amwang@redhat.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, Aug 02, 2013 at 03:14:32PM +0800, Cong Wang wrote: > From: Cong Wang > > nfs and cifs define some helper functions for sockaddr, > they can use the generic functions for union inet_addr too. > > Since some dlm code needs to compare ->sin_port, introduce a > generic function inet_addr_equal_strict() for it. Would sound more useful to have a sockaddr_equal case that can be used on any sockaddr. For cases that no current user handles just return false.