Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx12.netapp.com ([216.240.18.77]:21762 "EHLO mx12.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756792Ab3IDOdg (ORCPT ); Wed, 4 Sep 2013 10:33:36 -0400 From: "Myklebust, Trond" To: NeilBrown CC: NFS Subject: Re: [PATCH/RFC] make nfs_flush_incompatible more forgiving. Date: Wed, 4 Sep 2013 14:33:35 +0000 Message-ID: <1378305214.3527.10.camel@leira.trondhjem.org> References: <20130904113632.1a1eb337@notabene.brown> In-Reply-To: <20130904113632.1a1eb337@notabene.brown> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gV2VkLCAyMDEzLTA5LTA0IGF0IDExOjM2ICsxMDAwLCBOZWlsQnJvd24gd3JvdGU6DQo+IEhp LA0KPiAgd2UgaGF2ZSBhIGN1c3RvbWVyIHdobyBoYXMgbm90aWNlZCBhIHNpZ25pZmljYW50IHJl Z3Jlc3Npb24gaW4gTkZTDQo+ICBwZXJmb3JtYW5jZSBiZXR3ZWVuIFNMRVMxMCAoMi42LjE2Kykg YW5kIFNMRVMxMSAoMy4wKykuDQo+IA0KPiAgVGhlIHVzZSBjYXNlIGludm9sdmVzIHR3byBkaWZm ZXJlbnQgcHJvY2Vzc2VzIG9uIHRoZSBzYW1lIGNsaWVudCBtbWFwcGluZyBhDQo+ICBmaWxlIGFu ZCBtYWtpbmcgY2hhbmdlcy4NCj4gDQo+ICBJbiAyLjYuMTYsIGFsbCB0aGVzZSBjaGFuZ2VzIHdv dWxkIGJlIGNhY2hlZCBvbiB0aGUgY2xpZW50IHVudGlsIGEgZmx1c2ggb3INCj4gIGNsb3NlIG9y IG90aGVyIG5vcm1hbCBwcm9jZXNzIGZsdXNoZWQgdGhlIGNoYW5nZXMgb3V0IC0gbXVjaCB0aGUg c2FtZSBhcyBpZg0KPiAganVzdCBvbmUgcHJvY2VzcyB3YXMgYWNjZXNzaW5nIHRoZSBmaWxlLg0K PiANCj4gIEluIDMuMCB0aGUgZmlsZSBpcyBmbHVzaGVkIG91dCBldmVyeSB0aW1lIGEgZGlmZmVy ZW50IHByb2Nlc3MgcGVyZm9ybXMgYW4NCj4gIHVwZGF0ZS4gU28gaWYgdGhleSBpbnRlcmxlYXZl IGFjY2Vzc2VzLCB5b3UgZ2V0IGEgZmx1c2gtdG8tdGhlLXNlcnZlciBvbg0KPiAgZXZlcnkgYWNj ZXNzLg0KPiANCj4gIFRoaXMgaXMgY2F1c2VkIGJ5IG5mc19mbHVzaF9pbmNvbXBhdGlibGUuICBJ dCBkZWVtcyBhY2Nlc3MgdGhyb3VnaCBkaWZmZXJlbnQNCj4gIGZpbGUgZGVzY3JpcHRvcnMgdG8g YmUgaW5jb21wYXRpYmxlLiAgSG93ZXZlciBJIGRvbid0IHRoaW5rIHRoaXMgaXMNCj4gIGp1c3Rp ZmllZC4gIEFjY2Vzc2VkIHVzaW5nIGRpZmZlcmVudCBjcmVkZW50aWFscyBjYW4gcmVhc29uYWJs eSBiZSBzZWVuIGFzDQo+ICBpbmNvbXBhdGlibGUoKiksIGJ1dCBpZiB0d28gcHJvY2Vzc2VzIHdp dGggaWRlbnRpY2FsIGNyZWRlbnRpYWxzIG9wZW4gdGhlDQo+ICBzYW1lIGZpbGUgdGhlcmUgdGhl cmUgc2hvdWxkIGJlIG5vdCBuZWVkIHRvIGRpZmZlcmVudGlhdGUgYmV0d2VlbiB0aGVtLg0KPiAN Cj4gIFRoZSBwYXRjaCBiZWxvdyBjaGFuZ2VzIHRoZSB0ZXN0IGluIG5mc19mbHVzaF9pbmNvbXBh dGlibGUgdG8ganVzdCB0ZXN0IHRoZQ0KPiAgY3JlZGVudGlhbHMgKGFuZCB0aGUgZGVudHJ5LCB0 aG91Z2ggdGhhdCBtaWdodCBiZSBzdXBlcmZsdW91cyAtIGl0IHNlZW1zDQo+ICBzYWZlcikuDQo+ IA0KPiAoKikgSW4gdGhpcyBzcGVjaWZpYyBjdXN0b21lcidzIGNhc2UgdGhlIHByb2Nlc3MgZG8g Y3VycmVudGx5IGhhdmUgc2xpZ2h0bHkNCj4gIGRpZmZlcmVudCBjcmVkZW50aWFscy4gIEluIG9u ZSwgdGhlIHByaW1hcnkgZ2lkIGlzIGluY2x1ZGVkIGluIHRoZSBsaXN0IG9mDQo+ICBhdXhpbGlh cnkgZ2lkcy4gIEluIHRoZSBvdGhlciB0aGUgcHJpbWFyeSBnaWQgaXMgZXhjbHVkZWQuICBUaGlz IGlzIGVub3VnaA0KPiAgdG8gbWFrZSB0aGUgY3JlZGVudGlhbHMgYXBwZWFyIGRpZmZlcmVudCBz byB0aGlzIHBhdGNoIGRvZXNuJ3QgaGVscCBpbiB0aGF0DQo+ICBjYXNlLiAgVGhleSBhcmUgbG9v a2luZyBhdCBiZWluZyBtb3JlIGNvbnNpc3RlbnQgaW4gdGhlaXIgc2V0Z3JvdXBzIHVzYWdlDQo+ ICBidXQgaXQgd291bGQgaGVscCB0aGVtIGlmIHdlIG9ubHkgYWN0dWFsbHkgY29tcGFyZWQgdGhl IGNyZWRlbnRpYWxzIHRoYXQNCj4gIHdlcmUgaW1wb3J0YW50LiAgSW4gdGhpcyBjYXNlIHRoZXJl IGlzIG5vIGltcG9ydGFudCBkaWZmZXJlbmNlLg0KPiAgV291bGQgaXQgbWFrZSBzZW5zZSB0byB0 cmVhdCBhIG1vcmUgYnJvYWQgY3JlZGVudGlhbCBhcyBjb21wYXRpYmxlIHdpdGggYQ0KPiAgbW9y ZSBuYXJyb3cgY3JlZGVudGlhbD8gIFNvIGEgd3JpdGUgZnJvbSBhIHByb2Nlc3Mgd2l0aCBhIGdp dmVuDQo+ICB1aWQsZ2lkLGdyb3VwbGlzdCBjb3VsZCB1bHRpbWF0ZWx5IGJlIHNlbnQgdG8gdGhl IHNlcnZlciB3aXRoIHNhbWUgdWlkL2dpZCwNCj4gIGJ1dCBhIHN1YnNldCBvZiB0aGUgZ3JvdXAg bGlzdD8NCj4gIA0KPiANCj4gIFRob3VnaHRzPw0KPiANCj4gVGhhbmtzLA0KPiBOZWlsQnJvd24N Cj4gDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZnMvbmZzL3dyaXRlLmMgYi9mcy9uZnMvd3JpdGUuYw0K PiBpbmRleCA3ODE2ODAxLi5iMGQ0ZTQ3IDEwMDY0NA0KPiAtLS0gYS9mcy9uZnMvd3JpdGUuYw0K PiArKysgYi9mcy9uZnMvd3JpdGUuYw0KPiBAQCAtODYwLDcgKzg2MCwxMiBAQCBpbnQgbmZzX2Zs dXNoX2luY29tcGF0aWJsZShzdHJ1Y3QgZmlsZSAqZmlsZSwgc3RydWN0IHBhZ2UgKnBhZ2UpDQo+ ICAJCWlmIChyZXEgPT0gTlVMTCkNCj4gIAkJCXJldHVybiAwOw0KPiAgCQlsX2N0eCA9IHJlcS0+ d2JfbG9ja19jb250ZXh0Ow0KPiAtCQlkb19mbHVzaCA9IHJlcS0+d2JfcGFnZSAhPSBwYWdlIHx8 IHJlcS0+d2JfY29udGV4dCAhPSBjdHg7DQo+ICsJCWRvX2ZsdXNoID0gcmVxLT53Yl9wYWdlICE9 IHBhZ2U7DQo+ICsJCWlmIChyZXEtPndiX2NvbnRleHQgIT0gY3R4KSB7DQo+ICsJCQlkb19mbHVz aCB8PQ0KPiArCQkJCXJlcS0+d2JfY29udGV4dC0+ZGVudHJ5ICE9IGN0eC0+ZGVudHJ5IHx8DQo+ ICsJCQkJcmVxLT53Yl9jb250ZXh0LT5jcmVkICE9IGN0eC0+Y3JlZDsNCj4gKwkJfQ0KPiAgCQlp ZiAobF9jdHgpIHsNCj4gIAkJCWRvX2ZsdXNoIHw9IGxfY3R4LT5sb2Nrb3duZXIubF9vd25lciAh PSBjdXJyZW50LT5maWxlcw0KPiAgCQkJCXx8IGxfY3R4LT5sb2Nrb3duZXIubF9waWQgIT0gY3Vy cmVudC0+dGdpZDsNCg0KSGkgTmVpbCwNCg0KV29uJ3QgdGhpcyBjYXVzZSBhbnkgd3JpdGUgZXJy b3JzIHRvIGJlIHByb3BhZ2F0ZWQgdG8gdGhlIHdyb25nIHByb2Nlc3M/DQoNCkNoZWVycw0KICBU cm9uZA0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRhaW5lcg0K DQpOZXRBcHANClRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tDQp3d3cubmV0YXBwLmNvbQ0K