Message-ID: <525CBA1E.3030209@huawei.com>
Date: Tue, 15 Oct 2013 11:44:30 +0800
From: wangweidong <wangweidong1@huawei.com>
MIME-Version: 1.0
To: <davem@davemloft.net>, <Trond.Myklebust@netapp.com>,
        <bfields@fieldses.org>
CC: <netdev@vger.kernel.org>, <linux-nfs@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <dingtianhong@huawei.com>
Subject: [PACTH net-next] SUNRPC: remove an unnecessary if statement
Content-Type: text/plain; charset="ISO-8859-1"
Sender: linux-nfs-owner@vger.kernel.org

If req allocated failed just goto out_free, no need to check the
'i < num_prealloc'. There is just code simplification, no
functional changes.

Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
---
 net/sunrpc/xprt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c
index 095363e..a8e20de 100644
--- a/net/sunrpc/xprt.c
+++ b/net/sunrpc/xprt.c
@@ -1087,11 +1087,9 @@ struct rpc_xprt *xprt_alloc(struct net *net, size_t size,
 	for (i = 0; i < num_prealloc; i++) {
 		req = kzalloc(sizeof(struct rpc_rqst), GFP_KERNEL);
 		if (!req)
-			break;
+			goto out_free;
 		list_add(&req->rq_list, &xprt->free);
 	}
-	if (i < num_prealloc)
-		goto out_free;
 	if (max_alloc > num_prealloc)
 		xprt->max_reqs = max_alloc;
 	else
-- 1.7.12