Return-Path: linux-nfs-owner@vger.kernel.org Received: from fieldses.org ([174.143.236.118]:52082 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475Ab3JGSZI (ORCPT ); Mon, 7 Oct 2013 14:25:08 -0400 Date: Mon, 7 Oct 2013 14:25:06 -0400 From: "J. Bruce Fields" To: "Mkrtchyan, Tigran" Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH] pynfs: fix reporting of ignored tests Message-ID: <20131007182506.GA26432@fieldses.org> References: <1381004835-7485-1-git-send-email-tigran.mkrtchyan@desy.de> <20131007150507.GE18051@fieldses.org> <926019798.530894.1381168078530.JavaMail.zimbra@desy.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <926019798.530894.1381168078530.JavaMail.zimbra@desy.de> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, Oct 07, 2013 at 07:47:58PM +0200, Mkrtchyan, Tigran wrote: > > > ----- Original Message ----- > > From: "J. Bruce Fields" > > To: "Tigran Mkrtchyan" > > Cc: linux-nfs@vger.kernel.org > > Sent: Monday, October 7, 2013 5:05:07 PM > > Subject: Re: [PATCH] pynfs: fix reporting of ignored tests > > > > On Sat, Oct 05, 2013 at 10:27:15PM +0200, Tigran Mkrtchyan wrote: > > > currently, ignored tests reported as failure, which > > > makes fixing them quite hard. > > > > Thanks. And it's not counting warnings either? I wonder if > > The JUnit format does not have WARN. I can count them as failed. > > printresults and xml_printresults should be sharing some code? > > I can will check how code duplication can be reduced Thanks! > as well as make nfsv4.0 able to use it as well. Note testmod.py is actually shared between the two (it's a symlink), so this should be done. --b. > > Tigran. > > > > --b. > > > > > > > > Signed-off-by: Tigran Mkrtchyan > > > --- > > > nfs4.1/testmod.py | 8 +++++++- > > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > > > diff --git a/nfs4.1/testmod.py b/nfs4.1/testmod.py > > > index 3d74efe..68855de 100644 > > > --- a/nfs4.1/testmod.py > > > +++ b/nfs4.1/testmod.py > > > @@ -439,6 +439,7 @@ def printresults(tests, opts, file=None): > > > def xml_printresults(tests, file_name, suite='all'): > > > with open(file_name, 'w') as fd: > > > failures = 0 > > > + skipped = 0 > > > total_time = 0 > > > doc = xml.dom.minidom.Document() > > > testsuite = doc.createElement("testsuite") > > > @@ -455,14 +456,19 @@ def xml_printresults(tests, file_name, suite='all'): > > > testcase.setAttribute("time", str(t.time_taken)) > > > > > > total_time += t.time_taken > > > - if t.result not in (TEST_PASS, TEST_WARN): > > > + if t.result == TEST_FAIL: > > > failures += 1 > > > failure = doc.createElement("failure") > > > failure.setAttribute("message", t.result.msg) > > > err = doc.createCDATASection(''.join(t.result.tb)) > > > failure.appendChild(err) > > > testcase.appendChild(failure) > > > + elif t.result == TEST_OMIT: > > > + skipped += 1 > > > + skip = doc.createElement("skipped") > > > + testcase.appendChild(skip) > > > > > > testsuite.setAttribute("failures", str(failures)) > > > + testsuite.setAttribute("skipped", str(skipped)) > > > testsuite.setAttribute("time", str(total_time)) > > > fd.write(doc.toprettyxml(indent=" ")) > > > -- > > > 1.8.3.1 > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > >