Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-ob0-f181.google.com ([209.85.214.181]:63640 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750861Ab3JVXx3 (ORCPT ); Tue, 22 Oct 2013 19:53:29 -0400 Message-ID: <52670FF4.8070701@gmail.com> Date: Tue, 22 Oct 2013 16:53:24 -0700 From: David Daney MIME-Version: 1.0 To: Joe Perches CC: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, linux-raid@vger.kernel.org, linux-scsi@vger.kernel.org, codalist@TELEMANN.coda.cs.cmu.edu, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-nfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, keyrings@linux-nfs.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-nfs-owner@vger.kernel.org List-ID: On 10/22/2013 03:29 PM, Joe Perches wrote: > Joe Perches (24): > arm: Convert use of typedef ctl_table to struct ctl_table > ia64: Convert use of typedef ctl_table to struct ctl_table > s390: Convert use of typedef ctl_table to struct ctl_table > tile: Convert use of typedef ctl_table to struct ctl_table > cdrom: Convert use of typedef ctl_table to struct ctl_table > random: Convert use of typedef ctl_table to struct ctl_table > infiniband: Convert use of typedef ctl_table to struct ctl_table > md: Convert use of typedef ctl_table to struct ctl_table > parport: Convert use of typedef ctl_table to struct ctl_table > scsi: Convert use of typedef ctl_table to struct ctl_table > coda: Convert use of typedef ctl_table to struct ctl_table > fscache: Convert use of typedef ctl_table to struct ctl_table > lockd: Convert use of typedef ctl_table to struct ctl_table > nfs: Convert use of typedef ctl_table to struct ctl_table > inotify: Convert use of typedef ctl_table to struct ctl_table > ntfs: Convert use of typedef ctl_table to struct ctl_table > ocfs2: Convert use of typedef ctl_table to struct ctl_table > proc: Convert use of typedef ctl_table to struct ctl_table > fs: Convert use of typedef ctl_table to struct ctl_table > key: Convert use of typedef ctl_table to struct ctl_table > ipc: Convert use of typedef ctl_table to struct ctl_table > kernel: Convert use of typedef ctl_table to struct ctl_table > mm: Convert use of typedef ctl_table to struct ctl_table > security:keys: Convert use of typedef ctl_table to struct ctl_table After all this work, why not go ahead and remove the typedef? That way people won't add more users of this abomination. David Daney > > arch/arm/kernel/isa.c | 6 ++--- > arch/ia64/kernel/crash.c | 4 +-- > arch/ia64/kernel/perfmon.c | 6 ++--- > arch/s390/appldata/appldata_base.c | 10 ++++---- > arch/s390/kernel/debug.c | 2 +- > arch/s390/mm/cmm.c | 8 +++--- > arch/tile/kernel/proc.c | 4 +-- > drivers/cdrom/cdrom.c | 10 ++++---- > drivers/char/random.c | 4 +-- > drivers/infiniband/core/ucma.c | 2 +- > drivers/md/md.c | 6 ++--- > drivers/parport/procfs.c | 52 ++++++++++++++++++-------------------- > drivers/scsi/scsi_sysctl.c | 6 ++--- > fs/coda/sysctl.c | 4 +-- > fs/dcache.c | 2 +- > fs/drop_caches.c | 2 +- > fs/eventpoll.c | 2 +- > fs/file_table.c | 4 +-- > fs/fscache/main.c | 4 +-- > fs/inode.c | 2 +- > fs/lockd/svc.c | 6 ++--- > fs/nfs/nfs4sysctl.c | 6 ++--- > fs/nfs/sysctl.c | 6 ++--- > fs/notify/inotify/inotify_user.c | 2 +- > fs/ntfs/sysctl.c | 4 +-- > fs/ocfs2/stackglue.c | 8 +++--- > fs/proc/proc_sysctl.c | 2 +- > include/linux/key.h | 2 +- > ipc/ipc_sysctl.c | 14 +++++----- > ipc/mq_sysctl.c | 10 ++++---- > kernel/sysctl.c | 2 +- > kernel/utsname_sysctl.c | 6 ++--- > mm/page-writeback.c | 2 +- > mm/page_alloc.c | 12 ++++----- > security/keys/sysctl.c | 2 +- > 35 files changed, 111 insertions(+), 113 deletions(-) >